Fix Append On Upsert (#53)

Author: henriqueleite42

CHANGELOG.md

@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-- Fix types of not implemented repository methods
+### Fixed
+
+- Types of not implemented repository methods
+- `Append` on upsert
 
 ### Removed

package.json

@@ -28,7 +28,7 @@
 		"techmmunity-symbiosis"
 	],
 	"peerDependencies": {
-		"@techmmunity/symbiosis": "^0.0.25",
+		"@techmmunity/symbiosis": "^0.0.26",
 		"reflect-metadata": "^0.1.13"
 	},
 	"dependencies": {
@@ -38,7 +38,7 @@
 	},
 	"devDependencies": {
 		"@techmmunity/eslint-config": "^5.0.1",
-		"@techmmunity/symbiosis": "^0.0.25",
+		"@techmmunity/symbiosis": "^0.0.26",
 		"@types/jest": "^27.0.1",
 		"@vercel/ncc": "^0.31.1",
 		"eslint": "^8.1.0",
@@ -56,12 +56,13 @@
 		"ts-node": "ts-node",
 		"test": "jest",
 		"test:cov": "jest --coverage",
-		"build": "ncc build src/index.ts -o dist -s -m",
+		"build": "ncc build src/index.ts -o dist -s -m -e @aws-sdk/client-dynamodb -e @aws-sdk/util-dynamodb -e @techmmunity/utils",
+		"build:dev": "ncc build src/index.ts -o dist -s -m",
 		"format": "eslint . --fix --quiet",
 		"lint": "eslint . --quiet",
 		"update-dependencies": "yarn upgrade-interactive --latest",
 		"husky:pre-commit": "tsc && lint-staged",
-		"lk": "yarn build && cp package.json dist/package.json && cd dist && yarn link && cd ..",
+		"lk": "yarn build:dev && cp package.json dist/package.json && cd dist && yarn link && cd ..",
 		"ulk": "yarn unlink && yarn lk"
 	}
 }

src/lib/repository/upsert/index.ts

@@ -73,7 +73,7 @@ export const upsert = async <Entity>(
 			code: "OPERATION_FAILED",
 			origin: "DATABASE",
 			message: "Operation failed",
-			details: ["Fail to update item using the primary keys:", rawData],
+			details: ["Fail to update item using the primary keys:", rawConditions],
 		});
 	}
 

src/lib/utils/get-data-properties/get-expression-attribute-values.ts

@@ -24,6 +24,7 @@ export const getExpressionAttributeValues = (valuesMap: ValuesMap) => {
 				}
 				case "append": {
 					valuesEntriesToReturn.push([valueAlias, value.values]);
+					valuesEntriesToReturn.push([":emptyList", []]);
 
 					return;
 				}

src/lib/utils/get-data-properties/get-update-expression.ts

@@ -37,7 +37,7 @@ export const getUpdateExpression = <Entity>({
 
 				case "append":
 					expressions.set.push(
-						`${keyAlias} = list_append(${keyAlias}, ${valueAlias})`,
+						`${keyAlias} = list_append(if_not_exists(${keyAlias}, :emptyList), ${valueAlias})`,
 					);
 					break;
 

src/tests/utils/get-data-properties/get-expression-attribute-values.spec.ts

@@ -64,6 +64,8 @@ describe("getExpressionAttributeValues", () => {
 			expect(result).toStrictEqual({
 				// eslint-disable-next-line @typescript-eslint/naming-convention
 				":UPDATEbar": { L: [{ N: "1" }, { N: "2" }] },
+				// eslint-disable-next-line @typescript-eslint/naming-convention
+				":emptyList": { L: [] },
 			});
 		});
 

src/tests/utils/get-data-properties/get-update-expression.spec.ts

@@ -117,7 +117,7 @@ describe("getUpdateExpression", () => {
 			}
 
 			expect(result).toBe(
-				"SET #UPDATEfoo = :UPDATEfoo, #UPDATEbar = :UPDATEbar, #UPDATEfoobar = :UPDATEfoobar, #UPDATEbarfoo = list_append(#UPDATEbarfoo, :UPDATEbarfoo)",
+				"SET #UPDATEfoo = :UPDATEfoo, #UPDATEbar = :UPDATEbar, #UPDATEfoobar = :UPDATEfoobar, #UPDATEbarfoo = list_append(if_not_exists(#UPDATEbarfoo, :emptyList), :UPDATEbarfoo)",
 			);
 		});
 

tsconfig.json

@@ -17,6 +17,7 @@
 		"noUnusedParameters": true,
 		"sourceMap": true,
 		"incremental": true,
+		"skipLibCheck": true,
 		"types": ["node", "jest", "reflect-metadata"]
 	},
 	"include": ["src/**/*.ts", "jest.config.js"]

yarn.lock

@@ -1223,21 +1223,26 @@
     eslint-plugin-react-hooks "^4.2.1-alpha-4298ddbc5-20211023"
     eslint-plugin-sonarjs "^0.10.0"
 
-"@techmmunity/symbiosis@^0.0.25":
-  version "0.0.25"
-  resolved "https://registry.yarnpkg.com/@techmmunity/symbiosis/-/symbiosis-0.0.25.tgz#be1ad2c64a797b525dc146e0cdbb903c6b2d7b47"
-  integrity sha512-qGejrWxuPXBWOT4TjCds3Ie9jXiEMh19sh7eYUPS0AyalvHhCOlzZdyQA8fUg0XwLAGbfMltKUsk5KxiOvhoJQ==
+"@techmmunity/symbiosis@^0.0.26":
+  version "0.0.26"
+  resolved "https://registry.yarnpkg.com/@techmmunity/symbiosis/-/symbiosis-0.0.26.tgz#1c198dc854b37d00657793ff53ce33bc5a0cf154"
+  integrity sha512-WEt7CXR/ahsXKkHubmI4/cnaeCcqDw2DVZ5eZRk0w8KqcjIHRl0C8KmKpA9P8veXUdxu4TKXOSFyWfau9QfzUQ==
   dependencies:
     "@techmmunity/utils" "^1.5.0"
     change-case "^4.1.2"
     dayjs "^1.10.6"
     tiny-glob "^0.2.9"
 
-"@techmmunity/utils@^1.3.0", "@techmmunity/utils@^1.5.0":
+"@techmmunity/utils@^1.3.0":
   version "1.5.0"
   resolved "https://registry.yarnpkg.com/@techmmunity/utils/-/utils-1.5.0.tgz#2a5014536fc553206ab1a1aec11bb4b78a58a922"
   integrity sha512-kZWJsXfpm+c/3SOw7C5BiEpGeuIEIfIuGSIXszOqOah8ne6uXQPlf3V20f5EY3jX9aWZfOCz7L5SV80wHdng+g==
 
+"@techmmunity/utils@^1.5.0":
+  version "1.6.0"
+  resolved "https://registry.yarnpkg.com/@techmmunity/utils/-/utils-1.6.0.tgz#ca8e6cfa564236e7f3aac41bfdd431959a970042"
+  integrity sha512-u90x3wvPyIDEGgzWf9NL/8EoMdNPSPy/7gb3oY5NbXcnCLqLyoufpdEdU4OVQOzLV4OHzNhmk3Py57u+F5SRnQ==
+
 "@tootallnate/once@1":
   version "1.1.2"
   resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-1.1.2.tgz#ccb91445360179a04e7fe6aff78c00ffc1eeaf82"