FactoryBot::DefinitionProxy: remove definition attr_reader (#1752)

:definition was added as an attr_reader but raises an exception when
a model with an attribute called :definition is set via :method_missing.

This commit replaces the :definition method with an instance variable.

Author: CodeMeister

lib/factory_bot/definition_proxy.rb

@@ -21,7 +21,7 @@ class DefinitionProxy
 
     delegate :before, :after, :callback, to: :@definition
 
-    attr_reader :child_factories, :definition
+    attr_reader :child_factories
 
     def initialize(definition, ignore = false)
       @definition = definition
@@ -121,7 +121,7 @@ def method_missing(name, *args, &block) # rubocop:disable Style/MissingRespondTo
     # Except that no globally available sequence will be defined.
     def sequence(name, *args, &block)
       options = args.extract_options!
-      options[:uri_paths] = definition.uri_manager.to_a
+      options[:uri_paths] = @definition.uri_manager.to_a
       args << options
 
       new_sequence = Sequence.new(name, *args, &block)
@@ -177,7 +177,7 @@ def factory(name, options = {}, &block)
     end
 
     def trait(name, &block)
-      @definition.define_trait(Trait.new(name, uri_paths: definition.uri_manager.to_a, &block))
+      @definition.define_trait(Trait.new(name, uri_paths: @definition.uri_manager.to_a, &block))
     end
 
     # Creates traits for enumerable values.

spec/acceptance/defining_methods_inside_a_factory_spec.rb

@@ -17,4 +17,19 @@ def generate_name
       /Defining methods in blocks \(trait or factory\) is not supported \(generate_name\)/
     )
   end
+
+  it "accepts a method named :definition when set through :method_missing" do
+    define_model("User", definition: :string)
+
+    FactoryBot.define do
+      factory :user do
+        definition do
+          "Jester"
+        end
+      end
+    end
+
+    user = FactoryBot.build(:user)
+    expect(user.definition).to eq("Jester")
+  end
 end