Skip to content

Commit 9834eac

Browse files
committed
Change type to ID
While this is a breaking change, Fragments is a specific feature for Superglue. This updates the naming so we use id instead of type.
1 parent 64cad99 commit 9834eac

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

lib/props_template/extensions/fragment.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@ def initialize(base, fragments = [])
99

1010
def handle(options)
1111
return if !options[:partial]
12-
partial_name, partial_opts = options[:partial]
12+
_partial_name, partial_opts = options[:partial]
1313
fragment = partial_opts[:fragment]
1414

1515
if String === fragment || Symbol === fragment
16-
fragment_name = fragment.to_s
16+
key = fragment.to_s
1717
path = @base.traveled_path.join(".")
18-
@name = fragment_name
18+
@name =key
1919

2020
@fragments.push(
21-
{type: fragment_name, partial: partial_name, path: path}
21+
{id: key, path: path}
2222
)
2323
end
2424
end

spec/extensions/fragments_spec.rb

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
}
2525
},
2626
fragments: [
27-
{type: :simple, partial: "simple", path: "outer.inner"},
28-
{type: :simple, partial: "simple", path: "outer.inner2"}
27+
{id: :simple, path: "outer.inner"},
28+
{id: :simple, path: "outer.inner2"}
2929
]
3030
})
3131
end
@@ -60,7 +60,7 @@
6060
}
6161
},
6262
fragments: [
63-
{type: :simple, partial: "simple", path: "outer.inner.simple"}
63+
{id: :simple, path: "outer.inner.simple"}
6464
]
6565
})
6666
end
@@ -81,7 +81,7 @@
8181
inner: {foo:"bar"}
8282
},
8383
fragments: [
84-
{type: "simple", partial: "simple", path: "outer.inner"}
84+
{id: "simple", path: "outer.inner"}
8585
],
8686
deferred: []
8787
})
@@ -103,7 +103,7 @@
103103
inner: {}
104104
},
105105
fragments: [
106-
{type: "simple", partial: "simple", path: "outer.inner"}
106+
{id: "simple", path: "outer.inner"}
107107
],
108108
deferred: [
109109
{url: "/?props_at=outer.inner", path: "outer.inner", type: "auto"}
@@ -135,8 +135,8 @@
135135
{firstName: "foo"}
136136
],
137137
fragments: [
138-
{type: "user_list_item", partial: "customer", path: "data.0"},
139-
{type: "user_list_item", partial: "customer", path: "data.1"}
138+
{id: "user_list_item", path: "data.0"},
139+
{id: "user_list_item", path: "data.1"}
140140
]
141141
})
142142
end
@@ -172,8 +172,8 @@
172172
}
173173
],
174174
fragments: [
175-
{type: "user", partial: "customer", path: "data.id=1"},
176-
{type: "user", partial: "customer", path: "data.id=2"}
175+
{id: "user", path: "data.id=1"},
176+
{id: "user", path: "data.id=2"}
177177
]
178178
})
179179
end
@@ -211,8 +211,8 @@
211211
}
212212
],
213213
fragments: [
214-
{type: "user", partial: "person", path: "data.id=1"},
215-
{type: "user", partial: "person", path: "data.id=2"}
214+
{id: "user", path: "data.id=1"},
215+
{id: "user", path: "data.id=2"}
216216
]
217217
})
218218
end
@@ -247,8 +247,8 @@
247247
}
248248
],
249249
fragments: [
250-
{type: "joe@red.com", partial: "person", path: "data.0"},
251-
{type: "foo@red.com", partial: "person", path: "data.1"}
250+
{id: "joe@red.com", path: "data.0"},
251+
{id: "foo@red.com", path: "data.1"}
252252
]
253253
})
254254
end

spec/extensions/partial_defer_extension_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
{url: "/some_url?props_at=outer.inner", path: "outer.inner", type: "auto"}
2727
],
2828
fragments: [
29-
{type: :simple, partial: "simple", path: "outer.inner"}
29+
{id: :simple, path: "outer.inner"}
3030
]
3131
})
3232
end
@@ -52,7 +52,7 @@
5252
{url: "/some_url?props_at=outer.inner", path: "outer.inner", type: "auto"}
5353
],
5454
fragments: [
55-
{type: :simple, partial: "simple", path: "outer.inner"}
55+
{id: :simple, path: "outer.inner"}
5656
]
5757
})
5858
end

0 commit comments

Comments
 (0)