Leave the submatchers_match? as the last check, as they're usually a slower check

stefannibrasil · stefannibrasil · commit df6157445f6a · 2025-11-19T12:57:41.000-07:00
diff --git a/lib/shoulda/matchers/active_record/association_matcher.rb b/lib/shoulda/matchers/active_record/association_matcher.rb
@@ -1692,8 +1692,8 @@ def matches?(subject)
             touch_correct? &&
             types_correct? &&
             strict_loading_correct? &&
-            submatchers_match? &&
-            deprecated_correct?
+            deprecated_correct? &&
+            submatchers_match?
         end
 
         def join_table_name
