Skip to content
forked from facebook/buck2

Commit 248ba59

Browse files
David Tolnaymeta-codesync[bot]
authored andcommitted
Fix oss-enable in apple_test.bzl (facebook#1154)
Summary: Pull Request resolved: facebook#1154 The `oss-enable` from {D87842176} are not getting enabled in open-source as intended. https://github.com/facebook/buck2/blob/fde440f6f4ad8504486d2a2e1d153c4f45549db8/prelude/apple/apple_test.bzl#L259-L262 ```lang=log,counterexample From load at implicit location Caused by: 0: From load at prelude/prelude.bzl:9 1: From load at prelude/native.bzl:17 2: From load at prelude/rules.bzl:12 3: From load at prelude/rules_impl.bzl:22 4: From load at prelude/apple/apple_rules_decls.bzl:83 5: Error evaluating module: `prelude//apple/apple_test.bzl` 6: error: Variable `local_enabled` not found --> prelude/apple/apple_test.bzl:285:8 | 285 | if local_enabled and tpx_needs_local_simulator(test_device_type): | ^^^^^^^^^^^^^ | ``` Reviewed By: milend Differential Revision: D87990886 fbshipit-source-id: b240c59e538bd794807400d10fc9d93326ad0709
1 parent d6273ee commit 248ba59

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

prelude/apple/apple_test.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,10 +256,10 @@ def _get_test_info(ctx: AnalysisContext, xctest_bundle: Artifact, test_host_app_
256256
test_device_type = get_default_test_device(sdk = sdk_name, platform = ctx.attrs.default_target_platform.name)
257257
labels.append(tpx_label_for_test_device_type(test_device_type))
258258

259-
# @oss-enable local_enabled = True
260-
# @oss-enable remote_enabled = False
261-
# @oss-enable remote_execution_properties = None
262-
# @oss-enable remote_execution_use_case = None
259+
local_enabled = True # @oss-enable
260+
remote_enabled = False # @oss-enable
261+
remote_execution_properties = None # @oss-enable
262+
remote_execution_use_case = None # @oss-enable
263263

264264
# @oss-disable[end= ]: if ctx.attrs.test_re_capabilities:
265265
# @oss-disable[end= ]: remote_execution_properties = ctx.attrs.test_re_capabilities

0 commit comments

Comments
 (0)