Skip to content
forked from facebook/buck2

Commit 421a472

Browse files
Wilfredmeta-codesync[bot]
authored andcommitted
Fix duplicate logging
Summary: As of D80819274 we make multiple buck queries when resolving aliases, but it's confusing in the logs. Tidy them up. Reviewed By: dtolnay Differential Revision: D87923515 fbshipit-source-id: b96035f06f52f7b88fc35d270bba207b67e2fc3d
1 parent f12cf1c commit 421a472

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

integrations/rust-project/src/buck.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,7 @@ impl Buck {
602602
) -> anyhow::Result<FxHashMap<Target, AliasedTargetInfo>> {
603603
let mut alias_map = self.query_aliased_dependencies(targets, universe_targets)?;
604604

605+
info!("resolving aliased targets");
605606
// Recursively expand aliases until we find a target that isn't an alias, or
606607
// we've queried buck 5 times.
607608
for _ in 0..5 {
@@ -657,7 +658,6 @@ impl Buck {
657658
.join(",");
658659
command.args(["--target-universe", &universe_arg]);
659660

660-
info!("resolving aliased targets");
661661
deserialize_output(command.output(), &command)
662662
}
663663

integrations/rust-project/src/sysroot.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ pub(crate) enum SysrootConfig {
3838
///
3939
/// `sysroot_src` is the directory that contains the source to std crates:
4040
/// <https://rust-analyzer.github.io/manual.html#non-cargo-based-projects>
41-
#[instrument]
41+
#[instrument(skip_all)]
4242
pub(crate) fn resolve_buckconfig_sysroot(
4343
buck: &Buck,
4444
project_root: &Path,

0 commit comments

Comments
 (0)