tests: address remaining PR2201 review nits

Author: thrasher-

exchanges/bybit/bybit_options_limits_test.go

@@ -28,7 +28,7 @@ func TestFetchTradablePairsFiltersNonTradingOptions(t *testing.T) {
 	preLaunchInstrument := newOptionInstrumentInfo("BTC14MAR26-85000-C", "PreLaunch")
 
 	var queries []url.Values
-	ex := newOptionsInstrumentInfoTestExchange(t, "BybitOptionsFetchTradablePairsTest", map[string][]optionInstrumentInfoResponse{
+	ex := newInstrumentInfoTestExchange(t, "BybitOptionsFetchTradablePairsTest", cOption, map[string][]optionInstrumentInfoResponse{
 		"BTC": {tradingInstrument, settlingInstrument, preLaunchInstrument},
 	}, &queries)
 
@@ -65,7 +65,7 @@ func TestUpdateOrderExecutionLimitsFiltersNonTradingOptions(t *testing.T) {
 	closedInstrument := newOptionInstrumentInfo("BTC14MAR26-85000-C", "Closed")
 
 	var queries []url.Values
-	ex := newOptionsInstrumentInfoTestExchange(t, "BybitOptionsUpdateLimitsTest", map[string][]optionInstrumentInfoResponse{
+	ex := newInstrumentInfoTestExchange(t, "BybitOptionsUpdateLimitsTest", cOption, map[string][]optionInstrumentInfoResponse{
 		"BTC": {tradingInstrument, settlingInstrument, closedInstrument},
 	}, &queries)
 
@@ -110,12 +110,6 @@ func TestUpdateOrderExecutionLimitsLeavesNonOptionsStatusHandlingUnchanged(t *te
 	assert.Equal(t, "1000", queries[0].Get("limit"), "UpdateOrderExecutionLimits should request the expected page size")
 }
 
-func newOptionsInstrumentInfoTestExchange(t *testing.T, name string, responses map[string][]optionInstrumentInfoResponse, queries *[]url.Values) *Exchange {
-	t.Helper()
-
-	return newInstrumentInfoTestExchange(t, name, cOption, responses, queries)
-}
-
 func newInstrumentInfoTestExchange(t *testing.T, name, category string, responses map[string][]optionInstrumentInfoResponse, queries *[]url.Values) *Exchange {
 	t.Helper()
 

exchanges/kucoin/kucoin_test.go

@@ -2109,7 +2109,7 @@ func TestMergeRoundedOrderbookLevels(t *testing.T) {
 			},
 		},
 		{
-			name: "adjacentduplicatesmerge",
+			name: "adjacentDuplicatesMerge",
 			levels: []orderbook.Level{
 				{Price: 1e18, Amount: 0.00001405},
 				{Price: 1e18, Amount: 0.00064},
@@ -2121,7 +2121,7 @@ func TestMergeRoundedOrderbookLevels(t *testing.T) {
 			},
 		},
 		{
-			name: "nonadjacentduplicatesremainseparate",
+			name: "nonAdjacentDuplicatesRemainSeparate",
 			levels: []orderbook.Level{
 				{Price: 1.0, Amount: 1.0},
 				{Price: 2.0, Amount: 2.0},