Skip to content

Commit 3e0aade

Browse files
committed
Rename these tests for clarity
All tests were nested under `ReliableRedisDeduplicationTests` although the last few tests to be added did not deal with deduplication. This moves the prefixing to the test names and clarify the test case name. Could also be split into classes but that seems to match what we've done elsewhere better.
1 parent 23afd7d commit 3e0aade

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/test_reliable_redis_backend.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from .mixins import RedisCleanupMixin
1919

2020

21-
class ReliableRedisDeduplicationTests(RedisCleanupMixin, unittest.TestCase):
21+
class ReliableRedisTests(RedisCleanupMixin, unittest.TestCase):
2222
longMessage = True
2323
prefix = settings.LIGHTWEIGHT_QUEUE_REDIS_PREFIX
2424

@@ -60,19 +60,19 @@ def setUp(self) -> None:
6060
self.backend = ReliableRedisBackend()
6161
self.client = self.backend.client
6262

63-
super(ReliableRedisDeduplicationTests, self).setUp()
63+
super(ReliableRedisTests, self).setUp()
6464

6565
self.start_time = datetime.datetime.utcnow()
6666

67-
def test_empty_queue(self):
67+
def test_deduplicate_empty_queue(self):
6868
result = self.backend.deduplicate('empty-queue')
6969
self.assertEqual(
7070
(0, 0),
7171
result,
7272
"Should do nothing when queue empty",
7373
)
7474

75-
def test_single_entry_in_queue(self):
75+
def test_deduplicate_single_entry_in_queue(self):
7676
QUEUE = 'single-job-queue'
7777

7878
self.enqueue_job(QUEUE)
@@ -96,7 +96,7 @@ def test_single_entry_in_queue(self):
9696
"Should still be a single entry in the queue",
9797
)
9898

99-
def test_unique_entries_in_queue(self):
99+
def test_deduplicate_unique_entries_in_queue(self):
100100
QUEUE = 'unique-jobs-queue'
101101

102102
self.enqueue_job(QUEUE, args=('args1',))
@@ -121,7 +121,7 @@ def test_unique_entries_in_queue(self):
121121
"Should still be a single entry in the queue",
122122
)
123123

124-
def test_duplicate_entries_in_queue(self):
124+
def test_deduplicate_duplicate_entries_in_queue(self):
125125
QUEUE = 'duplicate-jobs-queue'
126126

127127
self.enqueue_job(QUEUE)
@@ -146,7 +146,7 @@ def test_duplicate_entries_in_queue(self):
146146
"Should still be a single entry in the queue",
147147
)
148148

149-
def test_preserves_order_with_fixed_timestamps(self):
149+
def test_deduplicate_preserves_order_with_fixed_timestamps(self):
150150
QUEUE = 'job-queue'
151151
WORKER_NUMBER = 0
152152

@@ -201,7 +201,7 @@ def test_preserves_order_with_fixed_timestamps(self):
201201
"Third job dequeued should be the third job enqueued",
202202
)
203203

204-
def test_preserves_order_with_unique_timestamps(self):
204+
def test_deduplicate_preserves_order_with_unique_timestamps(self):
205205
QUEUE = 'job-queue'
206206
WORKER_NUMBER = 0
207207

0 commit comments

Comments
 (0)