Don't enforce a maximum request timeout

Since requests may be slow (particularly if chunked and large), this allows you to configure the request / client to accept very large timeouts.
You can also disable the timeout by providing a 0 or negative value.

Author: jentfoo

client/src/main/java/org/threadly/litesockets/client/http/HTTPClient.java

@@ -219,8 +219,11 @@ public void closeAllClients() {
    * @param unit The unit the {@code timeout} value is represented in
    */
   public void setTimeout(long timeout, TimeUnit unit) {
-    this.defaultTimeoutMS = Math.min(Math.max(unit.toMillis(timeout),HTTPRequest.MIN_TIMEOUT_MS), 
-                                     HTTPRequest.MAX_TIMEOUT_MS);
+    if (timeout <= 0) {
+      this.defaultTimeoutMS = -1;
+    } else {
+      this.defaultTimeoutMS = Math.max(unit.toMillis(timeout), HTTPRequest.MIN_TIMEOUT_MS);
+    }
   }
 
   /**
@@ -635,7 +638,9 @@ private HTTPRequestWrapper(ClientHTTPRequest chr) {
       hrp.addHTTPResponseCallback(this);
       this.chr = chr;
 
-      sei.watchFuture(slf, chr.getTimeoutMS());
+      if (chr.getTimeoutMS() > 0) {
+        sei.watchFuture(slf, chr.getTimeoutMS());
+      }
       slf.failureCallback((t) -> {
         if (queue.remove(this)) {
           // was likely a timeout, avoid leaving the request suck in the queue
@@ -663,10 +668,6 @@ public void processIncomingData(ReuseableMergedByteBuffers read) {
       hrp.processData(read);
     }
 
-    public long timeTillExpired() {
-      return chr.getTimeoutMS() - (Clock.lastKnownForwardProgressingMillis() - lastRead);
-    }
-
     @Override
     public void headersFinished(HTTPResponse hr) {
       currentState = RequestState.ReadingResponseBody;

gradle.properties

@@ -1,5 +1,5 @@
 group = org.threadly
-version = 0.26-SNAPSHOT
+version = 0.26
 threadlyVersion = 5.39
 litesocketsVersion = 4.10
 org.gradle.parallel=false

protocol/src/main/java/org/threadly/litesockets/protocols/http/request/HTTPRequest.java

@@ -14,7 +14,6 @@
 public class HTTPRequest {
   public static final int DEFAULT_TIMEOUT_MS = 20000;
   public static final int MIN_TIMEOUT_MS = 500;
-  public static final int MAX_TIMEOUT_MS = 300000;
 
   private final HTTPRequestHeader request;
   private final HTTPHeaders headers;

protocol/src/main/java/org/threadly/litesockets/protocols/http/request/HTTPRequestBuilder.java

@@ -445,8 +445,12 @@ public HTTPRequestBuilder setBodyConsumer(BodyConsumer bodyConsumer) {
     return this;
   }
 
-  public HTTPRequestBuilder setTimeout(long size, TimeUnit unit) {
-    this.timeoutMS = (int)Math.min(Math.max(unit.toMillis(size),HTTPRequest.MIN_TIMEOUT_MS), HTTPRequest.MAX_TIMEOUT_MS);
+  public HTTPRequestBuilder setTimeout(long value, TimeUnit unit) {
+    if (value <= 0) {
+      this.timeoutMS = -1;
+    } else {
+      this.timeoutMS = (int)Math.max(unit.toMillis(value), HTTPRequest.MIN_TIMEOUT_MS);
+    }
     return this;
   }