WebGPURenderer: Rename Nodes to NodeManager (#1996)

Methuselah96 · web-flow · commit 0607e9a8aedb · 2026-01-23T22:19:41.000-05:00
* Update three.js

* Update

* Add src

* Update patch and delete src

* Update

* Update declarations

* Add src

* Update patch and delete src

* Update declarations

* Add src

* Update patch and delete src

* Update declarations

* Add src

* Update patch and delete src

* Update declarations
diff --git a/src-testing/changes.patch b/src-testing/changes.patch
diff --git a/src-testing/create-src.js b/src-testing/create-src.js
@@ -39,9 +39,9 @@ const files = [
     'renderers/common/extras/PMREMGenerator',
     'renderers/common/nodes/NodeBuilderState',
     'renderers/common/nodes/NodeLibrary',
+    'renderers/common/nodes/NodeManager',
     'renderers/common/nodes/NodeUniform',
     'renderers/common/nodes/NodeUniformsGroup',
-    'renderers/common/nodes/Nodes',
     'renderers/common/Animation',
     'renderers/common/Attributes',
     'renderers/common/Backend',
diff --git a/src-testing/declarations.js b/src-testing/declarations.js
@@ -17,8 +17,8 @@ const files = [
     'nodes/core/StructTypeNode',
     'nodes/core/UniformNode',
     'renderers/common/nodes/NodeBuilderState',
-    'renderers/common/nodes/Nodes',
     'renderers/common/nodes/NodeLibrary',
+    'renderers/common/nodes/NodeManager',
     'renderers/common/nodes/NodeUniform',
     'renderers/common/nodes/NodeUniformsGroup',
     'renderers/common/Animation',
diff --git a/three.js b/three.js
@@ -1 +1 @@
-Subproject commit 13b53f5975fb92d4de2876a135d4db0d3a169f54
+Subproject commit bfdbcf7862a75f63aceba4765883c72e73672a31
diff --git a/types/three/src/renderers/common/Animation.d.ts b/types/three/src/renderers/common/Animation.d.ts
@@ -1,5 +1,5 @@
 import Info from "./Info.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import Renderer from "./Renderer.js";
 export interface AnimationContext {
     requestAnimationFrame(callback: FrameRequestCallback, xrFrame?: XRFrame): number;
@@ -12,7 +12,7 @@ export interface AnimationContext {
  */
 declare class Animation {
     renderer: Renderer;
-    nodes: Nodes;
+    nodes: NodeManager;
     info: Info;
     _context: AnimationContext | null;
     _animationLoop: ((time: DOMHighResTimeStamp, xrFrame?: XRFrame) => void) | null;
@@ -24,7 +24,7 @@ declare class Animation {
      * @param {Nodes} nodes - Renderer component for managing nodes related logic.
      * @param {Info} info - Renderer component for managing metrics and monitoring data.
      */
-    constructor(renderer: Renderer, nodes: Nodes, info: Info);
+    constructor(renderer: Renderer, nodes: NodeManager, info: Info);
     /**
      * Starts the internal animation loop.
      */
diff --git a/types/three/src/renderers/common/Background.d.ts b/types/three/src/renderers/common/Background.d.ts
@@ -1,7 +1,7 @@
 import { Mesh } from "../../objects/Mesh.js";
 import { Scene } from "../../scenes/Scene.js";
 import DataMap from "./DataMap.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import RenderContext from "./RenderContext.js";
 import Renderer from "./Renderer.js";
 import RenderList from "./RenderList.js";
@@ -22,14 +22,14 @@ declare class Background extends DataMap<{
     };
 }> {
     renderer: Renderer;
-    nodes: Nodes;
+    nodes: NodeManager;
     /**
      * Constructs a new background management component.
      *
      * @param {Renderer} renderer - The renderer.
      * @param {Nodes} nodes - Renderer component for managing nodes related logic.
      */
-    constructor(renderer: Renderer, nodes: Nodes);
+    constructor(renderer: Renderer, nodes: NodeManager);
     /**
      * Updates the background for the given scene. Depending on how `Scene.background`
      * or `Scene.backgroundNode` are configured, this method might configure a simple clear
diff --git a/types/three/src/renderers/common/Bindings.d.ts b/types/three/src/renderers/common/Bindings.d.ts
@@ -4,7 +4,7 @@ import Backend from "./Backend.js";
 import BindGroup from "./BindGroup.js";
 import DataMap from "./DataMap.js";
 import Info from "./Info.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import Pipelines from "./Pipelines.js";
 import RenderObject from "./RenderObject.js";
 import Textures from "./Textures.js";
@@ -37,11 +37,11 @@ declare class Bindings extends DataMap<{
     textures: Textures;
     pipelines: Pipelines;
     attributes: Attributes;
-    nodes: Nodes;
+    nodes: NodeManager;
     info: Info;
     constructor(
         backend: Backend,
-        nodes: Nodes,
+        nodes: NodeManager,
         textures: Textures,
         attributes: Attributes,
         pipelines: Pipelines,
diff --git a/types/three/src/renderers/common/Pipelines.d.ts b/types/three/src/renderers/common/Pipelines.d.ts
@@ -4,7 +4,7 @@ import Binding from "./Binding.js";
 import Bindings from "./Bindings.js";
 import ComputePipeline from "./ComputePipeline.js";
 import DataMap from "./DataMap.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import Pipeline from "./Pipeline.js";
 import ProgrammableStage from "./ProgrammableStage.js";
 import RenderObject from "./RenderObject.js";
@@ -33,7 +33,7 @@ declare class Pipelines extends DataMap<{
     };
 }> {
     backend: Backend;
-    nodes: Nodes;
+    nodes: NodeManager;
     bindings: Bindings | null;
     caches: Map<string, Pipeline>;
     programs: {
@@ -47,7 +47,7 @@ declare class Pipelines extends DataMap<{
      * @param {Backend} backend - The renderer's backend.
      * @param {Nodes} nodes - Renderer component for managing nodes related logic.
      */
-    constructor(backend: Backend, nodes: Nodes);
+    constructor(backend: Backend, nodes: NodeManager);
     /**
      * Returns a compute pipeline for the given compute node.
      *
diff --git a/types/three/src/renderers/common/RenderObject.d.ts b/types/three/src/renderers/common/RenderObject.d.ts
@@ -13,7 +13,7 @@ import BundleGroup from "./BundleGroup.js";
 import ClippingContext from "./ClippingContext.js";
 import Geometries from "./Geometries.js";
 import NodeBuilderState from "./nodes/NodeBuilderState.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import RenderContext from "./RenderContext.js";
 import Renderer from "./Renderer.js";
 import RenderPipeline from "./RenderPipeline.js";
@@ -36,7 +36,7 @@ import RenderPipeline from "./RenderPipeline.js";
  * @private
  */
 declare class RenderObject {
-    _nodes: Nodes;
+    _nodes: NodeManager;
     _geometries: Geometries;
     id: number;
     renderer: Renderer;
@@ -95,7 +95,7 @@ declare class RenderObject {
      * @param {ClippingContext} clippingContext - The clipping context.
      */
     constructor(
-        nodes: Nodes,
+        nodes: NodeManager,
         geometries: Geometries,
         renderer: Renderer,
         object: Object3D,
diff --git a/types/three/src/renderers/common/RenderObjects.d.ts b/types/three/src/renderers/common/RenderObjects.d.ts
@@ -8,7 +8,7 @@ import ChainMap from "./ChainMap.js";
 import ClippingContext from "./ClippingContext.js";
 import Geometries from "./Geometries.js";
 import Info from "./Info.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import Pipelines from "./Pipelines.js";
 import RenderContext from "./RenderContext.js";
 import Renderer from "./Renderer.js";
@@ -20,7 +20,7 @@ import RenderObject from "./RenderObject.js";
  */
 declare class RenderObjects {
     renderer: Renderer;
-    nodes: Nodes;
+    nodes: NodeManager;
     geometries: Geometries;
     pipelines: Pipelines;
     bindings: Bindings;
@@ -40,7 +40,7 @@ declare class RenderObjects {
      */
     constructor(
         renderer: Renderer,
-        nodes: Nodes,
+        nodes: NodeManager,
         geometries: Geometries,
         pipelines: Pipelines,
         bindings: Bindings,
@@ -102,7 +102,7 @@ declare class RenderObjects {
      * @return {RenderObject} The render object.
      */
     createRenderObject(
-        nodes: Nodes,
+        nodes: NodeManager,
         geometries: Geometries,
         renderer: Renderer,
         object: Object3D,
diff --git a/types/three/src/renderers/common/Renderer.d.ts b/types/three/src/renderers/common/Renderer.d.ts
@@ -32,7 +32,7 @@ import Info from "./Info.js";
 import InspectorBase from "./InspectorBase.js";
 import Lighting from "./Lighting.js";
 import NodeLibrary from "./nodes/NodeLibrary.js";
-import Nodes from "./nodes/Nodes.js";
+import NodeManager from "./nodes/NodeManager.js";
 import Pipelines from "./Pipelines.js";
 import QuadMesh from "./QuadMesh.js";
 import RenderBundle from "./RenderBundle.js";
@@ -94,7 +94,7 @@ declare class Renderer {
     _getFallback: ((error: unknown) => Backend) | null;
     _attributes: Attributes | null;
     _geometries: Geometries | null;
-    _nodes: Nodes | null;
+    _nodes: NodeManager | null;
     _animation: Animation | null;
     _bindings: Bindings | null;
     _objects: RenderObjects | null;
diff --git a/types/three/src/renderers/common/nodes/NodeManager.d.ts b/types/three/src/renderers/common/nodes/NodeManager.d.ts
@@ -57,12 +57,6 @@ declare module "../../../scenes/Scene.js" {
  * @augments DataMap
  */
 declare class Nodes extends DataMap<{
-    /**
-     * Constructs a new nodes management component.
-     *
-     * @param {Renderer} renderer - The renderer.
-     * @param {Backend} backend - The renderer's backend.
-     */
     nodeUniformsGroup: {
         key: NodeUniformsGroup;
         value: NodeUniformsGroupData;
@@ -91,6 +85,12 @@ declare class Nodes extends DataMap<{
     cacheLib: {
         [type: string]: WeakMap<object, Node | undefined>;
     };
+    /**
+     * Constructs a new nodes management component.
+     *
+     * @param {Renderer} renderer - The renderer.
+     * @param {Backend} backend - The renderer's backend.
+     */
     constructor(renderer: Renderer, backend: Backend);
     /**
      * Returns `true` if the given node uniforms group must be updated or not.
