Add `count: number` to all THREE.Object3d seems incorrect, and is suddenly public in v183

[nkallen]

three-ts-types/types/three/src/renderers/common/Backend.d.ts

Line 9 in 3740c71

count?: number | undefined;

I have subclasses of Object3d that use "count". I'm suddenly getting typing errors (after upgrading from 180 to 183) because of this behavior. Count as a field is used only on InstancedMeshes, it's not a general property of Object3d - I feel like this change is confusing

Apparently this type has been there for a while but only with 0.183.x did Backend.d.ts get slurped in in my project.

LightShadow.d.ts → nodes/core/Node.js → ... → ContextNode → NodeBuilder → common/Renderer →
Backend.d.ts (with declare module augmentation for count)

[Methuselah96]

Yes, you are correct. I'm not sure what the correct solution should be? It seems like the new Renderer could look for the count property on any Object3D, so it seems like it could be trouble for users to define their own count property if they don't expect it to be used in the future when the new Renderer becomes the default.

The only solution I can think of is to try to move the augmentation to a file that is only used by the WebGPU exports. Maybe it's better for users to avoid defining their own count property to avoid issues in the future?