build: enable treating warnings as errors (#48)

* build: enable flag to treat warnings as errors

* ci: remove Check Warning job in the CI workflow

Author: threeal

.github/workflows/ci.yaml

@@ -36,20 +36,6 @@ jobs:
           excludes: build/*
           fail-under-line: 80
 
-  check-warning:
-    name: Check Warning
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/[email protected]
-
-      - name: Configure and build this project
-        uses: threeal/[email protected]
-        with:
-          cxx-flags: -Werror
-          args: -DBUILD_TESTING=ON
-          run-build: true
-
   check-formatting:
     name: Check Formatting
     runs-on: ubuntu-latest

CMakeLists.txt

@@ -4,7 +4,7 @@ project(example)
 
 add_library(example src/example.cpp)
 target_include_directories(example PUBLIC include)
-target_compile_options(example PRIVATE -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wpedantic)
+target_compile_options(example PRIVATE -Werror -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wpedantic)
 
 if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
   include(cmake/CPM.cmake)
@@ -21,7 +21,7 @@ if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
 
     add_executable(example_test test/example_test.cpp)
     target_link_libraries(example_test PRIVATE example Catch2::Catch2WithMain)
-    target_compile_options(example_test PRIVATE -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wpedantic)
+    target_compile_options(example_test PRIVATE -Werror -Wall -Wextra -Wshadow -Wnon-virtual-dtor -Wpedantic)
     catch_discover_tests(example_test)
   endif()
 endif()