Skip to content

Commit 2869db0

Browse files
committed
Fix frozen string literals
indirect#299
1 parent 72f4b7f commit 2869db0

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

lib/rails-footnotes/abstract_note.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def mount_table_for_hash(hash, options={})
169169
def hash_to_xml_attributes(hash)
170170
newstring = ""
171171
hash.each do |key, value|
172-
newstring << "#{key.to_s}=\"#{value.gsub('"','\"')}\" "
172+
newstring += "#{key.to_s}=\"#{value.gsub('"','\"')}\" "
173173
end
174174
return newstring
175175
end

lib/rails-footnotes/filter.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ def links
287287
html = ''
288288
order.uniq!
289289
order.each do |row|
290-
html << "#{row.is_a?(String) ? row : row.to_s.camelize}: #{links[row].join(" | \n")}<br />"
290+
html += "#{row.is_a?(String) ? row : row.to_s.camelize}: #{links[row].join(" | \n")}<br />"
291291
end
292292
html
293293
end
@@ -298,7 +298,7 @@ def fieldsets
298298
content = ''
299299
each_with_rescue(@notes) do |note|
300300
next unless note.has_fieldset?
301-
content << <<-HTML
301+
content += <<-HTML
302302
<fieldset id="#{note.to_sym}_debug_info" style="display: none">
303303
<legend>#{note.legend}</legend>
304304
<div>#{note.content}</div>
@@ -315,7 +315,7 @@ def close
315315
javascript = ''
316316
each_with_rescue(@notes) do |note|
317317
next unless note.has_fieldset?
318-
javascript << close_helper(note)
318+
javascript += close_helper(note)
319319
end
320320
javascript
321321
end

lib/rails-footnotes/notes/log_note.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ def title
3333
def content
3434
result = '<table>'
3535
log.compact.each do |l|
36-
result << "<tr><td>#{l.gsub(/\e\[.+?m/, '')}</td></tr>"
36+
result += "<tr><td>#{l.gsub(/\e\[.+?m/, '')}</td></tr>"
3737
end
38-
result << '</table>'
38+
result += '</table>'
3939
# Restore formatter
4040
Rails.logger = self.class.original_logger
4141
result

lib/rails-footnotes/notes/queries_note.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def content
3636
sql_links = []
3737
sql_links << "<a href=\"javascript:Footnotes.toggle('qtrace_#{index}')\" style=\"color:#00A;\">trace</a>"
3838

39-
html << <<-HTML
39+
html += <<-HTML
4040
<tr>
4141
<td>
4242
<b id="qtitle_#{index}">#{escape(event.type.to_s.upcase)}</b> (#{sql_links.join(' | ')})
@@ -49,7 +49,7 @@ def content
4949
</tr>
5050
HTML
5151
end
52-
html << '</table>'
52+
html += '</table>'
5353
return html
5454
end
5555

0 commit comments

Comments
 (0)