fix clippy warnings

Author: maximevanhees

src/app/client.rs

@@ -4,10 +4,10 @@ use serde_json::{self as encoder, Value};
 use std::collections::HashMap;
 use std::path::{Path, PathBuf};
 use std::sync::atomic::{AtomicU64, Ordering};
-use tokio::io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufStream};
+use tokio::io::{AsyncReadExt, AsyncWriteExt, BufStream};
 use tokio::net::UnixStream;
 
-use super::server::{Status, ZinitResponse, ZinitState};
+use super::server::Status;
 
 // JSON-RPC 2.0 structures
 #[derive(Debug, Deserialize, Serialize)]
@@ -105,7 +105,7 @@ impl Client {
         let data = data.trim_end();
 
         // Parse the JSON-RPC response - improved error handling
-        let response: JsonRpcResponse = match encoder::from_str(&data) {
+        let response: JsonRpcResponse = match encoder::from_str(data) {
             Ok(response) => response,
             Err(e) => {
                 // If we can't parse the response as JSON-RPC, this is an error

src/app/server.rs

@@ -6,7 +6,7 @@ use serde_json::{self as encoder, Value};
 use std::collections::HashMap;
 use std::path::{Path, PathBuf};
 use std::str::FromStr;
-use tokio::io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufStream};
+use tokio::io::{AsyncReadExt, AsyncWriteExt, BufStream};
 use tokio::net::{UnixListener, UnixStream};
 
 // Include the OpenRPC specification
@@ -295,7 +295,7 @@ impl Api {
                 if let Some(params) = &request.params {
                     if let Some(name) = params.get("name").and_then(|v| v.as_str()) {
                         if let Some(content) = params.get("content").and_then(|v| v.as_object()) {
-                            Api::create_service(name, content, zinit).await
+                            Api::create_service(name, content).await
                         } else {
                             Err(anyhow::anyhow!("Missing or invalid 'content' parameter"))
                         }
@@ -310,7 +310,7 @@ impl Api {
             "service.delete" => {
                 if let Some(params) = &request.params {
                     if let Some(name) = params.get("name").and_then(|v| v.as_str()) {
-                        Api::delete_service(name, zinit).await
+                        Api::delete_service(name).await
                     } else {
                         Err(anyhow::anyhow!("Missing or invalid 'name' parameter"))
                     }
@@ -322,7 +322,7 @@ impl Api {
             "service.get" => {
                 if let Some(params) = &request.params {
                     if let Some(name) = params.get("name").and_then(|v| v.as_str()) {
-                        Api::get_service(name, zinit).await
+                        Api::get_service(name).await
                     } else {
                         Err(anyhow::anyhow!("Missing or invalid 'name' parameter"))
                     }
@@ -714,7 +714,6 @@ impl Api {
     async fn create_service<S: AsRef<str>>(
         name: S,
         content: &serde_json::Map<String, Value>,
-        zinit: ZInit,
     ) -> Result<Value> {
         use std::fs;
         use std::io::Write;
@@ -749,7 +748,7 @@ impl Api {
         )))
     }
 
-    async fn delete_service<S: AsRef<str>>(name: S, zinit: ZInit) -> Result<Value> {
+    async fn delete_service<S: AsRef<str>>(name: S) -> Result<Value> {
         use std::fs;
 
         let name = name.as_ref();
@@ -776,7 +775,7 @@ impl Api {
         )))
     }
 
-    async fn get_service<S: AsRef<str>>(name: S, zinit: ZInit) -> Result<Value> {
+    async fn get_service<S: AsRef<str>>(name: S) -> Result<Value> {
         use std::fs;
 
         let name = name.as_ref();

src/bin/zinit-http.rs

@@ -1,9 +1,8 @@
 extern crate zinit;
 
-use anyhow::{Context, Result};
+use anyhow::Result;
 use clap::{App, Arg};
 use git_version::git_version;
-use std::path::Path;
 use zinit::app::client::Client;
 
 const GIT_VERSION: &str = git_version!(args = ["--tags", "--always", "--dirty=-modified"]);

src/manager/mod.rs

@@ -170,6 +170,8 @@ impl ProcessManager {
 
         let mut table = self.table.lock().await;
 
+        // FIXME: properly add child to `Child`-struct, so .wait() can be called
+        #[allow(clippy::zombie_processes)]
         let mut child = child
             .group_spawn()
             .context("failed to spawn command")?