Fix release workflow and script

- Update GitHub Actions workflow to use modern actions (softprops/action-gh-release@v1)
- Add proper permissions for contents: write
- Update checkout action to v4
- Simplify build process for both Linux and macOS workflows
- Fix release script to increment patch version instead of minor
- Add defensive tag cleanup in release script

Author: despiegk

.github/workflows/release-osx.yaml

@@ -6,27 +6,11 @@ on:
 name: Create OSX Release
 
 jobs:
-  create-release:
-    name: Create Release
-    runs-on: macos-latest
-    outputs:
-      upload_url: ${{ steps.create_release.outputs.upload_url }}
-    steps:
-      - name: Create Release
-        id: create_release
-        uses: actions/create-release@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          tag_name: ${{ github.ref }}
-          release_name: Release ${{ github.ref }} - OSX
-          draft: false
-          prerelease: false
-
   build:
     name: Build and Upload OSX Binaries
     runs-on: macos-latest
-    needs: create-release
+    permissions:
+      contents: write
     strategy:
       matrix:
         target:
@@ -46,22 +30,20 @@ jobs:
           target: ${{ matrix.target }}
           override: true
       - name: Build release
-        uses: actions-rs/cargo@v1
         env:
           CC: clang
           CXX: clang++
-        with:
-          command: build
-          args: --release --target=${{ matrix.target }}
+        run: |
+          cargo build --release --target=${{ matrix.target }}
       - name: Strip binary
         run: |
           strip target/${{ matrix.target }}/release/zinit
-      - name: Upload Release Asset
-        uses: actions/upload-release-asset@v1
+      - name: Upload Release Assets
+        uses: softprops/action-gh-release@v1
+        with:
+          files: target/${{ matrix.target }}/release/zinit
+          name: Release ${{ github.ref_name }} - OSX
+          draft: false
+          prerelease: false
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ needs.create-release.outputs.upload_url }}
-          asset_path: target/${{ matrix.target }}/release/zinit
-          asset_name: zinit-${{ matrix.target }}
-          asset_content_type: application/octet-stream

.github/workflows/release.yaml

@@ -9,41 +9,30 @@ name: Create Release
 jobs:
   build:
     name: Releasing zinit
-    # we use 18.04 to be compatible with libc version on zos
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
-      - uses: actions-rs/toolchain@v1
-        name: Install toolchain
+        uses: actions/checkout@v4
+      - name: Install Rust toolchain
+        uses: actions-rs/toolchain@v1
         with:
           toolchain: stable
           target: x86_64-unknown-linux-musl
-      - uses: actions-rs/cargo@v1
-        name: Build release
-        with:
-          command: build
-          args: --release --target=x86_64-unknown-linux-musl
-      - name: Strip
+          override: true
+      - name: Build release
+        run: |
+          cargo build --release --target=x86_64-unknown-linux-musl
+      - name: Strip binary
         run: |
           strip target/x86_64-unknown-linux-musl/release/zinit
       - name: Create Release
-        id: create_release
-        uses: actions/create-release@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        uses: softprops/action-gh-release@v1
         with:
-          tag_name: ${{ github.ref }}
-          release_name: Release ${{ github.ref }}
+          files: target/x86_64-unknown-linux-musl/release/zinit
+          name: Release ${{ github.ref_name }}
           draft: false
           prerelease: false
-      - name: Upload Release Asset
-        id: upload-release-asset
-        uses: actions/upload-release-asset@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          upload_url: ${{ steps.create_release.outputs.upload_url }}
-          asset_path: target/x86_64-unknown-linux-musl/release/zinit
-          asset_name: zinit
-          asset_content_type: application/x-pie-executable