Adjustments to the wallet proposal generator (#3788)

Refs: threshold-network/tbtc-v2#781
Depends on: threshold-network/tbtc-v2#788 (the
`client-build-test-publish` job will become green once 788 is merged and
a new `tbtc-v2@development` package with `RedemptionWatchtower` artifact
will be published to npm)

The optimistic redemption upgrade introduces a veto mechanism
(threshold-network/tbtc-v2#788) that enforces a
processing delay on each redemption request. The exact delay value
depends on the number of objections raised against the given redemption
request. The `WalletProposalValidator` contract has been modified to
include validation of that delay factor. The first change
ed9c4ae introduces the same for the
redemption proposal generator. This ensures the generator issues
proposals that conform to the on-chain validation rules and coordination
windows are not being wasted.

By the way, we are taking an opportunity to optimize the deposit sweep
proposal generation. The `WalletProposalValidator` contract enforces the
minimum age of a deposit that can become part of the proposal. The
proposal generator
was missing this check and was often producing invalid proposals that
were violating the on-chain minimum deposit age rule. We fix that in
55be487.

Author: tomaszslabon

pkg/chain/ethereum/tbtc.go

@@ -49,6 +49,7 @@ type TbtcChain struct {
 	walletRegistry          *ecdsacontract.WalletRegistry
 	sortitionPool           *ecdsacontract.EcdsaSortitionPool
 	walletProposalValidator *tbtccontract.WalletProposalValidator
+	redemptionWatchtower    *tbtccontract.RedemptionWatchtower
 }
 
 // NewTbtcChain construct a new instance of the TBTC-specific Ethereum
@@ -194,13 +195,48 @@ func newTbtcChain(
 		)
 	}
 
+	redemptionWatchtowerAddress, err := bridge.GetRedemptionWatchtower()
+	if err != nil {
+		return nil, fmt.Errorf(
+			"failed to get RedemptionWatchtower address from Bridge: [%v]",
+			err,
+		)
+	}
+
+	// The RedemptionWatchtower contract is an additional component
+	// that implements the redemption veto mechanism. It is optional
+	// and may not be present in the system. This code must be able
+	// to handle the case when the RedemptionWatchtower contract is
+	// not set.
+	var redemptionWatchtower *tbtccontract.RedemptionWatchtower
+	if redemptionWatchtowerAddress != [20]byte{} {
+		redemptionWatchtower, err =
+			tbtccontract.NewRedemptionWatchtower(
+				redemptionWatchtowerAddress,
+				baseChain.chainID,
+				baseChain.key,
+				baseChain.client,
+				baseChain.nonceManager,
+				baseChain.miningWaiter,
+				baseChain.blockCounter,
+				baseChain.transactionMutex,
+			)
+		if err != nil {
+			return nil, fmt.Errorf(
+				"failed to attach to RedemptionWatchtower contract: [%v]",
+				err,
+			)
+		}
+	}
+
 	return &TbtcChain{
 		baseChain:               baseChain,
 		bridge:                  bridge,
 		maintainerProxy:         maintainerProxy,
 		walletRegistry:          walletRegistry,
 		sortitionPool:           sortitionPool,
 		walletProposalValidator: walletProposalValidator,
+		redemptionWatchtower:    redemptionWatchtower,
 	}, nil
 }
 
@@ -2040,3 +2076,28 @@ func (tc *TbtcChain) ValidateMovingFundsProposal(
 
 	return nil
 }
+
+func (tc *TbtcChain) GetRedemptionDelay(
+	walletPublicKeyHash [20]byte,
+	redeemerOutputScript bitcoin.Script,
+) (time.Duration, error) {
+	if tc.redemptionWatchtower == nil {
+		return 0, nil
+	}
+
+	redemptionKey, err := tc.BuildRedemptionKey(walletPublicKeyHash, redeemerOutputScript)
+	if err != nil {
+		return 0, fmt.Errorf("cannot build redemption key: [%v]", err)
+	}
+
+	delay, err := tc.redemptionWatchtower.GetRedemptionDelay(redemptionKey)
+	if err != nil {
+		return 0, fmt.Errorf("cannot get redemption delay: [%v]", err)
+	}
+
+	return time.Duration(delay) * time.Second, nil
+}
+
+func (tc *TbtcChain) GetDepositMinAge() (uint32, error) {
+	return tc.walletProposalValidator.DEPOSITMINAGE()
+}

pkg/chain/ethereum/tbtc/gen/Makefile

@@ -1,7 +1,7 @@
 npm_package_name=@keep-network/tbtc-v2
 
 # Contracts for which the bindings should be generated.
-required_contracts := Bridge MaintainerProxy LightRelay LightRelayMaintainerProxy WalletProposalValidator
+required_contracts := Bridge MaintainerProxy LightRelay LightRelayMaintainerProxy WalletProposalValidator RedemptionWatchtower
 
 # There is a bug in the currently used abigen version (v1.10.19) that makes it
 # re-declaring structs used by multiple contracts