Skip to content

Commit 16ace1b

Browse files
piotr-roslaniecpiotr-roslaniec
authored
fix(ci): run Go tests across all packages (#3910)
## Summary - CI has been silently running **0 tests** because `gotestsum -- -timeout 15m` (without `./...`) only tests the root package, which has no test files - Fix: add explicit `./...` so all subpackages are tested - Also fix `peers_test.go` placeholder hostnames to match actual `config/_peers/testnet` values — this test failure was hidden by the above bug ## Root cause `gotestsum`'s default `./...` package pattern only applies when **no args** are passed after `--`. With `-- -timeout 15m`, gotestsum forwards args directly to `go test`, which defaults to `.` (current directory only). CI log confirms: `DONE 0 tests in 8.107s`. ## Test plan - [ ] CI should now run all Go tests (expect 100+ tests instead of 0) - [ ] `TestResolvePeers/sepolia_network` should pass with corrected hostnames 🤖 Generated with [Claude Code](https://claude.com/claude-code)
2 parents 25c1abc + 57f5358 commit 16ace1b

File tree

12 files changed

+103
-100
lines changed

12 files changed

+103
-100
lines changed

‎.github/workflows/client.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
docker run \
135135
--workdir /go/src/github.com/keep-network/keep-core \
136136
go-build-env \
137-
gotestsum -- -timeout 15m
137+
gotestsum -- -timeout 15m ./...
138138
139139
- name: Build Docker Runtime Image
140140
if: github.event_name != 'workflow_dispatch'

‎cmd/flags.go‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,13 @@ func initBitcoinElectrumFlags(cmd *cobra.Command, cfg *config.Config) {
202202

203203
// Initialize flags for Network configuration.
204204
func initNetworkFlags(cmd *cobra.Command, cfg *config.Config) {
205+
// TODO: Remove in v3.0.0 along with isBootstrap() in start.go and
206+
// the LibP2P.Bootstrap config field.
205207
cmd.Flags().BoolVar(
206208
&cfg.LibP2P.Bootstrap,
207209
"network.bootstrap",
208210
false,
209-
"[DEPRECATED] Run the client in bootstrap mode. This flag is deprecated and will be removed in a future release.",
211+
"[DEPRECATED: remove in v3.0] Run the client in bootstrap mode. This flag is deprecated and will be removed in v3.0.",
210212
)
211213

212214
cmd.Flags().StringSliceVar(

‎cmd/start.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ func initializeNetwork(
202202
) (net.Provider, error) {
203203
firewall := firewall.AnyApplicationPolicy(
204204
applications,
205-
firewall.EmptyAllowList,
205+
firewall.EmptyAllowList(),
206206
)
207207

208208
netProvider, err := libp2p.Connect(

‎config/_peers/mainnet‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
1+
# TODO: Add at least one additional mainnet peer across a different
2+
# operator/ASN before production rollout. A single peer is a SPOF for
3+
# initial peer discovery of fresh nodes.
14
/ip4/143.198.18.229/tcp/3919/ipfs/16Uiu2HAmDP4Z6LCogRMictJ6deGs4DRo99A5JTz5u3CLMg7URxC6

‎config/peers_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ func TestResolvePeers(t *testing.T) {
2323
"sepolia network": {
2424
network: network.Testnet,
2525
expectedPeers: []string{
26-
"/dns4/PLACEHOLDER-operator-1.test.example.com/tcp/3920/ipfs/16Uiu2HAmDrk2Bh4VNPUJfKRHTE2CvH9xfKzN4KFnmRJbGLkJFDqL",
27-
"/dns4/PLACEHOLDER-operator-2.test.example.com/tcp/3920/ipfs/16Uiu2HAm3ex8rGzwFpWYbRreRUiX9JEYCKxp7KDMzB8RZ6fQWnMa",
26+
"/dns4/keep-operator-1.test.keep-nodes.io/tcp/3920/ipfs/16Uiu2HAmDrk2Bh4VNPUJfKRHTE2CvH9xfKzN4KFnmRJbGLkJFDqL",
27+
"/dns4/keep-operator-2.test.keep-nodes.io/tcp/3920/ipfs/16Uiu2HAm3ex8rGzwFpWYbRreRUiX9JEYCKxp7KDMzB8RZ6fQWnMa",
2828
},
2929
},
3030
"developer network": {

‎go.mod‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ go 1.24
44

55
toolchain go1.24.1
66

7+
78
replace (
89
github.com/bnb-chain/tss-lib => github.com/threshold-network/tss-lib v0.0.0-20230901144531-2e712689cfbe
910
// btcd in version v.0.23 extracted `btcd/btcec` to a separate package `btcd/btcec/v2`.

‎pkg/clientinfo/metrics.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ import (
1414
type Source func() float64
1515

1616
// Names under which metrics are exposed.
17+
//
18+
// NOTE: ConnectedWellknownPeersCountMetricName was renamed from
19+
// "connected_bootstrap_count" in v2.6.0. Update any Prometheus queries or
20+
// Grafana dashboards that reference the old name.
1721
const (
1822
ConnectedPeersCountMetricName = "connected_peers_count"
1923
ConnectedWellknownPeersCountMetricName = "connected_wellknown_peers_count"

‎pkg/clientinfo/metrics_test.go‎

Lines changed: 0 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -10,74 +10,6 @@ import (
1010
"github.com/keep-network/keep-core/pkg/operator"
1111
)
1212

13-
// TestConnectedWellknownPeersCountMetricName verifies that the metric constant
14-
// for well-known peers connectivity has the correct string value used by
15-
// Prometheus for metric registration.
16-
func TestConnectedWellknownPeersCountMetricName(t *testing.T) {
17-
expected := "connected_wellknown_peers_count"
18-
actual := ConnectedWellknownPeersCountMetricName
19-
20-
if actual != expected {
21-
t.Errorf(
22-
"expected metric name %q, got %q",
23-
expected,
24-
actual,
25-
)
26-
}
27-
}
28-
29-
// TestMetricConstants verifies that all metric name constants are defined with
30-
// the expected non-empty string values. This ensures no accidental changes to
31-
// metric names that would break Prometheus queries and Grafana dashboards.
32-
func TestMetricConstants(t *testing.T) {
33-
tests := []struct {
34-
name string
35-
constant string
36-
expected string
37-
}{
38-
{
39-
name: "connected peers count",
40-
constant: ConnectedPeersCountMetricName,
41-
expected: "connected_peers_count",
42-
},
43-
{
44-
name: "connected wellknown peers count",
45-
constant: ConnectedWellknownPeersCountMetricName,
46-
expected: "connected_wellknown_peers_count",
47-
},
48-
{
49-
name: "eth connectivity",
50-
constant: EthConnectivityMetricName,
51-
expected: "eth_connectivity",
52-
},
53-
{
54-
name: "btc connectivity",
55-
constant: BtcConnectivityMetricName,
56-
expected: "btc_connectivity",
57-
},
58-
{
59-
name: "client info",
60-
constant: ClientInfoMetricName,
61-
expected: "client_info",
62-
},
63-
}
64-
65-
for _, tc := range tests {
66-
t.Run(tc.name, func(t *testing.T) {
67-
if tc.constant != tc.expected {
68-
t.Errorf(
69-
"expected metric name %q, got %q",
70-
tc.expected,
71-
tc.constant,
72-
)
73-
}
74-
if tc.constant == "" {
75-
t.Error("metric name constant must not be empty")
76-
}
77-
})
78-
}
79-
}
80-
8113
// mockTransportIdentifier implements net.TransportIdentifier for testing.
8214
type mockTransportIdentifier struct{}
8315

‎pkg/firewall/firewall.go‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,16 @@ func (al *AllowList) Contains(operatorPublicKey *operator.PublicKey) bool {
4848
return al.allowedPublicKeys[operatorPublicKey.String()]
4949
}
5050

51-
// EmptyAllowList represents an empty firewall allowlist.
52-
var EmptyAllowList = NewAllowList([]*operator.PublicKey{})
51+
// emptyAllowList is the singleton empty allowlist used in production.
52+
// All peers must pass IsRecognized checks; no bypass is available.
53+
var emptyAllowList = NewAllowList([]*operator.PublicKey{})
54+
55+
// EmptyAllowList returns the empty firewall allowlist. In production, this
56+
// ensures all peers are subject to on-chain staking verification with no
57+
// AllowList bypass.
58+
func EmptyAllowList() *AllowList {
59+
return emptyAllowList
60+
}
5361

5462
const (
5563
// PositiveIsRecognizedCachePeriod is the time period the cache maintains

‎pkg/firewall/firewall_test.go‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const cachingPeriod = time.Second
1616
func TestValidate_PeerNotRecognized_NoApplications(t *testing.T) {
1717
policy := &anyApplicationPolicy{
1818
applications: []Application{},
19-
allowList: EmptyAllowList,
19+
allowList: EmptyAllowList(),
2020
positiveResultCache: cache.NewTimeCache(cachingPeriod),
2121
negativeResultCache: cache.NewTimeCache(cachingPeriod),
2222
}
@@ -44,7 +44,7 @@ func TestValidate_PeerNotRecognized_MultipleApplications(t *testing.T) {
4444
applications: []Application{
4545
newMockApplication(),
4646
newMockApplication()},
47-
allowList: EmptyAllowList,
47+
allowList: EmptyAllowList(),
4848
positiveResultCache: cache.NewTimeCache(cachingPeriod),
4949
negativeResultCache: cache.NewTimeCache(cachingPeriod),
5050
}
@@ -71,7 +71,7 @@ func TestValidate_PeerRecognized_FirstApplicationRecognizes(t *testing.T) {
7171
applications: []Application{
7272
application,
7373
newMockApplication()},
74-
allowList: EmptyAllowList,
74+
allowList: EmptyAllowList(),
7575
positiveResultCache: cache.NewTimeCache(cachingPeriod),
7676
negativeResultCache: cache.NewTimeCache(cachingPeriod),
7777
}
@@ -100,7 +100,7 @@ func TestValidate_PeerRecognized_SecondApplicationRecognizes(t *testing.T) {
100100
applications: []Application{
101101
newMockApplication(),
102102
application},
103-
allowList: EmptyAllowList,
103+
allowList: EmptyAllowList(),
104104
positiveResultCache: cache.NewTimeCache(cachingPeriod),
105105
negativeResultCache: cache.NewTimeCache(cachingPeriod),
106106
}
@@ -139,7 +139,7 @@ func TestValidate_PeerNotRecognized_FirstApplicationReturnedError(t *testing.T)
139139
applications: []Application{
140140
application1,
141141
application2},
142-
allowList: EmptyAllowList,
142+
allowList: EmptyAllowList(),
143143
positiveResultCache: cache.NewTimeCache(cachingPeriod),
144144
negativeResultCache: cache.NewTimeCache(cachingPeriod),
145145
}
@@ -164,7 +164,7 @@ func TestValidate_PeerRecognized_Cached(t *testing.T) {
164164

165165
policy := &anyApplicationPolicy{
166166
applications: []Application{application},
167-
allowList: EmptyAllowList,
167+
allowList: EmptyAllowList(),
168168
positiveResultCache: cache.NewTimeCache(cachingPeriod),
169169
negativeResultCache: cache.NewTimeCache(cachingPeriod),
170170
}
@@ -203,7 +203,7 @@ func TestValidate_PeerNotRecognized_CacheEmptied(t *testing.T) {
203203

204204
policy := &anyApplicationPolicy{
205205
applications: []Application{application},
206-
allowList: EmptyAllowList,
206+
allowList: EmptyAllowList(),
207207
positiveResultCache: cache.NewTimeCache(cachingPeriod),
208208
negativeResultCache: cache.NewTimeCache(cachingPeriod),
209209
}
@@ -238,7 +238,7 @@ func TestValidate_PeerNotRecognized_Cached(t *testing.T) {
238238
application := newMockApplication()
239239
policy := &anyApplicationPolicy{
240240
applications: []Application{application},
241-
allowList: EmptyAllowList,
241+
allowList: EmptyAllowList(),
242242
positiveResultCache: cache.NewTimeCache(cachingPeriod),
243243
negativeResultCache: cache.NewTimeCache(cachingPeriod),
244244
}
@@ -273,7 +273,7 @@ func TestValidate_PeerRecognized_CacheEmptied(t *testing.T) {
273273

274274
policy := &anyApplicationPolicy{
275275
applications: []Application{application},
276-
allowList: EmptyAllowList,
276+
allowList: EmptyAllowList(),
277277
positiveResultCache: cache.NewTimeCache(cachingPeriod),
278278
negativeResultCache: cache.NewTimeCache(cachingPeriod),
279279
}
@@ -338,11 +338,11 @@ func TestValidate_EmptyAllowList_RecognizedPeerAccepted(t *testing.T) {
338338
err: nil,
339339
})
340340

341-
// With EmptyAllowList, a recognized peer must pass validation through
341+
// With EmptyAllowList(), a recognized peer must pass validation through
342342
// the IsRecognized path, not through an AllowList bypass.
343343
policy := &anyApplicationPolicy{
344344
applications: []Application{application},
345-
allowList: EmptyAllowList,
345+
allowList: EmptyAllowList(),
346346
positiveResultCache: cache.NewTimeCache(cachingPeriod),
347347
negativeResultCache: cache.NewTimeCache(cachingPeriod),
348348
}
@@ -361,11 +361,11 @@ func TestValidate_EmptyAllowList_UnrecognizedPeerRejected(t *testing.T) {
361361
t.Fatal(err)
362362
}
363363

364-
// With EmptyAllowList, a peer not recognized by any application must
364+
// With EmptyAllowList(), a peer not recognized by any application must
365365
// be rejected. No AllowList bypass is available.
366366
policy := &anyApplicationPolicy{
367367
applications: []Application{newMockApplication()},
368-
allowList: EmptyAllowList,
368+
allowList: EmptyAllowList(),
369369
positiveResultCache: cache.NewTimeCache(cachingPeriod),
370370
negativeResultCache: cache.NewTimeCache(cachingPeriod),
371371
}
@@ -388,7 +388,7 @@ func TestValidate_EmptyAllowList_PreviouslyAllowlistedPeerMustPassIsRecognized(t
388388
// The peer is not recognized by the application and must be rejected.
389389
policy := &anyApplicationPolicy{
390390
applications: []Application{newMockApplication()},
391-
allowList: EmptyAllowList,
391+
allowList: EmptyAllowList(),
392392
positiveResultCache: cache.NewTimeCache(cachingPeriod),
393393
negativeResultCache: cache.NewTimeCache(cachingPeriod),
394394
}

0 commit comments

Comments
 (0)