Improve the WalletRegistry.getWalletPublicKey fn

Skip retrying when the contract throws an error saying the wallet with
the given ID has not been registered. There is no need to retry this
request because the contract responds with the exact reason - the wallet
does not exist.

Author: r-czajkowski

typescript/src/lib/ethereum/wallet-registry.ts

@@ -8,7 +8,7 @@ import {
   ChainIdentifier,
   Chains,
 } from "../contracts"
-import { backoffRetrier, Hex } from "../utils"
+import { backoffRetrier, Hex, skipRetryWhenMatched } from "../utils"
 import { Event as EthersEvent } from "@ethersproject/contracts"
 import { BigNumber } from "ethers"
 import {
@@ -66,13 +66,16 @@ export class EthereumWalletRegistry
    * @see {WalletRegistry#getWalletPublicKey}
    */
   async getWalletPublicKey(walletID: Hex): Promise<Hex> {
-    const publicKey = await backoffRetrier<string>(this._totalRetryAttempts)(
-      async () => {
-        return await this._instance.getWalletPublicKey(
-          walletID.toPrefixedString()
-        )
-      }
-    )
+    const publicKey = await backoffRetrier<string>(
+      this._totalRetryAttempts,
+      undefined,
+      undefined,
+      skipRetryWhenMatched(["Wallet with the given ID has not been registered"])
+    )(async () => {
+      return await this._instance.getWalletPublicKey(
+        walletID.toPrefixedString()
+      )
+    })
     return Hex.from(publicKey.substring(2))
   }