fix(cross-chain): resolve CI lint and test failures

- Fix prettier line-length violations in Arbitrum test by breaking long
  contract name strings onto separate lines
- Fix ESLint no-param-reassign in deploy scripts by using spread
  operator instead of mutating the transaction parameter
- Update skip test assertion from isFalse to isTrue since both deploy
  scripts are now marked skip=true after successful deployment

Author: lrsaturnino

cross-chain/arbitrum/deploy_l1/01_upgrade_arbitrum_l1_bitcoin_depositor_to_v2.ts

@@ -13,13 +13,9 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
   // `prepareUpgrade` fails with "invalid address" after the implementation is
   // already deployed on-chain.
   const originalFormat = providers.Formatter.prototype.transactionResponse
-  providers.Formatter.prototype.transactionResponse = function (
-    transaction: any
-  ): any {
-    if (transaction.to === "") {
-      transaction.to = null
-    }
-    return originalFormat.call(this, transaction)
+  providers.Formatter.prototype.transactionResponse = function (tx: any): any {
+    const patched = tx.to === "" ? { ...tx, to: null } : tx
+    return originalFormat.call(this, patched)
   }
 
   const { deployer } = await helpers.signers.getNamedSigners()

cross-chain/arbitrum/test/UpgradeArbitrumL1BitcoinDepositorToV2.test.ts

@@ -60,10 +60,10 @@ describe("UpgradeArbitrumL1BitcoinDepositorToV2 - Deploy Script Structure", () =
     assert.isFunction(func.skip)
   })
 
-  it("should have skip return false by default", async () => {
+  it("should have skip return true after deployment", async () => {
     const shouldSkip = await func.skip!({} as any)
 
-    assert.isFalse(shouldSkip)
+    assert.isTrue(shouldSkip)
   })
 })
 
@@ -104,15 +104,19 @@ describe("UpgradeArbitrumL1BitcoinDepositorToV2 - Artifact Resolution", () => {
   })
 
   it("should resolve the L1BTCDepositorWormholeV2Arbitrum artifact", () => {
-    const artifact = artifacts.readArtifactSync("L1BTCDepositorWormholeV2Arbitrum")
+    const artifact = artifacts.readArtifactSync(
+      "L1BTCDepositorWormholeV2Arbitrum"
+    )
 
     assert.equal(artifact.contractName, "L1BTCDepositorWormholeV2Arbitrum")
     assert.isArray(artifact.abi)
     assert.isAbove(artifact.abi.length, 0)
   })
 
   it("should resolve V2 via ethers.getContractFactory without HH700", async () => {
-    const factory = await ethers.getContractFactory("L1BTCDepositorWormholeV2Arbitrum")
+    const factory = await ethers.getContractFactory(
+      "L1BTCDepositorWormholeV2Arbitrum"
+    )
     const initializeFragment = factory.interface.getFunction("initialize")
 
     assert.exists(factory)
@@ -122,15 +126,19 @@ describe("UpgradeArbitrumL1BitcoinDepositorToV2 - Artifact Resolution", () => {
 
   requiredAbiFunctions.forEach((fnName) => {
     it(`should include ${fnName} in the resolved artifact ABI`, () => {
-      const artifact = artifacts.readArtifactSync("L1BTCDepositorWormholeV2Arbitrum")
+      const artifact = artifacts.readArtifactSync(
+        "L1BTCDepositorWormholeV2Arbitrum"
+      )
       const functionNames = getFunctionNames(artifact.abi as AbiEntry[])
 
       assert.include(functionNames, fnName)
     })
   })
 
   it("should expose source metadata for the copied V2 artifact", () => {
-    const artifact = artifacts.readArtifactSync("L1BTCDepositorWormholeV2Arbitrum")
+    const artifact = artifacts.readArtifactSync(
+      "L1BTCDepositorWormholeV2Arbitrum"
+    )
 
     assert.equal(
       artifact.sourceName,

cross-chain/base/deploy_l1/02_upgrade_base_l1_bitcoin_depositor_to_v2.ts

@@ -13,13 +13,9 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
   // `prepareUpgrade` fails with "invalid address" after the implementation is
   // already deployed on-chain.
   const originalFormat = providers.Formatter.prototype.transactionResponse
-  providers.Formatter.prototype.transactionResponse = function (
-    transaction: any
-  ): any {
-    if (transaction.to === "") {
-      transaction.to = null
-    }
-    return originalFormat.call(this, transaction)
+  providers.Formatter.prototype.transactionResponse = function (tx: any): any {
+    const patched = tx.to === "" ? { ...tx, to: null } : tx
+    return originalFormat.call(this, patched)
   }
 
   const { deployer } = await helpers.signers.getNamedSigners()

cross-chain/base/test/UpgradeBaseL1BitcoinDepositorToV2.test.ts

@@ -84,7 +84,9 @@ describe("UpgradeBaseL1BitcoinDepositorToV2 - Artifact Resolution", () => {
   })
 
   it("should resolve V2 via ethers.getContractFactory without HH700", async () => {
-    const factory = await ethers.getContractFactory("L1BTCDepositorWormholeV2Base")
+    const factory = await ethers.getContractFactory(
+      "L1BTCDepositorWormholeV2Base"
+    )
     expect(factory).to.not.equal(undefined)
     expect(factory.interface).to.not.equal(undefined)
     expect(factory.interface.functions).to.have.property(
@@ -101,7 +103,9 @@ describe("UpgradeBaseL1BitcoinDepositorToV2 - Artifact Resolution", () => {
 
   requiredAbiFunctions.forEach((fnName) => {
     it(`should include ${fnName} in the resolved artifact ABI`, () => {
-      const artifact = artifacts.readArtifactSync("L1BTCDepositorWormholeV2Base")
+      const artifact = artifacts.readArtifactSync(
+        "L1BTCDepositorWormholeV2Base"
+      )
       const functionNames = artifact.abi
         .filter((entry: any) => entry.type === "function")
         .map((entry: any) => entry.name)
@@ -111,8 +115,15 @@ describe("UpgradeBaseL1BitcoinDepositorToV2 - Artifact Resolution", () => {
   })
 
   it("should pass OpenZeppelin prepareUpgrade for a legacy proxy", async () => {
-    const [deployer, bridge, vault, wormhole, wormholeRelayer, tokenBridge, l2Gateway] =
-      await ethers.getSigners()
+    const [
+      deployer,
+      bridge,
+      vault,
+      wormhole,
+      wormholeRelayer,
+      tokenBridge,
+      l2Gateway,
+    ] = await ethers.getSigners()
 
     // Deploy a mock vault contract that implements tbtcToken() so that
     // the legacy L1BitcoinDepositor.initialize() can call it successfully.