First set of E2E tests on iOS

Author: rwood-moz

.github/workflows/nightly-tests-mobile.yml

@@ -47,10 +47,18 @@ jobs:
           project-name: 'Thunderbird Appointment'
           build-name: 'TB Appointment Nightly Tests (Mobile): BUILD_INFO'
 
-      - name: Run E2E Tests on Production on Browserstack (Mobile)
+      - name: Prod E2E Tests on Android Chrome
         # don't send GHA failure email if any of the E2E tests fail, can be annoying (I check the jobs each day in BrowserStack)
         continue-on-error: true
         run: |
           cd ./test/e2e
           cp .env.prod.example .env
           npm run prod-nightly-tests-mobile-browserstack-android-chrome
+
+      - name: Prod E2E Tests on iOS Safari
+        # don't send GHA failure email if any of the E2E tests fail, can be annoying (I check the jobs each day in BrowserStack)
+        continue-on-error: true
+        run: |
+          cd ./test/e2e
+          cp .env.prod.example .env
+          npm run prod-nightly-tests-mobile-browserstack-ios-safari

backend/test/unit/test_schedule_availability.py

@@ -4,7 +4,6 @@
 
 
 class TestScheduleAvailability:
-
     def test_empty_availability_is_valid(self):
         # Test empty availability is valid
         schedule = schemas.ScheduleValidationIn(
@@ -17,7 +16,6 @@ def test_empty_availability_is_valid(self):
         )
         assert all_availability_is_valid(schedule)
 
-
     def test_all_availability_is_valid(self):
         # Test already sorted availabilities
         schedule = schemas.ScheduleValidationIn(
@@ -37,7 +35,7 @@ def test_all_availability_is_valid(self):
                 schemas.AvailabilityValidationIn(
                     schedule_id=1, day_of_week=2, start_time=time(9, 0), end_time=time(10, 0)
                 ),
-            ]
+            ],
         )
         assert all_availability_is_valid(schedule)
 
@@ -49,16 +47,13 @@ def test_all_availability_is_valid(self):
             schemas.AvailabilityValidationIn(
                 schedule_id=1, day_of_week=1, start_time=time(10, 0), end_time=time(11, 0)
             ),
-            schemas.AvailabilityValidationIn(
-                schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(10, 0)
-            ),
+            schemas.AvailabilityValidationIn(schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(10, 0)),
             schemas.AvailabilityValidationIn(
                 schedule_id=1, day_of_week=1, start_time=time(17, 0), end_time=time(18, 0)
             ),
         ]
         assert all_availability_is_valid(schedule)
 
-
     def test_all_availability_is_invalid(self):
         # Test overlapping end-start times
         schedule = schemas.ScheduleValidationIn(
@@ -75,15 +70,13 @@ def test_all_availability_is_invalid(self):
                 schemas.AvailabilityValidationIn(
                     schedule_id=1, day_of_week=1, start_time=time(10, 0), end_time=time(12, 0)
                 ),
-            ]
+            ],
         )
         assert not all_availability_is_valid(schedule)
 
         # Test completely overlapping slots
         schedule.availabilities = [
-            schemas.AvailabilityValidationIn(
-                schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(12, 0)
-            ),
+            schemas.AvailabilityValidationIn(schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(12, 0)),
             schemas.AvailabilityValidationIn(
                 schedule_id=1, day_of_week=1, start_time=time(10, 0), end_time=time(11, 0)
             ),
@@ -92,9 +85,7 @@ def test_all_availability_is_invalid(self):
 
         # Test slots with invalid start/end time
         schedule.availabilities = [
-            schemas.AvailabilityValidationIn(
-                schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(12, 0)
-            ),
+            schemas.AvailabilityValidationIn(schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(12, 0)),
             schemas.AvailabilityValidationIn(
                 schedule_id=1, day_of_week=1, start_time=time(14, 0), end_time=time(13, 0)
             ),
@@ -103,8 +94,6 @@ def test_all_availability_is_invalid(self):
 
         # Test slots that are too small for the defined duration
         schedule.availabilities = [
-            schemas.AvailabilityValidationIn(
-                schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(9, 15)
-            ),
+            schemas.AvailabilityValidationIn(schedule_id=1, day_of_week=1, start_time=time(9, 0), end_time=time(9, 15)),
         ]
         assert not all_availability_is_valid(schedule)

test/e2e/README.md

@@ -175,28 +175,28 @@ export BROWSERSTACK_USERNAME=<your-browserstack-user-name>
 export BROWSERSTACK_ACCESS_KEY=<your-browserstack-access-key>
 ```
 
-To run the E2E tests on BrowserStack (still in `test/e2e`):
+To run the E2E tests on Firefox Desktop on BrowserStack (still in `test/e2e`):
 
 ```bash
-npm run e2e-test-browserstack
+npm run e2e-test-browserstack-firefox
 ```
 
-To run the production sanity test on BrowserStack (still in `test/e2e`):
+To run the production sanity test on Firefox Desktop on BrowserStack (still in `test/e2e`):
 
 ```bash
-npm run prod-sanity-test-browserstack
+npm run prod-sanity-test-browserstack-firefox
 ```
 
-To run the E2E tests on mobile devices on BrowserStack (still in `test/e2e`):
+To run the E2E tests on Android Chrome on a real Google Pixel device on BrowserStack (still in `test/e2e`):
 
 ```bash
-npm run e2e-test-mobile-browserstack
+npm run e2e-tests-mobile-browserstack-android-chrome
 ```
 
-To run the nightly test suite on real mobile devices in BrowserStack (still in `test/e2e`):
+To run the E2E tests on iOS Safari on a real iPhone device on BrowserStack (still in `test/e2e`):
 
 ```bash
-npm run prod-nightly-tests-mobile-browserstack-gha
+npm run e2e-tests-mobile-browserstack-ios-safari
 ```
 
 After the tests finish in your local console you'll see a link to the BrowserStack test session; when signed into your BrowserStack account you'll be able to use that link to see the test session results including video playback.

test/e2e/browserstack-mobile-nightly.yml

@@ -37,6 +37,12 @@ platforms:
         profile:
           password_manager_enabled: false
 
+  - browserName: safari
+    osVersion: 26
+    deviceName: iPhone 17
+    playwrightConfigOptions:
+      name: Safari-iPhone17
+
 # =======================
 # Parallels per Platform
 # =======================

test/e2e/browserstack-mobile.yml

@@ -37,6 +37,12 @@ platforms:
         profile:
           password_manager_enabled: false
 
+  - browserName: safari
+    osVersion: 26
+    deviceName: iPhone 17
+    playwrightConfigOptions:
+      name: Safari-iPhone17
+  
 # =======================
 # Parallels per Platform
 # =======================

test/e2e/package-lock.json

@@ -6,13 +6,16 @@
     "e2e-test": "npx playwright test --grep e2e-suite --project=firefox",
     "e2e-test-headed": "npx playwright test --grep e2e-suite --project=firefox --headed",
     "e2e-test-browserstack-firefox": "npx browserstack-node-sdk playwright test --grep e2e-suite --project=Firefox-OSX --browserstack.buildName 'Appointment E2E Tests Firefox Desktop' --browserstack.config 'browserstack-desktop.yml'",
+    "e2e-tests-mobile-browserstack-android-chrome": "npx browserstack-node-sdk playwright test --grep e2e-mobile-suite --project=Chrome-GooglePixel10 --browserstack.buildName 'Appointment E2E Tests Android Chrome' --browserstack.config 'browserstack-mobile.yml'",
+    "e2e-tests-mobile-browserstack-ios-safari": "npx browserstack-node-sdk playwright test --grep e2e-mobile-suite --project=Safari-iPhone17 --browserstack.buildName 'Appointment E2E Tests iOS Chrome' --browserstack.config 'browserstack-mobile.yml'",
     "prod-sanity-test": "npx playwright test --grep prod-sanity --project=firefox",
     "prod-sanity-test-headed": "npx playwright test --grep prod-sanity --project=firefox --headed",
     "prod-sanity-test-browserstack-firefox": "npx browserstack-node-sdk playwright test --grep prod-sanity --project=Firefox-OSX --browserstack.buildName 'Appointment Production Sanity Test Firefox Desktop' --browserstack.config 'browserstack-desktop.yml'",
     "prod-nightly-tests-browserstack-firefox": "npx browserstack-node-sdk playwright test --grep prod-nightly --project=Firefox-OSX --browserstack.buildName 'Appointment Nightly Tests Firefox Desktop' --browserstack.config 'browserstack-desktop-nightly.yml'",
     "prod-nightly-tests-browserstack-safari": "npx browserstack-node-sdk playwright test --grep prod-nightly --project=Safari-OSX --browserstack.buildName 'Appointment Nightly Tests Safari Desktop' --browserstack.config 'browserstack-desktop-nightly.yml'",
     "prod-nightly-tests-browserstack-chromium": "npx browserstack-node-sdk playwright test --grep prod-nightly --project=Chromium-Win11 --browserstack.buildName 'Appointment Nightly Tests Chromium Desktop' --browserstack.config 'browserstack-desktop-nightly.yml'",
     "prod-nightly-tests-mobile-browserstack-android-chrome": "npx browserstack-node-sdk playwright test --grep prod-mobile-nightly --project=Chrome-GooglePixel10 --browserstack.buildName 'Appointment Nightly Tests Android Chrome' --browserstack.config 'browserstack-mobile-nightly.yml'",
+    "prod-nightly-tests-mobile-browserstack-ios-safari": "npx browserstack-node-sdk playwright test --grep prod-mobile-nightly --project=Safari-iPhone17 --browserstack.buildName 'Appointment Nightly Tests iOS Chrome' --browserstack.config 'browserstack-mobile-nightly.yml'",
     "postinstall": "npm update browserstack-node-sdk"
   },
   "keywords": [],

test/e2e/package.json

@@ -37,6 +37,7 @@ export class TBAcctsPage {
     await this.passwordInput.fill(String(TB_ACCTS_PWORD));
     await this.page.waitForTimeout(TIMEOUT_1_SECOND);
     await this.page.waitForTimeout(TIMEOUT_1_SECOND);
+    // 'force' is needed for android
     await this.signInButton.click({ force: true });
     await this.page.waitForTimeout(TIMEOUT_10_SECONDS);
   }