Fix frontend eslint errors (#843)

* Fix frontend eslint errors

* Post-review updates

Author: rwood-moz

frontend/src/App.vue

@@ -65,7 +65,7 @@ const call = createFetch({
     beforeFetch({ options }) {
       if (user?.authenticated) {
         const token = user.data.accessToken;
-        // @ts-ignore
+        // @ts-expect-error ignore headers type error
         options.headers.Authorization = `Bearer ${token}`;
       }
       return { options };
@@ -205,10 +205,13 @@ onMounted(async () => {
 
     // Hack to clear $set_once until we get confirmation that this can be filtered.
     // Move the function reference so we can patch it and still retrieve the results before we sanitize it.
+
+    /* eslint no-underscore-dangle: ["error", { "allow": ["_calculate_set_once_properties"] }] */
+
     if (posthog['_original_calculate_set_once_properties'] === undefined) {
       posthog['_original_calculate_set_once_properties'] = posthog._calculate_set_once_properties;
     }
-    posthog._calculate_set_once_properties = function (dataSetOnce?) {
+    posthog._calculate_set_once_properties = function patch(dataSetOnce?) {
       dataSetOnce = posthog['_original_calculate_set_once_properties'](dataSetOnce);
 
       if (dataSetOnce?.$initial_current_url || dataSetOnce?.$initial_pathname) {

frontend/src/components/CalendarQalendar.vue

@@ -1,6 +1,6 @@
 <script setup>
 import {
-  ref, computed, inject, toRefs, watch, onMounted
+  ref, computed, inject, toRefs, watch,
 } from 'vue';
 import { Qalendar } from 'qalendar';
 import 'qalendar/dist/style.css';
@@ -335,13 +335,13 @@ const config = ref({
   },
   dayBoundaries: {
     start: dayBoundary.value.start,
-    end: dayBoundary.value.end
+    end: dayBoundary.value.end,
   },
   eventDialog: {
     // We roll our own
     isDisabled: true,
   },
-  locale: locale === 'de' ? 'de-DE' : 'en-US'
+  locale: locale === 'de' ? 'de-DE' : 'en-US',
 });
 
 /**

frontend/src/components/DataTable.vue

@@ -4,7 +4,7 @@
  */
 import { useI18n } from 'vue-i18n';
 import { computed, ref, toRefs } from 'vue';
-import { TableDataButtonType, TableDataType, TooltipPosition } from '@/definitions';
+import { TableDataButtonType, TableDataType } from '@/definitions';
 import {
   TableDataRow, TableDataColumn, TableFilter, HTMLInputElementEvent,
 } from '@/models';
@@ -181,7 +181,7 @@ const onColumnFilter = (evt: Event, eventFilter: TableFilter, filters: TableFilt
           </tr>
         </thead>
         <tbody>
-          <tr v-for="(datum, i) in paginatedDataList" :key="datum[dataKey] as unknown as string">
+          <tr v-for="(datum) in paginatedDataList" :key="datum[dataKey] as unknown as string">
             <td v-if="allowMultiSelect">
               <input :checked="selectedRows.includes(datum)" type="checkbox" @change="(evt) => onFieldSelect(evt, datum)" />
             </td>

frontend/src/components/FTUE/CalendarProvider.vue

@@ -1,5 +1,4 @@
 <script setup lang="ts">
-import { useI18n } from 'vue-i18n';
 import {
   inject, ref,
 } from 'vue';
@@ -14,7 +13,6 @@ const {
   errorMessage,
 } = storeToRefs(ftueStore);
 const { previousStep, nextStep } = ftueStore;
-const { t } = useI18n();
 const call = inject(callKey);
 const provider = ref('google');
 

frontend/src/components/FTUE/GoogleOauthProvider.vue

@@ -31,9 +31,8 @@ const isLoading = ref(false);
 
 const ftueStore = useFTUEStore();
 const {
-  hasNextStep, hasPreviousStep, errorMessage,
+  hasNextStep, errorMessage,
 } = storeToRefs(ftueStore);
-const { previousStep, nextStep } = ftueStore;
 
 const calendarStore = useCalendarStore();
 const externalConnectionStore = useExternalConnectionsStore();

frontend/src/components/FTUE/SetupProfile.vue

@@ -20,7 +20,7 @@ const { nextStep } = ftueStore;
 const user = useUserStore();
 user.init(call);
 
-// @ts-ignore
+// @ts-expect-error ignore type err
 // See https://github.com/microsoft/TypeScript/issues/49231
 const timezoneOptions = Intl.supportedValuesOf('timeZone').map((timezone: string) => ({
   label: timezone.replaceAll('_', ' '),

frontend/src/components/FTUE/Finish.vue …ntend/src/components/FTUE/StepFinish.vuefrontend/src/components/FTUE/Finish.vue renamed to frontend/src/components/FTUE/StepFinish.vue frontend/src/components/FTUE/Finish.vue renamed to frontend/src/components/FTUE/StepFinish.vue

@@ -307,6 +307,7 @@ const saveSchedule = async (withConfirmation = true) => {
     ? await scheduleStore.updateSchedule(call, props.schedule.id, obj)
     : await scheduleStore.createSchedule(call, obj);
 
+  // eslint-disable-next-line no-prototype-builtins
   if (response.hasOwnProperty('error')) {
     // error message is in data
     scheduleCreationError.value = (response as Error).message;

frontend/src/components/ScheduleCreation.vue

@@ -1,11 +1,17 @@
 <script setup lang="ts">
-import { CalendarManagementType, CalendarProviders, MetricEvents, ColorPalette, AlertSchemes } from '@/definitions';
-import { ref, reactive, inject, onMounted, computed } from 'vue';
+import {
+  CalendarManagementType, CalendarProviders, MetricEvents, ColorPalette, AlertSchemes,
+} from '@/definitions';
+import {
+  ref, reactive, inject, onMounted, computed,
+} from 'vue';
 import { useI18n } from 'vue-i18n';
 import { useRoute, useRouter } from 'vue-router';
 import { useCalendarStore } from '@/stores/calendar-store';
 import { callKey, refreshKey } from '@/keys';
-import { CalendarResponse, CalendarListResponse, Exception, ExceptionDetail, PydanticException } from '@/models';
+import {
+  CalendarResponse, CalendarListResponse, Exception, ExceptionDetail, PydanticException,
+} from '@/models';
 import AlertBox from '@/elements/AlertBox.vue';
 import CalendarManagement from '@/components/CalendarManagement.vue';
 import CautionButton from '@/elements/CautionButton.vue';
@@ -33,6 +39,7 @@ const deleteCalendarModalTarget = ref<number>(null);
 const loading = ref(false);
 
 // handle calendar user input to add or edit calendar connections
+// eslint-disable-next-line no-shadow
 enum InputModes {
   Hidden,
   Discovery,

frontend/src/components/SettingsCalendar.vue

@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import { ColourSchemes } from '@/definitions';
-import { ref, inject, watch } from 'vue';
+import { inject, watch } from 'vue';
 import { useI18n } from 'vue-i18n';
 import { useUserStore } from '@/stores/user-store';
 import { callKey } from '@/keys';
@@ -53,7 +53,7 @@ watch(
   },
 );
 
-// @ts-ignore
+// @ts-expect-error ignore type err
 // See https://github.com/microsoft/TypeScript/issues/49231
 const timezones = Intl.supportedValuesOf('timeZone');