Skip to content

Commit 563aa61

Browse files
committed
refactor(test): update tests for Kotlin conversion of AutocryptHeaderParser and AutocryptGossipHeaderParser
1 parent feb8cd6 commit 563aa61

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParserTest.kt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import org.junit.Test
1818

1919
class AutocryptGossipHeaderParserTest {
2020

21-
private val autocryptGossipHeaderParser = AutocryptGossipHeaderParser.getInstance()
22-
2321
@Before
2422
fun setUp() {
2523
Log.logger = TestLogger()
@@ -28,7 +26,7 @@ class AutocryptGossipHeaderParserTest {
2826
@Test
2927
fun parseFromPart() {
3028
val gossipPart = MimePartStreamParser.parse(null, GOSSIP_PART.byteInputStream())
31-
val allAutocryptGossipHeaders = autocryptGossipHeaderParser.getAllAutocryptGossipHeaders(gossipPart)
29+
val allAutocryptGossipHeaders = AutocryptGossipHeaderParser.getAllAutocryptGossipHeaders(gossipPart)
3230

3331
assertThat(gossipPart.mimeType).isEqualTo("text/plain")
3432
assertThat(allAutocryptGossipHeaders).all {
@@ -42,7 +40,7 @@ class AutocryptGossipHeaderParserTest {
4240

4341
@Test
4442
fun parseString() {
45-
val gossipHeader = autocryptGossipHeaderParser.parseAutocryptGossipHeader(GOSSIP_HEADER_BOB)
43+
val gossipHeader = AutocryptGossipHeaderParser.parseAutocryptGossipHeader(GOSSIP_HEADER_BOB)
4644

4745
assertThat(gossipHeader).isNotNull().all {
4846
transform { it.keyData }.isEqualTo(GOSSIP_DATA_BOB)
@@ -52,7 +50,7 @@ class AutocryptGossipHeaderParserTest {
5250

5351
@Test
5452
fun parseHeader_missingKeydata() {
55-
val gossipHeader = autocryptGossipHeaderParser.parseAutocryptGossipHeader(
53+
val gossipHeader = AutocryptGossipHeaderParser.parseAutocryptGossipHeader(
5654
"addr=CDEF",
5755
)
5856

@@ -61,7 +59,7 @@ class AutocryptGossipHeaderParserTest {
6159

6260
@Test
6361
fun parseHeader_unknownCritical() {
64-
val gossipHeader = autocryptGossipHeaderParser.parseAutocryptGossipHeader(
62+
val gossipHeader = AutocryptGossipHeaderParser.parseAutocryptGossipHeader(
6563
"addr=bawb; somecritical=value; keydata=aGk",
6664
)
6765

@@ -70,7 +68,7 @@ class AutocryptGossipHeaderParserTest {
7068

7169
@Test
7270
fun parseHeader_unknownNonCritical() {
73-
val gossipHeader = autocryptGossipHeaderParser.parseAutocryptGossipHeader(
71+
val gossipHeader = AutocryptGossipHeaderParser.parseAutocryptGossipHeader(
7472
"addr=bawb; _somenoncritical=value; keydata=aGk",
7573
)
7674

@@ -79,7 +77,7 @@ class AutocryptGossipHeaderParserTest {
7977

8078
@Test
8179
fun parseHeader_brokenBase64() {
82-
val gossipHeader = autocryptGossipHeaderParser.parseAutocryptGossipHeader(
80+
val gossipHeader = AutocryptGossipHeaderParser.parseAutocryptGossipHeader(
8381
"addr=bawb; _somenoncritical=value; keydata=X",
8482
)
8583

legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptHeaderParserTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121

2222
public class AutocryptHeaderParserTest extends RobolectricTest {
23-
AutocryptHeaderParser autocryptHeaderParser = AutocryptHeaderParser.getInstance();
23+
AutocryptHeaderParser autocryptHeaderParser = AutocryptHeaderParser.INSTANCE;
2424

2525
@Before
2626
public void setUp() throws Exception {

0 commit comments

Comments
 (0)