Merge pull request #9990 from wmontwe/feat/8927/add-account-settings-profile-indicator

feat(account-setting): add account settings profile indicator

Author: rafaeltonholo

app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt

@@ -6,6 +6,7 @@ import net.thunderbird.core.featureflag.FeatureFlag
 import net.thunderbird.core.featureflag.FeatureFlagFactory
 import net.thunderbird.core.featureflag.FeatureFlagKey
 import net.thunderbird.core.featureflag.toFeatureFlagKey
+import net.thunderbird.feature.account.settings.AccountSettingsFeatureFlags
 
 class K9FeatureFlagFactory : FeatureFlagFactory {
     override fun createFeatureCatalog(): List<FeatureFlag> {
@@ -20,6 +21,7 @@ class K9FeatureFlagFactory : FeatureFlagFactory {
             FeatureFlag(FeatureFlagKey.UseNotificationSenderForSystemNotifications, enabled = false),
             FeatureFlag(MessageListFeatureFlags.UseComposeForMessageListItems, enabled = false),
             FeatureFlag(MessageViewFeatureFlags.ActionExportEml, enabled = true),
+            FeatureFlag(AccountSettingsFeatureFlags.EnableAvatarCustomization, enabled = false),
         )
     }
 }

app-k9mail/src/release/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt

@@ -6,11 +6,11 @@ import net.thunderbird.core.featureflag.FeatureFlag
 import net.thunderbird.core.featureflag.FeatureFlagFactory
 import net.thunderbird.core.featureflag.FeatureFlagKey
 import net.thunderbird.core.featureflag.toFeatureFlagKey
+import net.thunderbird.feature.account.settings.AccountSettingsFeatureFlags
 
 /**
  * Feature flags for K-9 Mail (release)
  */
-
 class K9FeatureFlagFactory : FeatureFlagFactory {
     override fun createFeatureCatalog(): List<FeatureFlag> {
         return listOf(
@@ -24,6 +24,7 @@ class K9FeatureFlagFactory : FeatureFlagFactory {
             FeatureFlag(FeatureFlagKey.UseNotificationSenderForSystemNotifications, enabled = false),
             FeatureFlag(MessageListFeatureFlags.UseComposeForMessageListItems, enabled = false),
             FeatureFlag(MessageViewFeatureFlags.ActionExportEml, enabled = false),
+            FeatureFlag(AccountSettingsFeatureFlags.EnableAvatarCustomization, enabled = false),
         )
     }
 }

app-thunderbird/src/beta/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt

@@ -6,6 +6,7 @@ import net.thunderbird.core.featureflag.FeatureFlag
 import net.thunderbird.core.featureflag.FeatureFlagFactory
 import net.thunderbird.core.featureflag.FeatureFlagKey
 import net.thunderbird.core.featureflag.toFeatureFlagKey
+import net.thunderbird.feature.account.settings.AccountSettingsFeatureFlags
 
 /**
  * Feature flags for Thunderbird Beta
@@ -23,6 +24,7 @@ class TbFeatureFlagFactory : FeatureFlagFactory {
             FeatureFlag(FeatureFlagKey.UseNotificationSenderForSystemNotifications, enabled = false),
             FeatureFlag(MessageListFeatureFlags.UseComposeForMessageListItems, enabled = false),
             FeatureFlag(MessageViewFeatureFlags.ActionExportEml, enabled = false),
+            FeatureFlag(AccountSettingsFeatureFlags.EnableAvatarCustomization, enabled = false),
         )
     }
 }

app-thunderbird/src/daily/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt

@@ -6,6 +6,7 @@ import net.thunderbird.core.featureflag.FeatureFlag
 import net.thunderbird.core.featureflag.FeatureFlagFactory
 import net.thunderbird.core.featureflag.FeatureFlagKey
 import net.thunderbird.core.featureflag.toFeatureFlagKey
+import net.thunderbird.feature.account.settings.AccountSettingsFeatureFlags
 
 /**
  * Feature flags for Thunderbird Daily
@@ -23,6 +24,7 @@ class TbFeatureFlagFactory : FeatureFlagFactory {
             FeatureFlag(FeatureFlagKey.UseNotificationSenderForSystemNotifications, enabled = false),
             FeatureFlag(MessageListFeatureFlags.UseComposeForMessageListItems, enabled = false),
             FeatureFlag(MessageViewFeatureFlags.ActionExportEml, enabled = true),
+            FeatureFlag(AccountSettingsFeatureFlags.EnableAvatarCustomization, enabled = false),
         )
     }
 }

app-thunderbird/src/debug/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt

@@ -6,6 +6,7 @@ import net.thunderbird.core.featureflag.FeatureFlag
 import net.thunderbird.core.featureflag.FeatureFlagFactory
 import net.thunderbird.core.featureflag.FeatureFlagKey
 import net.thunderbird.core.featureflag.toFeatureFlagKey
+import net.thunderbird.feature.account.settings.AccountSettingsFeatureFlags
 
 /**
  * Feature flags for Thunderbird Debug
@@ -23,6 +24,7 @@ class TbFeatureFlagFactory : FeatureFlagFactory {
             FeatureFlag(FeatureFlagKey.UseNotificationSenderForSystemNotifications, enabled = true),
             FeatureFlag(MessageListFeatureFlags.UseComposeForMessageListItems, enabled = false),
             FeatureFlag(MessageViewFeatureFlags.ActionExportEml, enabled = true),
+            FeatureFlag(AccountSettingsFeatureFlags.EnableAvatarCustomization, enabled = false),
         )
     }
 }

app-thunderbird/src/release/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt

@@ -6,6 +6,7 @@ import net.thunderbird.core.featureflag.FeatureFlag
 import net.thunderbird.core.featureflag.FeatureFlagFactory
 import net.thunderbird.core.featureflag.FeatureFlagKey
 import net.thunderbird.core.featureflag.toFeatureFlagKey
+import net.thunderbird.feature.account.settings.AccountSettingsFeatureFlags
 
 /**
  * Feature flags for Thunderbird (release)
@@ -23,6 +24,7 @@ class TbFeatureFlagFactory : FeatureFlagFactory {
             FeatureFlag(FeatureFlagKey.UseNotificationSenderForSystemNotifications, enabled = false),
             FeatureFlag(MessageListFeatureFlags.UseComposeForMessageListItems, enabled = false),
             FeatureFlag(MessageViewFeatureFlags.ActionExportEml, enabled = false),
+            FeatureFlag(AccountSettingsFeatureFlags.EnableAvatarCustomization, enabled = false),
         )
     }
 }

core/ui/setting/api/src/commonMain/kotlin/net/thunderbird/core/ui/setting/SettingValue.kt

@@ -69,23 +69,24 @@ sealed interface SettingValue<T> : Setting {
      * @param value The currently selected option.
      * @param options The list of available options to choose from.
      */
-    data class CompactSelectSingleOption(
+    data class CompactSelectSingleOption<T>(
         override val id: String,
         val title: () -> String,
         val description: () -> String? = { null },
-        override val value: CompactOption,
-        val options: ImmutableList<CompactOption>,
-    ) : SettingValue<CompactOption> {
+        override val value: CompactOption<T>,
+        val options: ImmutableList<CompactOption<T>>,
+    ) : SettingValue<CompactOption<T>> {
         override val requiresEditView: Boolean = false
 
         init {
             require(options.size >= 2) { "There must be at least two options." }
             require(options.size <= 4) { "There can be at most four options." }
         }
 
-        data class CompactOption(
+        data class CompactOption<T>(
             val id: String,
             val title: () -> String,
+            val value: T,
         )
     }
 

core/ui/setting/impl-dialog/src/debug/kotlin/net/thunderbird/core/ui/setting/dialog/ui/fake/FakeSettingData.kt

@@ -30,9 +30,9 @@ internal object FakeSettingData {
     )
 
     private val compactOptions = persistentListOf(
-        CompactOption("1") { "Choice 1" },
-        CompactOption("2") { "Choice 2" },
-        CompactOption("3") { "Choice 3" },
+        CompactOption(id = "1", title = { "Option 1" }, value = "1"),
+        CompactOption(id = "2", title = { "Option 2" }, value = "2"),
+        CompactOption(id = "3", title = { "Option 3" }, value = "3"),
     )
 
     val compactSelectSingleOption = SettingValue.CompactSelectSingleOption(
@@ -44,12 +44,12 @@ internal object FakeSettingData {
     )
 
     private val options = persistentListOf(
-        Option("1") { "Compact Choice 1" },
-        Option("2") { "Compact Choice 2" },
-        Option("3") { "Compact Choice 3" },
-        Option("1") { "Compact Choice 4" },
-        Option("2") { "Compact Choice 5" },
-        Option("3") { "Compact Choice 6" },
+        Option("1") { "Option 1" },
+        Option("2") { "Option 2" },
+        Option("3") { "Option 3" },
+        Option("4") { "Option 4" },
+        Option("5") { "Option 5" },
+        Option("6") { "Option 6" },
     )
 
     val selectSingleOption = SettingValue.SelectSingleOption(

core/ui/setting/impl-dialog/src/main/kotlin/net/thunderbird/core/ui/setting/dialog/ui/components/dialog/SettingDialog.kt

@@ -52,6 +52,6 @@ internal fun SettingDialog(
         }
 
         // No dialog needed
-        is SettingValue.CompactSelectSingleOption, is SettingValue.Switch -> Unit
+        is SettingValue.CompactSelectSingleOption<*>, is SettingValue.Switch -> Unit
     }
 }

core/ui/setting/impl-dialog/src/main/kotlin/net/thunderbird/core/ui/setting/dialog/ui/components/list/SettingItem.kt

@@ -63,7 +63,7 @@ private fun RenderSettingValue(
             )
         }
 
-        is SettingValue.CompactSelectSingleOption -> {
+        is SettingValue.CompactSelectSingleOption<*> -> {
             CompactSelectSingleOptionItem(
                 setting = setting,
                 onSettingValueChange = onSettingValueChange,