feat(core-setting): add setting ui impl-dialog module

Author: wmontwe

app-common/build.gradle.kts

@@ -31,6 +31,9 @@ dependencies {
     implementation(projects.core.configstore.implBackend)
 
     implementation(projects.core.featureflag)
+
+    implementation(projects.core.ui.setting.api)
+    implementation(projects.core.ui.setting.implDialog)
     implementation(projects.core.ui.legacy.theme2.common)
 
     implementation(projects.feature.account.avatar.api)

app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt

@@ -2,12 +2,14 @@ package net.thunderbird.app.common.core
 
 import net.thunderbird.app.common.core.configstore.appCommonCoreConfigStoreModule
 import net.thunderbird.app.common.core.logging.appCommonCoreLogger
+import net.thunderbird.app.common.core.ui.appCommonCoreUiModule
 import org.koin.core.module.Module
 import org.koin.dsl.module
 
 val appCommonCoreModule: Module = module {
     includes(
         appCommonCoreConfigStoreModule,
         appCommonCoreLogger,
+        appCommonCoreUiModule,
     )
 }

app-common/src/main/kotlin/net/thunderbird/app/common/core/ui/AppCommonCoreUiModule.kt

@@ -0,0 +1,9 @@
+package net.thunderbird.app.common.core.ui
+
+import net.thunderbird.core.ui.setting.SettingViewProvider
+import net.thunderbird.core.ui.setting.dialog.DialogSettingViewProvider
+import org.koin.dsl.module
+
+val appCommonCoreUiModule = module {
+    single<SettingViewProvider> { DialogSettingViewProvider() }
+}

core/ui/setting/api/src/commonMain/kotlin/net/thunderbird/core/ui/setting/SettingViewProvider.kt

@@ -0,0 +1,30 @@
+package net.thunderbird.core.ui.setting
+
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
+
+/**
+ * A provider of a settings view.
+ */
+interface SettingViewProvider {
+
+    /**
+     * A view that displays a list of settings.
+     *
+     * @param title The title of the view.
+     * @param subtitle The subtitle of the view (optional).
+     * @param settings The list of settings to display.
+     * @param onSettingValueChange The callback to be invoked when a setting value is changed.
+     * @param onBack The callback to be invoked when the back button is clicked.
+     * @param modifier The modifier to be applied to the view.
+     */
+    @Composable
+    fun SettingView(
+        title: String,
+        settings: Settings,
+        onSettingValueChange: (SettingValue<*>) -> Unit,
+        onBack: () -> Unit,
+        modifier: Modifier = Modifier,
+        subtitle: String? = null,
+    )
+}

core/ui/setting/api/src/commonMain/kotlin/net/thunderbird/core/ui/setting/Settings.kt

@@ -1,8 +1,14 @@
 package net.thunderbird.core.ui.setting
 
 import kotlinx.collections.immutable.ImmutableList
+import kotlinx.collections.immutable.persistentListOf
 
 /**
  * A immutable list of settings.
  */
 typealias Settings = ImmutableList<Setting>
+
+/**
+ * Returns an empty list of settings.
+ */
+fun emptySettings(): Settings = persistentListOf()

core/ui/setting/impl-dialog/build.gradle.kts

@@ -0,0 +1,17 @@
+plugins {
+    id(ThunderbirdPlugins.Library.androidCompose)
+    alias(libs.plugins.kotlin.parcelize)
+}
+
+android {
+    namespace = "net.thunderbird.core.ui.setting.dialog"
+    resourcePrefix = "core_ui_setting_dialog_"
+}
+
+dependencies {
+    implementation(projects.core.ui.setting.api)
+
+    implementation(projects.core.ui.compose.designsystem)
+
+    testImplementation(projects.core.ui.compose.testing)
+}

core/ui/setting/impl-dialog/src/main/kotlin/net/thunderbird/core/ui/setting/dialog/DialogSettingViewProvider.kt

@@ -0,0 +1,23 @@
+package net.thunderbird.core.ui.setting.dialog
+
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.Modifier
+import app.k9mail.core.ui.compose.designsystem.atom.text.TextTitleMedium
+import net.thunderbird.core.ui.setting.SettingValue
+import net.thunderbird.core.ui.setting.SettingViewProvider
+import net.thunderbird.core.ui.setting.Settings
+
+class DialogSettingViewProvider : SettingViewProvider {
+
+    @Composable
+    override fun SettingView(
+        title: String,
+        settings: Settings,
+        onSettingValueChange: (SettingValue<*>) -> Unit,
+        onBack: () -> Unit,
+        modifier: Modifier,
+        subtitle: String?,
+    ) {
+        TextTitleMedium("This is going to be implemented soon.")
+    }
+}

feature/account/settings/impl/build.gradle.kts

@@ -14,12 +14,16 @@ dependencies {
 
     implementation(projects.core.outcome)
 
+    implementation(projects.core.ui.setting.api)
+
     implementation(projects.core.logging.implLegacy)
     implementation(projects.core.ui.compose.designsystem)
     implementation(projects.core.ui.compose.navigation)
     implementation(projects.core.ui.compose.preference)
     implementation(projects.core.ui.legacy.theme2.common)
 
+    debugImplementation(projects.core.ui.setting.implDialog)
+
     testImplementation(projects.core.logging.testing)
     testImplementation(projects.core.ui.compose.testing)
 }

…tings/impl/ui/fake/FakePreferenceData.kt …settings/impl/ui/fake/FakeSettingData.ktfeature/account/settings/impl/src/debug/kotlin/net/thunderbird/feature/account/settings/impl/ui/fake/FakePreferenceData.kt renamed to feature/account/settings/impl/src/debug/kotlin/net/thunderbird/feature/account/settings/impl/ui/fake/FakeSettingData.kt feature/account/settings/impl/src/debug/kotlin/net/thunderbird/feature/account/settings/impl/ui/fake/FakePreferenceData.kt renamed to feature/account/settings/impl/src/debug/kotlin/net/thunderbird/feature/account/settings/impl/ui/fake/FakeSettingData.kt

@@ -9,20 +9,20 @@ import app.k9mail.core.ui.compose.designsystem.atom.icon.Icons
 import app.k9mail.core.ui.compose.designsystem.atom.text.TextBodyLarge
 import app.k9mail.core.ui.compose.theme2.MainTheme
 import kotlinx.collections.immutable.persistentListOf
-import net.thunderbird.core.ui.compose.preference.api.PreferenceDisplay
-import net.thunderbird.core.ui.compose.preference.api.PreferenceSetting
+import net.thunderbird.core.ui.setting.SettingDecoration
+import net.thunderbird.core.ui.setting.SettingValue
 
-object FakePreferenceData {
+object FakeSettingData {
 
-    val textPreference = PreferenceSetting.Text(
+    val text = SettingValue.Text(
         id = "text",
         icon = { Icons.Outlined.Info },
         title = { "Title" },
         description = { "Description" },
         value = "Value",
     )
 
-    val colorPreference = PreferenceSetting.Color(
+    val color = SettingValue.Color(
         id = "color",
         icon = { Icons.Outlined.Info },
         title = { "Title" },
@@ -35,7 +35,7 @@ object FakePreferenceData {
         ),
     )
 
-    val customPreference = PreferenceDisplay.Custom(
+    val custom = SettingDecoration.Custom(
         id = "custom",
         customUi = { modifier ->
             CardElevated(
@@ -53,20 +53,20 @@ object FakePreferenceData {
         },
     )
 
-    val sectionDivider = PreferenceDisplay.SectionDivider(
+    val sectionDivider = SettingDecoration.SectionDivider(
         id = "section_divider",
     )
 
-    val sectionHeader = PreferenceDisplay.SectionHeader(
+    val sectionHeader = SettingDecoration.SectionHeader(
         id = "section_header",
         title = { "Section Title" },
         color = { Color.Black },
     )
 
-    val preferences = persistentListOf(
-        textPreference,
-        colorPreference,
-        customPreference,
+    val settings = persistentListOf(
+        text,
+        color,
+        custom,
         sectionHeader,
         sectionDivider,
     )

feature/account/settings/impl/src/debug/kotlin/net/thunderbird/feature/account/settings/impl/ui/general/GeneralSettingsContentPreview.kt

@@ -3,7 +3,8 @@ package net.thunderbird.feature.account.settings.impl.ui.general
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.tooling.preview.Preview
 import app.k9mail.core.ui.compose.designsystem.PreviewWithTheme
-import net.thunderbird.feature.account.settings.impl.ui.fake.FakePreferenceData
+import net.thunderbird.core.ui.setting.dialog.DialogSettingViewProvider
+import net.thunderbird.feature.account.settings.impl.ui.fake.FakeSettingData
 
 @Composable
 @Preview(showBackground = true)
@@ -12,9 +13,10 @@ internal fun GeneralSettingsContentPreview() {
         GeneralSettingsContent(
             state = GeneralSettingsContract.State(
                 subtitle = "Subtitle",
-                preferences = FakePreferenceData.preferences,
+                settings = FakeSettingData.settings,
             ),
             onEvent = {},
+            provider = DialogSettingViewProvider(),
         )
     }
 }