fix:display Settings reset/mix up when toggling "Colorize contact pictures"

Author: shamim-emon

core/preference/impl/src/commonMain/kotlin/net/thunderbird/core/preference/display/visualSettings/message/list/DefaultMessageListPreferencesManager.kt

@@ -67,6 +67,9 @@ class DefaultMessageListPreferencesManager(
         storageEditor.putBoolean(KEY_SHOW_CORRESPONDENT_NAMES, preferences.isShowCorrespondentNames)
         storageEditor.putInt(KEY_MESSAGE_LIST_VIEW_PREVIEW_LINES, preferences.previewLines)
         storageEditor.putEnum(KEY_MESSAGE_LIST_VIEW_DENSITY, preferences.uiDensity)
+        storageEditor.commit().also { commited ->
+            logger.verbose(TAG) { "writeConfig: storageEditor.commit() resulted in: $commited" }
+        }
     }
 
     override fun getConfig(): DisplayMessageListSettings = preferences.value

legacy/core/src/main/java/com/fsck/k9/preferences/DefaultGeneralSettingsManager.kt

@@ -15,6 +15,7 @@ import kotlinx.coroutines.sync.Mutex
 import kotlinx.coroutines.sync.withLock
 import net.thunderbird.core.common.appConfig.PlatformConfigProvider
 import net.thunderbird.core.logging.config.DebugLogConfigurator
+import net.thunderbird.core.logging.legacy.Log.logger
 import net.thunderbird.core.preference.GeneralSettings
 import net.thunderbird.core.preference.GeneralSettingsManager
 import net.thunderbird.core.preference.PreferenceChangePublisher
@@ -24,6 +25,7 @@ import net.thunderbird.core.preference.display.coreSettings.DisplayCoreSettingsP
 import net.thunderbird.core.preference.display.inboxSettings.DisplayInboxSettingsPreferenceManager
 import net.thunderbird.core.preference.display.miscSettings.DisplayMiscSettingsPreferenceManager
 import net.thunderbird.core.preference.display.visualSettings.DisplayVisualSettingsPreferenceManager
+import net.thunderbird.core.preference.display.visualSettings.message.list.MessageListPreferencesManager
 import net.thunderbird.core.preference.interaction.InteractionSettingsPreferenceManager
 import net.thunderbird.core.preference.network.NetworkSettingsPreferenceManager
 import net.thunderbird.core.preference.notification.NotificationPreferenceManager
@@ -50,6 +52,7 @@ internal class DefaultGeneralSettingsManager(
     private val displayCoreSettingsPreferenceManager: DisplayCoreSettingsPreferenceManager,
     private val displayInboxSettingsPreferenceManager: DisplayInboxSettingsPreferenceManager,
     private val displayVisualSettingsPreferenceManager: DisplayVisualSettingsPreferenceManager,
+    private val messageListPreferencesManager: MessageListPreferencesManager,
     private val displayMiscSettingsPreferenceManager: DisplayMiscSettingsPreferenceManager,
     private val networkSettingsPreferenceManager: NetworkSettingsPreferenceManager,
     private val debuggingSettingsPreferenceManager: DebuggingSettingsPreferenceManager,
@@ -93,6 +96,16 @@ internal class DefaultGeneralSettingsManager(
                 display = generalSettings.display.copy(visualSettings = visualSettings),
             )
         }
+        .combine(messageListPreferencesManager.getConfigFlow()) { generalSettings, messageListSettings ->
+            logger.debug { "messageListSettings: $messageListSettings" }
+            generalSettings.copy(
+                display = generalSettings.display.copy(
+                    visualSettings = generalSettings.display.visualSettings.copy(
+                        messageListSettings = messageListSettings,
+                    ),
+                ),
+            )
+        }
         .combine(displayMiscSettingsPreferenceManager.getConfigFlow()) { generalSettings, miscSettings ->
             generalSettings.copy(
                 display = generalSettings.display.copy(miscSettings = miscSettings),
@@ -163,6 +176,7 @@ internal class DefaultGeneralSettingsManager(
                 displayCoreSettingsPreferenceManager.save(config.display.coreSettings)
                 displayInboxSettingsPreferenceManager.save(config.display.inboxSettings)
                 displayVisualSettingsPreferenceManager.save(config.display.visualSettings)
+                messageListPreferencesManager.save(config.display.visualSettings.messageListSettings)
                 displayMiscSettingsPreferenceManager.save(config.display.miscSettings)
                 networkSettingsPreferenceManager.save(config.network)
                 debuggingSettingsPreferenceManager.save(config.debugging)

legacy/core/src/main/java/com/fsck/k9/preferences/KoinModule.kt

@@ -153,6 +153,7 @@ val preferencesModule = module {
             displayCoreSettingsPreferenceManager = get(),
             displayInboxSettingsPreferenceManager = get(),
             displayVisualSettingsPreferenceManager = get(),
+            messageListPreferencesManager = get(),
             displayMiscSettingsPreferenceManager = get(),
             networkSettingsPreferenceManager = get(),
             debuggingSettingsPreferenceManager = get(),