Skip to content

Commit c058ca7

Browse files
committed
chore(notification): add todo comments with follow up tasks
1 parent 59f4c06 commit c058ca7

File tree

5 files changed

+6
-1
lines changed

5 files changed

+6
-1
lines changed

app-common/src/main/kotlin/net/thunderbird/app/common/notification/LegacyNotificationIdFactory.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import com.fsck.k9.notification.NotificationIds
44
import net.thunderbird.feature.notification.api.NotificationId
55
import net.thunderbird.feature.notification.api.NotificationIdFactory
66

7+
// TODO(#9416): Migrate logic from NotificationIds to NotificationIdFactory
78
class LegacyNotificationIdFactory : NotificationIdFactory {
89
override fun next(
910
accountNumber: Int,

feature/notification/api/src/commonMain/kotlin/net/thunderbird/feature/notification/api/NotificationGroup.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package net.thunderbird.feature.notification.api
33
import net.thunderbird.core.common.io.KmpParcelable
44
import net.thunderbird.core.common.io.KmpParcelize
55

6-
// TODO: Properly handle notification groups, adding summary, etc.
6+
// TODO(9419): Properly handle notification groups, adding summary, etc.
77
@KmpParcelize
88
data class NotificationGroup(
99
val key: NotificationGroupKey,
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package net.thunderbird.feature.notification.api
22

3+
// TODO(#9416): Migrate logic from NotificationIds to NotificationIdFactory
34
interface NotificationIdFactory {
45
fun next(accountNumber: Int, offset: Int = 0): NotificationId
56
}

feature/notification/impl/src/commonMain/kotlin/net/thunderbird/feature/notification/impl/command/InAppNotificationCommand.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,7 @@ internal class InAppNotificationCommand(
3131

3232
// TODO(#9392): Verify if the app is on foreground. IF it isn't, then should fail
3333
// executing the command
34+
// TODO(#9420): If the app is on background and the severity is Fatal or Critical, we should
35+
// let the command execute, but store it in a database instead of triggering the show notification logic.
3436
private fun canExecuteCommand(): Boolean = true
3537
}

legacy/core/src/main/java/com/fsck/k9/notification/NotificationIds.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package com.fsck.k9.notification
22

33
import net.thunderbird.core.android.account.LegacyAccount
44

5+
// TODO(#9416): Migrate logic from NotificationIds to NotificationIdFactory
56
object NotificationIds {
67
const val PUSH_NOTIFICATION_ID = 1
78
const val BACKGROUND_WORK_NOTIFICATION_ID = 2

0 commit comments

Comments
 (0)