refactor: remove mode from api

Author: wmontwe

core/file/src/androidMain/kotlin/net/thunderbird/core/file/AndroidFileSystemManager.kt

@@ -14,9 +14,10 @@ import kotlinx.io.asSource
 class AndroidFileSystemManager(
     private val contentResolver: ContentResolver,
 ) : FileSystemManager {
-    override fun openSink(uriString: String, mode: String): RawSink? {
+    override fun openSink(uriString: String): RawSink? {
         val uri: Uri = uriString.toUri()
-        return contentResolver.openOutputStream(uri, mode)?.asSink()
+        // Use truncate/overwrite mode by default
+        return contentResolver.openOutputStream(uri, "wt")?.asSink()
     }
 
     override fun openSource(uriString: String): RawSource? {

core/file/src/androidUnitTest/kotlin/net/thunderbird/core/file/AndroidFileSystemManagerTest.kt

@@ -33,7 +33,7 @@ class AndroidFileSystemManagerTest {
         val testText = "Hello Thunderbird Android!"
 
         // Act
-        val sink = checkNotNull(testSubject.openSink(uri.toString(), "wt"))
+        val sink = checkNotNull(testSubject.openSink(uri.toString()))
         val writeBuffer = Buffer().apply { write(testText.encodeToByteArray()) }
         sink.write(writeBuffer, writeBuffer.size)
         sink.flush()

core/file/src/commonMain/kotlin/net/thunderbird/core/file/FileSystemManager.kt

@@ -10,11 +10,12 @@ interface FileSystemManager {
     /**
      * Opens a sink for writing to a URI.
      *
+     * Implementations should open the destination for writing in overwrite/truncate mode.
+     *
      * @param uriString The URI string to open a sink for
-     * @param mode The mode to open the sink in (e.g., "wt" for write text)
      * @return A sink for writing to the URI, or null if the URI couldn't be opened
      */
-    fun openSink(uriString: String, mode: String): RawSink?
+    fun openSink(uriString: String): RawSink?
 
     /**
      * Opens a source for reading from a URI.

core/file/src/commonMain/kotlin/net/thunderbird/core/file/command/CopyCommand.kt

@@ -19,7 +19,7 @@ internal class CopyCommand(
             ?: return Outcome.Failure(
                 FileOperationError.Unavailable(sourceUri, "Unable to open source: $sourceUri"),
             )
-        val sink = fs.openSink(destinationUri.toString(), "wt")
+        val sink = fs.openSink(destinationUri.toString())
             ?: return Outcome.Failure(
                 FileOperationError.Unavailable(destinationUri, "Unable to open destination: $destinationUri"),
             )

core/file/src/commonTest/kotlin/net/thunderbird/core/file/FakeFileSystemManager.kt

@@ -12,7 +12,7 @@ class FakeFileSystemManager : FileSystemManager {
 
     private val storage = mutableMapOf<String, ByteArray>()
 
-    override fun openSink(uriString: String, mode: String): RawSink? {
+    override fun openSink(uriString: String): RawSink? {
         return object : RawSink {
             private val collected = mutableListOf<Byte>()
 

core/file/src/jvmMain/kotlin/net/thunderbird/core/file/JvmFileSystemManager.kt

@@ -12,13 +12,13 @@ import kotlinx.io.asSource
  * JVM implementation of [FileSystemManager] using java.io streams.
  */
 class JvmFileSystemManager : FileSystemManager {
-    override fun openSink(uriString: String, mode: String): RawSink? {
+    override fun openSink(uriString: String): RawSink? {
         // Only support simple file paths for JVM implementation
         return try {
             val file = File(uriString)
             // create parent directories if necessary
             file.parentFile?.mkdirs()
-            val append = mode.contains("a") // crude check for append mode
+            val append = false // overwrite/truncate by default
             FileOutputStream(file, append).asSink()
         } catch (_: Throwable) {
             null

core/file/src/jvmTest/kotlin/net/thunderbird/core/file/JvmFileSystemManagerTest.kt

@@ -21,7 +21,7 @@ class JvmFileSystemManagerTest {
         // Arrange
         val tempFile: File = folder.newFile("tb-file-fs-test.txt")
         val testText = "Hello Thunderbird!"
-        val sink = checkNotNull(testSubject.openSink(tempFile.absolutePath, "wt"))
+        val sink = checkNotNull(testSubject.openSink(tempFile.absolutePath))
 
         // Act
         val writeBuffer = Buffer().apply { write(testText.encodeToByteArray()) }