feat(notification): add SystemNotificationCommand implementation

Author: rafaeltonholo

feature/notification/api/src/commonMain/kotlin/net/thunderbird/feature/notification/api/command/NotificationCommandException.kt

@@ -0,0 +1,6 @@
+package net.thunderbird.feature.notification.api.command
+
+class NotificationCommandException @JvmOverloads constructor(
+    override val message: String?,
+    override val cause: Throwable? = null,
+) : Exception(message, cause)

feature/notification/impl/build.gradle.kts

@@ -1,11 +1,13 @@
 plugins {
     id(ThunderbirdPlugins.Library.kmpCompose)
+    alias(libs.plugins.dev.mokkery)
 }
 
 kotlin {
     sourceSets {
         commonMain.dependencies {
             implementation(projects.core.common)
+            implementation(projects.core.featureflag)
             implementation(projects.core.outcome)
             implementation(projects.core.logging.api)
             implementation(projects.feature.notification.api)

feature/notification/impl/src/commonMain/kotlin/net/thunderbird/feature/notification/impl/command/NotificationCommandFactory.kt

@@ -1,6 +1,8 @@
 package net.thunderbird.feature.notification.impl.command
 
+import net.thunderbird.core.featureflag.FeatureFlagProvider
 import net.thunderbird.core.logging.Logger
+import net.thunderbird.feature.notification.api.NotificationRegistry
 import net.thunderbird.feature.notification.api.command.NotificationCommand
 import net.thunderbird.feature.notification.api.content.InAppNotification
 import net.thunderbird.feature.notification.api.content.Notification
@@ -13,6 +15,8 @@ import net.thunderbird.feature.notification.impl.receiver.SystemNotificationNoti
  */
 internal class NotificationCommandFactory(
     private val logger: Logger,
+    private val featureFlagProvider: FeatureFlagProvider,
+    private val notificationRegistry: NotificationRegistry,
     private val systemNotificationNotifier: SystemNotificationNotifier,
     private val inAppNotificationNotifier: InAppNotificationNotifier,
 ) {
@@ -31,6 +35,8 @@ internal class NotificationCommandFactory(
             commands.add(
                 SystemNotificationCommand(
                     logger = logger,
+                    featureFlagProvider = featureFlagProvider,
+                    notificationRegistry = notificationRegistry,
                     notification = notification,
                     notifier = systemNotificationNotifier,
                 ),

feature/notification/impl/src/commonMain/kotlin/net/thunderbird/feature/notification/impl/command/SystemNotificationCommand.kt

@@ -1,11 +1,20 @@
 package net.thunderbird.feature.notification.impl.command
 
+import net.thunderbird.core.featureflag.FeatureFlagKey
+import net.thunderbird.core.featureflag.FeatureFlagProvider
+import net.thunderbird.core.featureflag.FeatureFlagResult
 import net.thunderbird.core.logging.Logger
 import net.thunderbird.core.outcome.Outcome
+import net.thunderbird.feature.notification.api.NotificationRegistry
+import net.thunderbird.feature.notification.api.NotificationSeverity
 import net.thunderbird.feature.notification.api.command.NotificationCommand
+import net.thunderbird.feature.notification.api.command.NotificationCommandException
+import net.thunderbird.feature.notification.api.content.InAppNotification
 import net.thunderbird.feature.notification.api.content.SystemNotification
 import net.thunderbird.feature.notification.api.receiver.NotificationNotifier
 
+private const val TAG = "SystemNotificationCommand"
+
 /**
  * Command for displaying system notifications.
  *
@@ -14,13 +23,64 @@ import net.thunderbird.feature.notification.api.receiver.NotificationNotifier
  */
 internal class SystemNotificationCommand(
     private val logger: Logger,
+    private val featureFlagProvider: FeatureFlagProvider,
+    private val notificationRegistry: NotificationRegistry,
     notification: SystemNotification,
     notifier: NotificationNotifier<SystemNotification>,
+    private val isAppInBackground: () -> Boolean = {
+        // TODO(#9391): Verify if the app is backgrounded.
+        false
+    },
 ) : NotificationCommand<SystemNotification>(notification, notifier) {
+
+    private val isFeatureFlagEnabled: Boolean
+        get() = featureFlagProvider
+            .provide(FeatureFlagKey.UseNotificationSenderForSystemNotifications) == FeatureFlagResult.Enabled
+
     override suspend fun execute(): Outcome<Success<SystemNotification>, Failure<SystemNotification>> {
-        logger.debug {
-            "TODO: Implementation on GitHub Issue #9245. Notification = $notification."
+        logger.debug(TAG) { "execute() called" }
+        return when {
+            isFeatureFlagEnabled.not() ->
+                Outcome.failure(
+                    error = Failure(
+                        command = this,
+                        throwable = NotificationCommandException(
+                            message = "${FeatureFlagKey.UseNotificationSenderForSystemNotifications.key} feature flag" +
+                                "is not enabled",
+                        ),
+                    ),
+                )
+
+            canExecuteCommand() -> {
+                notifier.show(
+                    id = notificationRegistry.register(notification),
+                    notification = notification,
+                )
+                Outcome.success(Success(command = this))
+            }
+
+            else -> {
+                Outcome.failure(
+                    error = Failure(
+                        command = this,
+                        throwable = NotificationCommandException("Can't execute command."),
+                    ),
+                )
+            }
+        }
+    }
+
+    private fun canExecuteCommand(): Boolean {
+        val shouldAlwaysShow = when (notification.severity) {
+            NotificationSeverity.Fatal, NotificationSeverity.Critical -> true
+            else -> false
+        }
+
+        return when {
+            shouldAlwaysShow -> true
+            isAppInBackground() -> true
+            notification !is InAppNotification -> true
+            else -> false
         }
-        return Outcome.success(data = Success(command = this))
     }
 }

feature/notification/impl/src/commonMain/kotlin/net/thunderbird/feature/notification/impl/inject/NotificationModule.kt

@@ -21,6 +21,8 @@ val featureNotificationModule = module {
     factory<NotificationCommandFactory> {
         NotificationCommandFactory(
             logger = get(),
+            notificationRegistry = get(),
+            featureFlagProvider = get(),
             systemNotificationNotifier = get(),
             inAppNotificationNotifier = get(),
         )

feature/notification/impl/src/commonTest/kotlin/net/thunderbird/feature/notification/impl/DefaultNotificationRegistryTest.kt

@@ -1,7 +1,5 @@
 package net.thunderbird.feature.notification.impl
 
-import androidx.compose.ui.graphics.vector.ImageVector
-import androidx.compose.ui.unit.dp
 import assertk.assertThat
 import assertk.assertions.containsAtLeast
 import assertk.assertions.hasSize
@@ -13,9 +11,7 @@ import kotlin.test.Test
 import kotlinx.coroutines.runBlocking
 import kotlinx.coroutines.test.runTest
 import net.thunderbird.feature.notification.api.NotificationId
-import net.thunderbird.feature.notification.api.NotificationSeverity
-import net.thunderbird.feature.notification.api.content.AppNotification
-import net.thunderbird.feature.notification.api.ui.icon.NotificationIcon
+import net.thunderbird.feature.notification.impl.fake.FakeNotification
 
 @Suppress("MaxLineLength")
 class DefaultNotificationRegistryTest {
@@ -176,18 +172,4 @@ class DefaultNotificationRegistryTest {
             // Assert
             assertThat(registry[notification]).isNull()
         }
-
-    data class FakeNotification(
-        override val title: String = "fake title",
-        override val contentText: String? = "fake content",
-        override val severity: NotificationSeverity = NotificationSeverity.Information,
-        override val icon: NotificationIcon = NotificationIcon(
-            inAppNotificationIcon = ImageVector.Builder(
-                defaultWidth = 0.dp,
-                defaultHeight = 0.dp,
-                viewportWidth = 0f,
-                viewportHeight = 0f,
-            ).build(),
-        ),
-    ) : AppNotification()
 }