fix(notifications): respect showContactPicture setting for notification avatars#10786
Open
mvanhorn wants to merge 1 commit intothunderbird:mainfrom
Open
fix(notifications): respect showContactPicture setting for notification avatars#10786mvanhorn wants to merge 1 commit intothunderbird:mainfrom
mvanhorn wants to merge 1 commit intothunderbird:mainfrom
Conversation
Check the message list showContactPicture preference before loading and displaying contact avatars in new mail notifications. When the setting is disabled, notifications no longer show the avatar as the large icon. Fixes thunderbird#10750
Contributor
|
Missing report label. Set exactly one of: |
rafaeltonholo
added
merge block: soft freeze
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When contact pictures are disabled in the message list settings, notification avatars are still shown. This checks the
isShowContactPicturepreference before loading contact avatars for new mail notifications.Why this matters
PR #9652 added avatar support to notifications but didn't check the existing contact picture visibility setting. Users who disable contact pictures in the message list expect notifications to also respect that preference.
Changes
SingleMessageNotificationCreator.kt: AddedMessageListPreferencesManageras a constructor dependency and an early return insetAvatar()whenisShowContactPictureis false (line 68)CoreNotificationKoinModule.kt: InjectedmessageListPreferencesManagerintoSingleMessageNotificationCreatorTesting
showContactPicturekey used by the message list UI (MessageViewHolder.kt:63)isShowContactPictureis false,setAvatar()returns without loading or setting the large iconisShowContactPictureis true (default), behavior is unchangedFixes #10750
This contribution was developed with AI assistance (Claude Code).