I also considered adding flake8 to the CI, but that's also a bit further down the road:

(.venv) thunderbird-website % flake8 --exclude=.venv [+]

<unknown>:348: SyntaxWarning: invalid escape sequence '\.'
<unknown>:350: SyntaxWarning: invalid escape sequence '\.'
./build-site.py:27:1: E302 expected 2 blank lines, found 1
./build-site.py:46:1: E305 expected 2 blank lines after class or function definition, found 1
./build-site.py:49:1: E302 expected 2 blank lines, found 1
./build-site.py:62:1: E305 expected 2 blank lines after class or function definition, found 1
./build-site.py:64:1: E302 expected 2 blank lines, found 1
./build-site.py:72:1: E302 expected 2 blank lines, found 1
./build-site.py:77:5: F841 local variable 'version' is assigned to but never used
./build-site.py:78:5: F841 local variable 'beta_version' is assigned to but never used
./build-site.py:91:1: E302 expected 2 blank lines, found 1
./build-site.py:100:1: E302 expected 2 blank lines, found 1
./build-site.py:106:1: E302 expected 2 blank lines, found 1
./build-site.py:120:1: E302 expected 2 blank lines, found 1
./build-site.py:158:1: E305 expected 2 blank lines after class or function definition, found 1
./build_calendar.py:82:151: E501 line too long (213 > 150 characters)
./builder.py:142:151: E501 line too long (166 > 150 characters)
./builder.py:348:31: W605 invalid escape sequence '\.'
./builder.py:350:31: W605 invalid escape sequence '\.'
./builder.py:543:5: E303 too many blank lines (2)
./builder.py:635:17: E741 ambiguous variable name 'l'
./calgen/mixins/GlobalHolidays.py:1:1: F401 'datetime' imported but unused
./calgen/mixins/GlobalHolidays.py:3:1: F401 'calgen.models.Calendar.Calendar' imported but unused
./calgen/mixins/GlobalHolidays.py:3:1: F401 'calgen.models.Calendar.CalendarTypes' imported but unused
./calgen/mixins/GlobalHolidays.py:13:5: E265 block comment should start with '# '
./calgen/mixins/GlobalHolidays.py:14:5: E266 too many leading '#' for block comment
./calgen/mixins/GlobalHolidays.py:15:5: E266 too many leading '#' for block comment
./calgen/mixins/GlobalHolidays.py:16:5: E266 too many leading '#' for block comment
./calgen/mixins/GlobalHolidays.py:17:5: E266 too many leading '#' for block comment
./calgen/mixins/GlobalHolidays.py:18:5: E266 too many leading '#' for block comment
./calgen/mixins/GlobalHolidays.py:19:5: E266 too many leading '#' for block comment
./calgen/mixins/GlobalHolidays.py:20:5: E265 block comment should start with '# '
./calgen/mixins/GlobalHolidays.py:22:2: W292 no newline at end of file
./calgen/providers/Provider.py:9:151: E501 line too long (163 > 150 characters)
./docs/conf.py:36:1: E265 block comment should start with '# '
./helper.py:6:1: F401 'collections.OrderedDict' imported but unused
./helper.py:201:151: E501 line too long (155 > 150 characters)
./helper.py:206:151: E501 line too long (201 > 150 characters)
./helper.py:495:151: E501 line too long (219 > 150 characters)
./helper.py:633:151: E501 line too long (159 > 150 characters)
./l10n_tools/msginit.py:9:5: F824 `global failures` is unused: name is never assigned in scope
./libs/thunderbird_notes/parse.py:27:28: F821 undefined name 'unicode'
./libs/thunderbird_notes/preview.py:147:1: E302 expected 2 blank lines, found 1
./libs/thunderbird_notes/preview.py:150:1: E302 expected 2 blank lines, found 1
./libs/thunderbird_notes/preview.py:153:1: E302 expected 2 blank lines, found 1
./libs/thunderbird_notes/preview.py:216:1: E303 too many blank lines (4)
./libs/thunderbird_notes/tools/android_notes_length.py:5:1: F401 'requests' imported but unused
./libs/thunderbird_notes/tools/android_notes_length.py:10:1: F401 'jinja2.Template' imported but unused
./libs/thunderbird_notes/tools/android_notes_length.py:35:5: F841 local variable 'total_len' is assigned to but never used
./libs/thunderbird_notes/tools/mk_release_notes.py:7:1: F401 're' imported but unused
./product_details.py:276:62: E221 multiple spaces before operator
./settings.py:175:151: E501 line too long (220 > 150 characters)
./settings.py:176:151: E501 line too long (230 > 150 characters)
./tests/test_helpers.py:1:1: F401 'pytest' imported but unused
./tests/test_product_details.py:2:1: F401 'pytest' imported but unused
./tests/test_product_details.py:49:68: W292 no newline at end of file
./tests/test_wsgi.py:41:27: E261 at least two spaces before inline comment
./tests/test_wsgi.py:42:27: E261 at least two spaces before inline comment
./tools/crop_staff_list.py:78:151: E501 line too long (151 > 150 characters)
./tools/form-bridge/lambda_function.py:6:1: F401 'botocore.exceptions.ClientError' imported but unused
./tools/form-bridge/lambda_function.py:26:34: E261 at least two spaces before inline comment
./tools/form-bridge/lambda_function.py:27:40: E261 at least two spaces before inline comment
./tools/form-bridge/lambda_function.py:28:40: E261 at least two spaces before inline comment
./tools/form-bridge/lambda_function.py:56:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_function.py:85:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_function.py:123:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:7:1: F401 'pytest' imported but unused
./tools/form-bridge/lambda_test.py:13:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:29:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:56:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:84:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:113:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:165:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:169:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:173:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:191:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:220:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:234:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:247:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:260:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:264:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:268:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:272:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:284:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:297:1: E302 expected 2 blank lines, found 1
./tools/form-bridge/lambda_test.py:313:1: E302 expected 2 blank lines, found 1
./wsgi.py:80:9: E129 visually indented line with same indent as next logical line

1     E129 visually indented line with same indent as next logical line
1     E221 multiple spaces before operator
5     E261 at least two spaces before inline comment
3     E265 block comment should start with '# '
6     E266 too many leading '#' for block comment
33    E302 expected 2 blank lines, found 1
2     E303 too many blank lines (2)
3     E305 expected 2 blank lines after class or function definition, found 1
10    E501 line too long (213 > 150 characters)
1     E741 ambiguous variable name 'l'
11    F401 'datetime' imported but unused
1     F821 undefined name 'unicode'
1     F824 `global failures` is unused: name is never assigned in scope
3     F841 local variable 'version' is assigned to but never used
2     W292 no newline at end of file
2     W605 invalid escape sequence '\.'

Run pytest per PR via github actions #863

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions