feat: implement shared detector framework and evidence schema (issue #18)

* feat(rust): add shared client detector framework and evidence schema (issue #18)

* test(docs): align frontend contracts and boundary docs with detector schema (issue #18)

Author: thundermiracle

README.md

@@ -32,6 +32,7 @@ Tauri 2 + React/TypeScript desktop foundation for managing MCP and Skills across
 - `src/backend/`: Typed frontend contracts and Tauri invoke client.
 - `src-tauri/`: Rust backend and Tauri application shell.
 - `src-tauri/src/domain/`: Domain layer (adapter interfaces, client profiles, capabilities).
+- `src-tauri/src/detection/`: Shared detector framework and per-client detectors.
 - `src-tauri/src/adapters/`: Client-specific adapter implementations.
 - `src-tauri/src/infra/`: Infrastructure composition (adapter registry).
 - `src-tauri/src/application/`: Use-case service layer consumed by commands.

docs/architecture/module-boundaries.md

@@ -7,17 +7,22 @@ This project uses explicit backend layers to keep client-specific behavior isola
 - `domain/`
   - Owns adapter interface (`ClientAdapter`) and client profile/capability definitions.
   - Contains types that describe adapter behavior without binding to concrete client implementations.
+- `detection/`
+  - Owns detector interface (`ClientDetector`) and shared detection framework.
+  - Defines detector registry and per-client detector implementations that emit one schema.
 - `adapters/`
   - Contains concrete adapter implementations for each supported client.
   - Current scaffold adapters: Claude Code, Codex CLI, Cursor, Codex App.
 - `infra/`
   - Provides infrastructure wiring (`AdapterRegistry`) that composes adapters.
   - Exposes registry lookup/iteration used by application services.
 - `application/`
-  - Coordinates use-cases (`AdapterService`) and maps adapter outputs to command contracts.
+  - Coordinates use-cases (`AdapterService`) and maps detector/adapter outputs to command contracts.
 - `commands/`
   - Thin Tauri command boundary; handles envelope metadata and delegates business flow.
 
 ## Extension Rule
 
-To add a new client adapter, implement `ClientAdapter` in a new file under `adapters/` and register it in `infra/adapter_registry.rs`. Command and UI layers should remain unchanged.
+To add a new client adapter, implement `ClientAdapter` in a new file under `adapters/` and register it in `infra/adapter_registry.rs`.
+To add a new detector, implement `ClientDetector` in `detection/clients/` and register it in `detection/detector_registry.rs`.
+Command and UI layers should remain unchanged.

src-tauri/src/adapters/claude_code.rs

@@ -1,11 +1,11 @@
 use crate::{
-    contracts::{common::ResourceKind, detect::ClientDetection, mutate::MutationAction},
+    contracts::{common::ResourceKind, mutate::MutationAction},
     domain::{
         AdapterListResult, AdapterMutationResult, CLAUDE_CODE_PROFILE, ClientAdapter, ClientProfile,
     },
 };
 
-use super::placeholder::{detect_placeholder, list_placeholder, mutate_placeholder};
+use super::placeholder::{list_placeholder, mutate_placeholder};
 
 pub struct ClaudeCodeAdapter;
 
@@ -20,10 +20,6 @@ impl ClientAdapter for ClaudeCodeAdapter {
         &CLAUDE_CODE_PROFILE
     }
 
-    fn detect(&self, include_versions: bool) -> ClientDetection {
-        detect_placeholder(self.profile(), include_versions)
-    }
-
     fn list_resources(&self, resource_kind: ResourceKind) -> AdapterListResult {
         list_placeholder(self.profile(), resource_kind)
     }

src-tauri/src/adapters/codex_app.rs

@@ -1,11 +1,11 @@
 use crate::{
-    contracts::{common::ResourceKind, detect::ClientDetection, mutate::MutationAction},
+    contracts::{common::ResourceKind, mutate::MutationAction},
     domain::{
         AdapterListResult, AdapterMutationResult, CODEX_APP_PROFILE, ClientAdapter, ClientProfile,
     },
 };
 
-use super::placeholder::{detect_placeholder, list_placeholder, mutate_placeholder};
+use super::placeholder::{list_placeholder, mutate_placeholder};
 
 pub struct CodexAppAdapter;
 
@@ -20,10 +20,6 @@ impl ClientAdapter for CodexAppAdapter {
         &CODEX_APP_PROFILE
     }
 
-    fn detect(&self, include_versions: bool) -> ClientDetection {
-        detect_placeholder(self.profile(), include_versions)
-    }
-
     fn list_resources(&self, resource_kind: ResourceKind) -> AdapterListResult {
         list_placeholder(self.profile(), resource_kind)
     }

src-tauri/src/adapters/codex_cli.rs

@@ -1,11 +1,11 @@
 use crate::{
-    contracts::{common::ResourceKind, detect::ClientDetection, mutate::MutationAction},
+    contracts::{common::ResourceKind, mutate::MutationAction},
     domain::{
         AdapterListResult, AdapterMutationResult, CODEX_CLI_PROFILE, ClientAdapter, ClientProfile,
     },
 };
 
-use super::placeholder::{detect_placeholder, list_placeholder, mutate_placeholder};
+use super::placeholder::{list_placeholder, mutate_placeholder};
 
 pub struct CodexCliAdapter;
 
@@ -20,10 +20,6 @@ impl ClientAdapter for CodexCliAdapter {
         &CODEX_CLI_PROFILE
     }
 
-    fn detect(&self, include_versions: bool) -> ClientDetection {
-        detect_placeholder(self.profile(), include_versions)
-    }
-
     fn list_resources(&self, resource_kind: ResourceKind) -> AdapterListResult {
         list_placeholder(self.profile(), resource_kind)
     }

src-tauri/src/adapters/cursor.rs

@@ -1,11 +1,11 @@
 use crate::{
-    contracts::{common::ResourceKind, detect::ClientDetection, mutate::MutationAction},
+    contracts::{common::ResourceKind, mutate::MutationAction},
     domain::{
         AdapterListResult, AdapterMutationResult, CURSOR_PROFILE, ClientAdapter, ClientProfile,
     },
 };
 
-use super::placeholder::{detect_placeholder, list_placeholder, mutate_placeholder};
+use super::placeholder::{list_placeholder, mutate_placeholder};
 
 pub struct CursorAdapter;
 
@@ -20,10 +20,6 @@ impl ClientAdapter for CursorAdapter {
         &CURSOR_PROFILE
     }
 
-    fn detect(&self, include_versions: bool) -> ClientDetection {
-        detect_placeholder(self.profile(), include_versions)
-    }
-
     fn list_resources(&self, resource_kind: ResourceKind) -> AdapterListResult {
         list_placeholder(self.profile(), resource_kind)
     }

src-tauri/src/adapters/placeholder.rs

@@ -1,31 +1,8 @@
 use crate::{
-    contracts::{
-        common::ResourceKind,
-        detect::{ClientDetection, DetectionEvidence, DetectionStatus},
-        mutate::MutationAction,
-    },
+    contracts::{common::ResourceKind, mutate::MutationAction},
     domain::{AdapterListResult, AdapterMutationResult, ClientProfile},
 };
 
-pub fn detect_placeholder(
-    profile: &'static ClientProfile,
-    include_versions: bool,
-) -> ClientDetection {
-    ClientDetection {
-        client: profile.kind,
-        status: DetectionStatus::Absent,
-        evidence: DetectionEvidence {
-            binary_path: None,
-            config_path: None,
-            version: include_versions.then_some("not_collected".to_string()),
-        },
-        note: format!(
-            "{} adapter scaffold is ready. Detection implementation will be added in issue #19/#20.",
-            profile.display_name
-        ),
-    }
-}
-
 pub fn list_placeholder(
     profile: &'static ClientProfile,
     resource_kind: ResourceKind,

src-tauri/src/application/adapter_service.rs

@@ -5,23 +5,31 @@ use crate::{
         list::{ListResourcesRequest, ListResourcesResponse},
         mutate::{MutateResourceRequest, MutateResourceResponse},
     },
+    detection::DetectorRegistry,
     infra::AdapterRegistry,
 };
 
 pub struct AdapterService<'a> {
-    registry: &'a AdapterRegistry,
+    adapter_registry: &'a AdapterRegistry,
+    detector_registry: &'a DetectorRegistry,
 }
 
 impl<'a> AdapterService<'a> {
-    pub fn new(registry: &'a AdapterRegistry) -> Self {
-        Self { registry }
+    pub fn new(
+        adapter_registry: &'a AdapterRegistry,
+        detector_registry: &'a DetectorRegistry,
+    ) -> Self {
+        Self {
+            adapter_registry,
+            detector_registry,
+        }
     }
 
     pub fn detect_clients(&self, request: DetectClientsRequest) -> DetectClientsResponse {
         let clients = self
-            .registry
+            .detector_registry
             .all()
-            .map(|adapter| adapter.detect(request.include_versions))
+            .map(|detector| detector.detect(&request))
             .collect();
 
         DetectClientsResponse { clients }
@@ -31,7 +39,7 @@ impl<'a> AdapterService<'a> {
         &self,
         request: ListResourcesRequest,
     ) -> Result<ListResourcesResponse, CommandError> {
-        let Some(adapter) = self.registry.find(request.client) else {
+        let Some(adapter) = self.adapter_registry.find(request.client) else {
             return Err(CommandError::internal(format!(
                 "No adapter registered for '{}'.",
                 request.client.as_str()
@@ -60,7 +68,7 @@ impl<'a> AdapterService<'a> {
             ));
         }
 
-        let Some(adapter) = self.registry.find(request.client) else {
+        let Some(adapter) = self.adapter_registry.find(request.client) else {
             return Err(CommandError::internal(format!(
                 "No adapter registered for '{}'.",
                 request.client.as_str()
@@ -84,35 +92,42 @@ mod tests {
     use crate::{
         contracts::{
             common::{ClientKind, ResourceKind},
-            detect::DetectClientsRequest,
+            detect::{DetectClientsRequest, DetectionStatus},
             list::ListResourcesRequest,
             mutate::{MutateResourceRequest, MutationAction},
         },
+        detection::DetectorRegistry,
         infra::AdapterRegistry,
     };
 
     #[test]
-    fn detect_clients_uses_every_registered_adapter() {
-        let registry = AdapterRegistry::with_default_adapters();
-        let service = AdapterService::new(&registry);
+    fn detect_clients_uses_every_registered_detector() {
+        let adapter_registry = AdapterRegistry::with_default_adapters();
+        let detector_registry = DetectorRegistry::with_default_detectors();
+        let service = AdapterService::new(&adapter_registry, &detector_registry);
 
         let response = service.detect_clients(DetectClientsRequest {
             include_versions: true,
         });
 
         assert_eq!(response.clients.len(), 4);
-        assert!(
-            response
-                .clients
-                .iter()
-                .all(|entry| entry.evidence.version.is_some())
-        );
+        assert!(response.clients.iter().all(|entry| entry.confidence <= 100));
+        assert!(response.clients.iter().all(|entry| {
+            matches!(
+                entry.status,
+                DetectionStatus::Detected
+                    | DetectionStatus::Partial
+                    | DetectionStatus::Absent
+                    | DetectionStatus::Error
+            )
+        }));
     }
 
     #[test]
     fn list_resources_routes_by_requested_client() {
-        let registry = AdapterRegistry::with_default_adapters();
-        let service = AdapterService::new(&registry);
+        let adapter_registry = AdapterRegistry::with_default_adapters();
+        let detector_registry = DetectorRegistry::with_default_detectors();
+        let service = AdapterService::new(&adapter_registry, &detector_registry);
 
         let response = service
             .list_resources(ListResourcesRequest {
@@ -133,8 +148,9 @@ mod tests {
 
     #[test]
     fn mutate_resource_validates_target_id_before_adapter_call() {
-        let registry = AdapterRegistry::with_default_adapters();
-        let service = AdapterService::new(&registry);
+        let adapter_registry = AdapterRegistry::with_default_adapters();
+        let detector_registry = DetectorRegistry::with_default_detectors();
+        let service = AdapterService::new(&adapter_registry, &detector_registry);
 
         let error = service
             .mutate_resource(&MutateResourceRequest {

src-tauri/src/commands/detect.rs

@@ -23,7 +23,7 @@ pub fn detect_clients(
         return CommandEnvelope::failure(CommandError::shutting_down(), meta);
     }
 
-    let service = AdapterService::new(state.adapter_registry());
+    let service = AdapterService::new(state.adapter_registry(), state.detector_registry());
 
     CommandEnvelope::success(service.detect_clients(request), meta)
 }

src-tauri/src/commands/list.rs

@@ -20,7 +20,7 @@ pub fn list_resources(
         return CommandEnvelope::failure(CommandError::shutting_down(), meta);
     }
 
-    let service = AdapterService::new(state.adapter_registry());
+    let service = AdapterService::new(state.adapter_registry(), state.detector_registry());
 
     match service.list_resources(request) {
         Ok(response) => CommandEnvelope::success(response, meta),