|
1 | 1 | from django.db import migrations |
2 | 2 |
|
3 | | -from thunderstore.community.consts import PackageListingReviewStatus |
| 3 | +""" |
| 4 | +This migration used to have logic for creating/updating default VisibilityFlags |
| 5 | +for Package/PackageVersion/PackageListing models, but as the system is currently |
| 6 | +not in active use and we have no logic ensuring the state is maintained |
| 7 | +correctly, the data migration was removed as it was considered unnecessary but |
| 8 | +would have made deployment take longer. |
4 | 9 |
|
5 | | - |
6 | | -def create_default_visibility_for_existing_records(apps, schema_editor): |
7 | | - PackageListing = apps.get_model("community", "PackageListing") |
8 | | - VisibilityFlags = apps.get_model("permissions", "VisibilityFlags") |
9 | | - |
10 | | - for instance in PackageListing.objects.filter(visibility__isnull=True): |
11 | | - visibility_flags = VisibilityFlags.objects.create( |
12 | | - public_list=False, |
13 | | - public_detail=False, |
14 | | - owner_list=True, |
15 | | - owner_detail=True, |
16 | | - moderator_list=True, |
17 | | - moderator_detail=True, |
18 | | - admin_list=True, |
19 | | - admin_detail=True, |
20 | | - ) |
21 | | - instance.visibility = visibility_flags |
22 | | - instance.save() |
23 | | - update_visibility(instance) |
24 | | - |
25 | | - |
26 | | -def update_visibility(listing): |
27 | | - package = listing.package |
28 | | - listing.visibility.public_detail = package.visibility.public_detail |
29 | | - listing.visibility.public_list = package.visibility.public_list |
30 | | - listing.visibility.owner_detail = package.visibility.owner_detail |
31 | | - listing.visibility.owner_list = package.visibility.owner_list |
32 | | - listing.visibility.moderator_detail = package.visibility.moderator_detail |
33 | | - listing.visibility.moderator_list = package.visibility.moderator_list |
34 | | - listing.visibility.admin_detail = package.visibility.admin_detail |
35 | | - listing.visibility.admin_list = package.visibility.admin_list |
36 | | - |
37 | | - if listing.review_status == PackageListingReviewStatus.rejected: |
38 | | - listing.visibility.public_detail = False |
39 | | - listing.visibility.public_list = False |
40 | | - |
41 | | - if ( |
42 | | - listing.community.require_package_listing_approval |
43 | | - and listing.review_status == PackageListingReviewStatus.unreviewed |
44 | | - ): |
45 | | - listing.visibility.public_detail = False |
46 | | - listing.visibility.public_list = False |
47 | | - |
48 | | - listing.visibility.save() |
| 10 | +Instead, this stub was left around as to not brick migration history for |
| 11 | +environments that might have already run the migration. |
| 12 | +""" |
49 | 13 |
|
50 | 14 |
|
51 | 15 | class Migration(migrations.Migration): |
52 | 16 |
|
53 | 17 | dependencies = [ |
54 | 18 | ("community", "0036_packagelisting_visibility"), |
55 | | - ("repository", "0059_package_visibility"), |
56 | | - ("repository", "0060_create_default_visibility_for_existing_records"), |
57 | 19 | ] |
58 | 20 |
|
59 | 21 | operations = [ |
60 | | - migrations.RunPython( |
61 | | - create_default_visibility_for_existing_records, migrations.RunPython.noop |
62 | | - ), |
| 22 | + migrations.RunPython(migrations.RunPython.noop, migrations.RunPython.noop), |
63 | 23 | ] |
0 commit comments