Merge pull request #1216 from thunderstore-io/cyberstorm-blank-donation-url

Cyberstorm API: allow saving team "profile" with empty donation link

Author: anttimaki

django/thunderstore/api/cyberstorm/serializers/team.py

@@ -59,7 +59,7 @@ class CyberstormCreateTeamSerializer(serializers.Serializer):
 
 class CyberstormTeamUpdateSerializer(serializers.Serializer):
     donation_link = serializers.CharField(
-        max_length=1024, validators=[URLValidator(["https"])]
+        allow_null=True, max_length=1024, validators=[URLValidator(schemes=["https"])]
     )
 
 

django/thunderstore/api/cyberstorm/tests/test_team.py

@@ -349,6 +349,28 @@ def test_team_update_succeeds(
     assert Team.objects.get(pk=team.pk).donation_link == new_donation_link
 
 
+@pytest.mark.django_db
+def test_team_update_succeeds_unset_donation_link(
+    api_client: APIClient,
+    user: UserType,
+    team: Team,
+):
+    TeamMemberFactory(team=team, user=user, role="owner")
+    team.donation_link = "https://example.com"
+    team.save()
+    api_client.force_authenticate(user)
+
+    response = api_client.patch(
+        f"/api/cyberstorm/team/{team.name}/update/",
+        json.dumps({"donation_link": None}),
+        content_type="application/json",
+    )
+
+    assert response.status_code == 200
+    assert response.json() == {"donation_link": None}
+    assert Team.objects.get(pk=team.pk).donation_link is None
+
+
 @pytest.mark.django_db
 def test_team_update_fails_user_not_authenticated(
     api_client: APIClient,