Merge pull request #1171 from thunderstore-io/fix-forms-silent-fail-error

Fix donation link form silent error

Author: MythicManiac

django/thunderstore/repository/forms/team.py

@@ -199,5 +199,6 @@ def save(self, **kwargs):
             )
         except ValidationError as e:
             self.add_error(None, e)
+            raise ValidationError(self.errors)
 
         return self.instance

django/thunderstore/repository/tests/test_team_forms.py

@@ -553,7 +553,8 @@ def test_form_donation_link_team_form_permissions(
         team.refresh_from_db()
         assert team.donation_link == link
     else:
-        form.save()
+        with pytest.raises(ValidationError):
+            form.save()
         assert form.is_valid() is False
         assert form.errors
         team.refresh_from_db()

django/thunderstore/repository/views/team_settings.py

@@ -276,8 +276,10 @@ def get_success_url(self):
         return self.object.donation_link_url
 
     def form_valid(self, form: DonationLinkTeamForm):
-        self.object = form.save()
-        if form.errors:  # Check if service layer raised an error
+        try:
+            self.object = form.save()
+        except ValidationError:
             return super().form_invalid(form)
+
         messages.success(self.request, "Donation link saved")
-        return redirect(self.get_success_url())
+        return super().form_valid(form)