Feature request: (nice to have) output should extend ImageData

[yjutard-while-at-atlassian]

Hi, thanks for this lib that looks great! (I'm still evaluating)

I'm trying to pass the output to another lib, which requires an ImageData input:

class ImageData {
  data, // Uint8ClampedArray one-dimensional array containing the data in the RGBA order, with integer values between 0 and 255 (inclusive). The order goes by rows from the top-left pixel to the bottom-right.
  colorSpace, // string indicating the color space of the image data.
  height,
  width,
}

Looking at the output of resvg-js, it looks extremely similar:

export class RenderedImage {
  /** Write the image data to Buffer */
  asPng(): Buffer
  /** Get the RGBA pixels of the image */
  get pixels(): Buffer
  /** Get the PNG width */
  get width(): number
  /** Get the PNG height */
  get height(): number
}

My suggestion is to switch the output of resvg-js to the standard API ImageData or provide a conversion function, ex. toImageData()

[yisibl]

I haven't used ImageData, so resvg-js is mostly missing ImageData.colorSpace and the Uint8ClampedArray needed for ImageData.data?

See also: #123

[yisibl]

Note: This structure is available in the node-related canvas library.
https://github.com/Brooooooklyn/canvas/blob/a6b5cc4a45e2b58d7576ee413eff156f394511ff/index.d.ts#L169-L186

[yisibl]

resvg currently always uses the sRGB color space. See: linebender/resvg#629

[yisibl]

Please see that having #304 is the solution to your needs?

[yisibl]

ping @yjutard

[yjutard-while-at-atlassian]

Thanks @yisibl
I was able to convert resvg's output to ImageData without effort:

const renderedImage = resvg.render();
const imageData = { // https://developer.mozilla.org/en-US/docs/Web/API/ImageData
    width: renderedImage.width,
    height: renderedImage.height,
    colorSpace: 'srgb', // let's try...
    data: renderedImage.pixels,
};
let { top, right, bottom, left } = getTrimEdges(imageData); // it works! (npm lib trim-image-data)

So it seems the current "pixels" format is OK ✅

My comment was about the data shape. Instead of inventing a new one, suggestion to use a "standard" one.

All good, not critical since the conversion is trivial. This issue can serve as doc. Feel free to close it!