refactor: Refactored ForEachActionExecutor.cs

Author: thygesteffensen

PowerAutomateMockUp/FlowParser/ActionExecutors/Implementations/ForEachActionExecutor.cs

@@ -15,6 +15,9 @@ public class ForEachActionExecutor : DefaultBaseActionExecutor, IScopeActionExec
         private readonly ILogger<ForEachActionExecutor> _logger;
         private readonly IExpressionEngine _expressionEngine;
 
+        private JProperty[] _actionDescriptions;
+        private string _firstScopeActionName;
+
         private List<ValueContainer> _items;
 
         public ForEachActionExecutor(
@@ -35,7 +38,13 @@ public override Task<ActionResult> Execute()
         {
             _logger.LogInformation("Entered foreach...");
 
-            var runOn = Json.SelectToken("$..foreach").Value<string>();
+            if (Json == null)
+            {
+                throw new PowerAutomateMockUpException($"Json cannot be null - cannot execute {ActionName}.");
+            }
+
+            var runOn = (Json.SelectToken("$..foreach") ??
+                         throw new InvalidOperationException("Json must contain foreach token.")).Value<string>();
             var values = _expressionEngine.ParseToValueContainer(runOn);
 
             if (values.Type() != ValueContainer.ValueType.Array)
@@ -44,42 +53,46 @@ public override Task<ActionResult> Execute()
                     // TODO: Figure out what happens when you apply for each on non array values
                     ActionStatus = ActionStatus.Failed
                 });
-            
-            var valueList = values.GetValue<IEnumerable<ValueContainer>>().ToArray();
-                
-            var firstScopeAction = SetupScope();
 
-            // TODO: Add scope relevant storage to store stuff like this, which cannot interfere with the state.
-            _state.AddOutputs($"item_{ActionName}", valueList.First());
-            _items = valueList.Skip(1).ToList();
+            SetupForEach(values);
+
+            UpdateScopeAndSetItemValue();
 
-            return Task.FromResult(new ActionResult {NextAction = firstScopeAction.Name});
+            return Task.FromResult(new ActionResult {NextAction = _firstScopeActionName});
         }
 
-        private JProperty SetupScope()
+        private void SetupForEach(ValueContainer values)
         {
-            var scopeActionDescriptions = Json.SelectToken("$.actions").OfType<JProperty>();
-            var actionDescriptions = scopeActionDescriptions as JProperty[] ?? scopeActionDescriptions.ToArray();
+            var scopeActionDescriptions = (Json.SelectToken("$.actions") ??
+                                           throw new InvalidOperationException("Json must contain actions token."))
+                .OfType<JProperty>();
+            _actionDescriptions = scopeActionDescriptions as JProperty[] ?? scopeActionDescriptions.ToArray();
+            _firstScopeActionName = _actionDescriptions.First(ad =>
+                !(ad.Value.SelectToken("$.runAfter") ??
+                  throw new InvalidOperationException("Json must contain runAfter token.")).Any()).Name;
 
-            _scopeDepthManager.Push(ActionName, actionDescriptions, this);
+            // TODO: Add scope relevant storage to store stuff like this, which cannot interfere with the state.
+            _items = values.GetValue<IEnumerable<ValueContainer>>().ToList();
+        }
+
+        private void UpdateScopeAndSetItemValue()
+        {
+            _scopeDepthManager.Push(ActionName, _actionDescriptions, this);
 
-            var firstScopeAction = actionDescriptions.First(ad => !ad.Value.SelectToken("$.runAfter").Any());
-            return firstScopeAction;
+            _state.AddOutputs($"item_{ActionName}", _items.First());
+            _items = _items.Skip(1).ToList();
         }
 
+
         public Task<ActionResult> ExitScope(ActionStatus scopeStatus)
         {
             if (_items.Count > 0)
             {
                 _logger.LogInformation("Continuing foreach.");
 
-                _state.AddOutputs($"item_{ActionName}", _items.First());
-
-                _items = _items.Skip(1).ToList();
-                
-                var firstScopeAction = SetupScope();
+                UpdateScopeAndSetItemValue();
 
-                return Task.FromResult(new ActionResult {NextAction = firstScopeAction.Name});
+                return Task.FromResult(new ActionResult {NextAction = _firstScopeActionName});
             }
             else
             {