Skip to content

Commit 0d17c95

Browse files
author
thyttan
committed
Merge branch 'messagegui' into app-loader
2 parents 84252a1 + e083508 commit 0d17c95

File tree

4 files changed

+167
-52
lines changed

4 files changed

+167
-52
lines changed

apps/messagegui/ChangeLog

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,3 +113,4 @@
113113
0.82: Stop buzzing when a message is removed (e.g. call answered)
114114
0.83: Add option to not open the first unread message
115115
0.84: Fix: Assign show message entry to the settings menu and not the message itself.
116+
0.85: (WIP) refactor to display a scroller with three messages loaded. When scrolling to the top or end new/older messages are loaded in.

apps/messagegui/app.js

Lines changed: 164 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ var onMessagesModified = function(type,msg) {
8181
require("messages").apply(msg, MESSAGES);
8282
// TODO: if new, show this new one
8383
if (msg && msg.id!=="music" && msg.id!=="nav" && msg.new &&
84-
!((require('Storage').readJSON('setting.json', 1) || {}).quiet)) {
84+
!((require('Storage').readJSON('setting.json', 1) || {}).quiet)) {
8585
require("messages").buzz(msg.src);
8686
}
8787
if (msg && msg.id=="music") {
@@ -90,7 +90,8 @@ var onMessagesModified = function(type,msg) {
9090
}
9191
if (msg && msg.id=="nav" && msg.t=="modify" && active!="map")
9292
return; // don't show an updated nav message if we're just in the menu
93-
showMessage(msg&&msg.id, false);
93+
//showMessage(msg&&msg.id, false);
94+
showMessagesScroller(msg, false)
9495
};
9596
Bangle.on("message", onMessagesModified);
9697

@@ -105,35 +106,35 @@ function showMapMessage(msg) {
105106
var m, distance, street, target, img;
106107
if ("string"==typeof msg.distance) // new gadgetbridge
107108
distance = msg.distance;
108-
else if ("number"==typeof msg.distance) // 0.74 gadgetbridge
109-
distance = require("locale").distance(msg.distance);
109+
else if ("number"==typeof msg.distance) // 0.74 gadgetbridge
110+
distance = require("locale").distance(msg.distance);
110111
if (msg.instr) {
111112
var instr = msg.instr.replace(/\s*\/\s*/g," \/\n"); // convert slashes to newlines
112113
if (instr.includes("towards") || instr.includes("toward")) {
113114
m = instr.split(/towards|toward/);
114115
target = m[0].trim();
115116
street = m[1].trim();
116117
}else
117-
target = instr;
118+
target = instr;
118119
}
119120
var carIsRHD = !!settings.carIsRHD;
120121
switch (msg.action) {
121-
case "continue": img = "EBgBAIABwAPgD/Af+D/8f/773/PPY8cDwAPAA8ADwAPAA8AAAAPAA8ADwAAAA8ADwAPA";break;
122-
case "left": img = "GhcBAYAAAPAAAHwAAD4AAB8AAA+AAAf//8P///x///+PAAPx4AA8fAAHD4ABwfAAcDwAHAIABwAAAcAAAHAAABwAAAcAAAHAAABwAAAc";break;
123-
case "right": img = "GhcBAABgAAA8AAAPgAAB8AAAPgAAB8D///j///9///+/AAPPAAHjgAD44AB8OAA+DgAPA4ABAOAAADgAAA4AAAOAAADgAAA4AAAOAAAA";break;
124-
case "left_slight": img = "ERgB//B/+D/8H4AP4Af4A74Bz4Dj4HD4OD4cD4AD4ADwADwADgAHgAPAAOAAcAA4ABwADgAH";break;
125-
case "right_slight": img = "ERgBB/+D/8H/4APwA/gD/APuA+cD44Phw+Dj4HPgAeAB4ADgAPAAeAA4ABwADgAHAAOAAcAA";break;
126-
case "left_sharp": img = "GBaBAAAA+AAB/AAH/gAPjgAeBwA8BwB4B+DwB+HgB+PAB+eAB+8AB+4AB/wAB/gAB//gB//gB//gBwAABwAABwAABwAABw=="; break;
127-
case "right_sharp": img = "GBaBAB8AAD+AAH/gAHHwAOB4AOA8AOAeAOAPB+AHh+ADx+AB5+AA9+AAd+AAP+AAH+AH/+AH/+AH/+AAAOAAAOAAAOAAAA==";break;
128-
case "keep_left": img = "ERmBAACAAOAB+AD+AP+B/+H3+PO+8c8w4wBwADgAHgAPAAfAAfAAfAAfAAeAAeAAcAA8AA4ABwADgA==";break;
129-
case "keep_right": img = "ERmBAACAAOAA/AD+AP+A//D/fPueeceY4YBwADgAPAAeAB8AHwAfAB8ADwAPAAcAB4ADgAHAAOAAAA==";break;
130-
case "uturn_left": img = "GRiBAAAH4AAP/AAP/wAPj8APAfAPAHgHgB4DgA8BwAOA4AHAcADsOMB/HPA7zvgd9/gOf/gHH/gDh/gBwfgA4DgAcBgAOAAAHAAADgAABw==";break;
131-
case "uturn_right": img = "GRiBAAPwAAf+AAf/gAfj4AfAeAPAHgPADwHgA4DgAcBwAOA4AHAcBjhuB5x/A+57gP99wD/84A/8cAP8OAD8HAA4DgAMBwAAA4AAAcAAAA==";break;
132-
case "finish": img = "HhsBAcAAAD/AAAH/wAAPB4AAeA4AAcAcAAYIcAA4cMAA48MAA4cMAAYAcAAcAcAAcA4AAOA4AAOBxjwHBzjwHjj/4Dnn/4B3P/4B+Pj4A8fj8Acfj8AI//8AA//+AA/j+AB/j+AB/j/A";break;
133-
case "roundabout_left": img = carIsRHD ? "HBaCAAADwAAAAAAAD/AAAVUAAD/wABVVUAD/wABVVVQD/wAAVABUD/wAAVAAFT/////wABX/////8AAF//////AABT/////wABUP/AAD/AAVA/8AA/8AVAD/wAD//VQAP/AAP/1QAA/wAA/9AAADwAAD/AAAAAAAA/wAAAAAAAP8AAAAAAAD/AAAAAAAA/wAAAAAAAP8AAAAAAAD/AA=" : "HRYCAAPAAAAAAAAD/AAD//AAA/8AD///AAP/AA////AD/wAD/wP/A/8AA/wAP8P/////AAP//////8AA///////AAD/P////8AAP8P/AABUAD/AP/AAFUA/8AP/AAFX//AAP/AAFf/wAAP8AAB/8AAAPAAAD8AAAAAAAAPwAAAAAAAA/AAAAAAAAD8AAAAAAAAPwAAAAAAAA/AAAAAAAAD8AAA==";break;
134-
case "roundabout_right": img = carIsRHD ? "HRaCAAAAAAAA8AAAP/8AAP8AAD///AA/8AA////AA/8AP/A/8AA/8A/wAP8AA/8P8AA/////8/wAD///////AAD//////8AAP////8P8ABUAAP/A/8AVQAD/wA//1UAA/8AA//VAAP/AAA/9AAA/wAAAPwAAA8AAAA/AAAAAAAAD8AAAAAAAAPwAAAAAAAA/AAAAAAAAD8AAAAAAAAPwAAAAAAA=" : "HBYCAAAAAAPAAABVQAAP8AAFVVQAD/wAFVVVAAP/ABUAFQAA/8BUAAVAAD/wVAAP/////FAAD/////9QAA//////VAAP/////FQAP8AAP/AVAP/AAP/AFX//AAP/AAV//AAP/AAAf/AAD/AAAD/AAAPAAAA/wAAAAAAAP8AAAAAAAD/AAAAAAAA/wAAAAAAAP8AAAAAAAD/AAAAAAA==";break;
135-
case "roundabout_straight": img = carIsRHD ? "EBuCAAADwAAAD/AAAD/8AAD//wAD///AD///8D/P8/z/D/D//A/wPzAP8AwA//UAA//1QA//9VA/8AFUP8AAVD8AAFQ/AABUPwAAVD8AAFQ/wABUP/ABVA//9VAD//VAAP/1AAAP8AAAD/AAAA/wAA==" : "EBsCAAPAAAAP8AAAP/wAAP//AAP//8AP///wP8/z/P8P8P/8D/A/MA/wDABf/wABX//ABV//8BVAD/wVAAP8FQAA/BUAAPwVAAD8FQAA/BUAA/wVQA/8BV//8AFf/8AAX/8AAA/wAAAP8AAAD/AA";break;
136-
case "roundabout_uturn": img = carIsRHD ? "ICCBAAAAAAAAAAAAAAAAAAAP4AAAH/AAAD/4AAB4fAAA8DwAAPAcAADgHgAA4B4AAPAcAADwPAAAeHwAADz4AAAc8AAABPAAAADwAAAY8YAAPPPAAD73gAAf/4AAD/8AABf8AAAb+AAAHfAAABzwAAAcYAAAAAAAAAAAAAAAAAAAAAAA" : "ICABAAAAAAAAAAAAAAAAAAfwAAAP+AAAH/wAAD4eAAA8DwAAOA8AAHgHAAB4BwAAOA8AADwPAAA+HgAAHzwAAA84AAAPIAAADwAAAY8YAAPPPAAB73wAAf/4AAD/8AAAP+gAAB/YAAAPuAAADzgAAAY4AAAAAAAAAAAAAAAAAAAAAAA=";break;
122+
case "continue": img = "EBgBAIABwAPgD/Af+D/8f/773/PPY8cDwAPAA8ADwAPAA8AAAAPAA8ADwAAAA8ADwAPA";break;
123+
case "left": img = "GhcBAYAAAPAAAHwAAD4AAB8AAA+AAAf//8P///x///+PAAPx4AA8fAAHD4ABwfAAcDwAHAIABwAAAcAAAHAAABwAAAcAAAHAAABwAAAc";break;
124+
case "right": img = "GhcBAABgAAA8AAAPgAAB8AAAPgAAB8D///j///9///+/AAPPAAHjgAD44AB8OAA+DgAPA4ABAOAAADgAAA4AAAOAAADgAAA4AAAOAAAA";break;
125+
case "left_slight": img = "ERgB//B/+D/8H4AP4Af4A74Bz4Dj4HD4OD4cD4AD4ADwADwADgAHgAPAAOAAcAA4ABwADgAH";break;
126+
case "right_slight": img = "ERgBB/+D/8H/4APwA/gD/APuA+cD44Phw+Dj4HPgAeAB4ADgAPAAeAA4ABwADgAHAAOAAcAA";break;
127+
case "left_sharp": img = "GBaBAAAA+AAB/AAH/gAPjgAeBwA8BwB4B+DwB+HgB+PAB+eAB+8AB+4AB/wAB/gAB//gB//gB//gBwAABwAABwAABwAABw=="; break;
128+
case "right_sharp": img = "GBaBAB8AAD+AAH/gAHHwAOB4AOA8AOAeAOAPB+AHh+ADx+AB5+AA9+AAd+AAP+AAH+AH/+AH/+AH/+AAAOAAAOAAAOAAAA==";break;
129+
case "keep_left": img = "ERmBAACAAOAB+AD+AP+B/+H3+PO+8c8w4wBwADgAHgAPAAfAAfAAfAAfAAeAAeAAcAA8AA4ABwADgA==";break;
130+
case "keep_right": img = "ERmBAACAAOAA/AD+AP+A//D/fPueeceY4YBwADgAPAAeAB8AHwAfAB8ADwAPAAcAB4ADgAHAAOAAAA==";break;
131+
case "uturn_left": img = "GRiBAAAH4AAP/AAP/wAPj8APAfAPAHgHgB4DgA8BwAOA4AHAcADsOMB/HPA7zvgd9/gOf/gHH/gDh/gBwfgA4DgAcBgAOAAAHAAADgAABw==";break;
132+
case "uturn_right": img = "GRiBAAPwAAf+AAf/gAfj4AfAeAPAHgPADwHgA4DgAcBwAOA4AHAcBjhuB5x/A+57gP99wD/84A/8cAP8OAD8HAA4DgAMBwAAA4AAAcAAAA==";break;
133+
case "finish": img = "HhsBAcAAAD/AAAH/wAAPB4AAeA4AAcAcAAYIcAA4cMAA48MAA4cMAAYAcAAcAcAAcA4AAOA4AAOBxjwHBzjwHjj/4Dnn/4B3P/4B+Pj4A8fj8Acfj8AI//8AA//+AA/j+AB/j+AB/j/A";break;
134+
case "roundabout_left": img = carIsRHD ? "HBaCAAADwAAAAAAAD/AAAVUAAD/wABVVUAD/wABVVVQD/wAAVABUD/wAAVAAFT/////wABX/////8AAF//////AABT/////wABUP/AAD/AAVA/8AA/8AVAD/wAD//VQAP/AAP/1QAA/wAA/9AAADwAAD/AAAAAAAA/wAAAAAAAP8AAAAAAAD/AAAAAAAA/wAAAAAAAP8AAAAAAAD/AA=" : "HRYCAAPAAAAAAAAD/AAD//AAA/8AD///AAP/AA////AD/wAD/wP/A/8AA/wAP8P/////AAP//////8AA///////AAD/P////8AAP8P/AABUAD/AP/AAFUA/8AP/AAFX//AAP/AAFf/wAAP8AAB/8AAAPAAAD8AAAAAAAAPwAAAAAAAA/AAAAAAAAD8AAAAAAAAPwAAAAAAAA/AAAAAAAAD8AAA==";break;
135+
case "roundabout_right": img = carIsRHD ? "HRaCAAAAAAAA8AAAP/8AAP8AAD///AA/8AA////AA/8AP/A/8AA/8A/wAP8AA/8P8AA/////8/wAD///////AAD//////8AAP////8P8ABUAAP/A/8AVQAD/wA//1UAA/8AA//VAAP/AAA/9AAA/wAAAPwAAA8AAAA/AAAAAAAAD8AAAAAAAAPwAAAAAAAA/AAAAAAAAD8AAAAAAAAPwAAAAAAA=" : "HBYCAAAAAAPAAABVQAAP8AAFVVQAD/wAFVVVAAP/ABUAFQAA/8BUAAVAAD/wVAAP/////FAAD/////9QAA//////VAAP/////FQAP8AAP/AVAP/AAP/AFX//AAP/AAV//AAP/AAAf/AAD/AAAD/AAAPAAAA/wAAAAAAAP8AAAAAAAD/AAAAAAAA/wAAAAAAAP8AAAAAAAD/AAAAAAA==";break;
136+
case "roundabout_straight": img = carIsRHD ? "EBuCAAADwAAAD/AAAD/8AAD//wAD///AD///8D/P8/z/D/D//A/wPzAP8AwA//UAA//1QA//9VA/8AFUP8AAVD8AAFQ/AABUPwAAVD8AAFQ/wABUP/ABVA//9VAD//VAAP/1AAAP8AAAD/AAAA/wAA==" : "EBsCAAPAAAAP8AAAP/wAAP//AAP//8AP///wP8/z/P8P8P/8D/A/MA/wDABf/wABX//ABV//8BVAD/wVAAP8FQAA/BUAAPwVAAD8FQAA/BUAA/wVQA/8BV//8AFf/8AAX/8AAA/wAAAP8AAAD/AA";break;
137+
case "roundabout_uturn": img = carIsRHD ? "ICCBAAAAAAAAAAAAAAAAAAAP4AAAH/AAAD/4AAB4fAAA8DwAAPAcAADgHgAA4B4AAPAcAADwPAAAeHwAADz4AAAc8AAABPAAAADwAAAY8YAAPPPAAD73gAAf/4AAD/8AABf8AAAb+AAAHfAAABzwAAAcYAAAAAAAAAAAAAAAAAAAAAAA" : "ICABAAAAAAAAAAAAAAAAAAfwAAAP+AAAH/wAAD4eAAA8DwAAOA8AAHgHAAB4BwAAOA8AADwPAAA+HgAAHzwAAA84AAAPIAAADwAAAY8YAAPPPAAB73wAAf/4AAD/8AAAP+gAAB/YAAAPuAAADzgAAAY4AAAAAAAAAAAAAAAAAAAAAAA=";break;
137138
}
138139

139140
layout = new Layout({ type:"v", c: [
@@ -196,7 +197,7 @@ function showMusicMessage(msg) {
196197
msg.new = false;
197198
layout = undefined;
198199
if (wasNew) checkMessages({clockIfNoMsg:1,clockIfAllRead:1,ignoreUnread:1,openMusic:0});
199-
else returnToMain();
200+
else returnToMain();
200201
}
201202
function updateLabels() {
202203
trackName = reduceStringAndPad(msg.track, trackScrollOffset, 13);
@@ -246,44 +247,156 @@ function showMusicMessage(msg) {
246247
}, 400);
247248
}
248249

249-
function showMessageScroller(msg) {
250-
cancelReloadTimeout();
250+
function showMessagesScroller(msg, persist, alreadyProcessed) {
251+
if (persist===undefined) {persist = true;}
252+
const MSG_IDX = msg ? MESSAGES.findIndex((m)=>m.id==msg.id) : 0;
253+
const INITIATED_FROM =
254+
alreadyProcessed===undefined ? "other function" :
255+
(MSG_IDX<=alreadyProcessed.startIdx ? "scrolling up" :
256+
(MSG_IDX >= alreadyProcessed.stopIdx-1 ? "scrolling down" : undefined));
257+
258+
const WU = require("widget_utils");
259+
WU.hide();
260+
261+
if (replying) { return; }
262+
if (persist) {cancelReloadTimeout();} else {resetReloadTimeout();}
263+
264+
let updatedProcessed = {};
265+
let startIdx = 0;
266+
let stopIdx = 0;
267+
268+
if (INITIATED_FROM === "other function") {
269+
startIdx = Math.max(MSG_IDX-1, 0);
270+
stopIdx = Math.min(MSG_IDX+2, MESSAGES.length);
271+
Object.assign(updatedProcessed, {startIdx:startIdx, stopIdx:stopIdx});
272+
} else if (INITIATED_FROM === "scrolling up") {
273+
startIdx = MSG_IDX;
274+
stopIdx = alreadyProcessed.startIdx;
275+
Object.assign(updatedProcessed,
276+
{startIdx:startIdx, stopIdx:alreadyProcessed.stopIdx});
277+
} else if (INITIATED_FROM === "scrolling down") {
278+
startIdx = alreadyProcessed.stopIdx;
279+
stopIdx = Math.min(MSG_IDX+1, MESSAGES.length);
280+
Object.assign(updatedProcessed,
281+
{startIdx:alreadyProcessed.startIdx, stopIdx:stopIdx});
282+
}
283+
251284
active = "scroller";
252285
var bodyFont = fontBig;
253286
g.setFont(bodyFont);
254-
var lines = [];
255-
if (msg.title) lines = g.wrapString(msg.title, g.getWidth()-10);
256-
var titleCnt = lines.length;
257-
if (titleCnt) lines.push(""); // add blank line after title
258-
lines = lines.concat(g.wrapString(msg.body, g.getWidth()-10),["",/*LANG*/"< Back"]);
287+
var titleLines = [];
288+
var messagesWrapped = [];
289+
for (let i=startIdx ; i<stopIdx ; i++) {
290+
let msgLocal = MESSAGES[i];
291+
msgLocal.new = false;
292+
293+
if (msgLocal.id=="music" || msgLocal.source=="maps" || msgLocal.id =="call") {
294+
stopIdx++
295+
if (stopIdx>=MESSAGES.length) {break;}
296+
continue;
297+
}
298+
299+
var lines = [];
300+
lines = g.wrapString(msgLocal.title||msgLocal.sender||msgLocal.subject||msgLocal.src||"No Title", g.getWidth()-10);
301+
for (let i=0; i<lines.length; i++) {
302+
titleLines.push(i + (messagesWrapped[0]?messagesWrapped[0].length:0) +
303+
(messagesWrapped[1]?messagesWrapped[1].length:0));
304+
}
305+
var titleCnt = lines.length;
306+
if (titleCnt) {lines.push("");} // add blank line after title
307+
lines = lines.concat(g.wrapString(msgLocal.body, g.getWidth()-10),
308+
["-".repeat(i+1)]);
309+
messagesWrapped.push(lines);
310+
}
311+
312+
let allLines = [];
313+
for (let i=0 ; i<messagesWrapped.length ; i++) {
314+
allLines = allLines.concat(messagesWrapped[i]);
315+
}
316+
317+
var initScroll = messagesWrapped[0].length;
318+
if (INITIATED_FROM === "other function") {
319+
if (MSG_IDX==0) {initScroll = 0;}
320+
} else if (INITIATED_FROM === "scrolling up") {
321+
titleLines = titleLines.concat(alreadyProcessed.titleLines.
322+
map((x) => x + allLines.length));
323+
allLines = allLines.concat(alreadyProcessed.lines);
324+
} else if (INITIATED_FROM === "scrolling down") {
325+
initScroll = alreadyProcessed.lines.length-9; // FIXME: `-9` corresponds to the Bangle.js 2 screen height - should probably be variable by screen height, font height.
326+
titleLines = alreadyProcessed.titleLines.concat(titleLines.
327+
map((x) => x + alreadyProcessed.lines.length));
328+
allLines = alreadyProcessed.lines.concat(allLines);
329+
}
330+
331+
if (allLines.length == 0 && alreadyProcessed.lines.length == 0) {
332+
cancelReloadTimeout();
333+
returnToClockIfEmpty();
334+
}
335+
336+
Object.assign(updatedProcessed,
337+
{ lines : allLines,
338+
titleLines : titleLines,
339+
messagesWrappedLength : messagesWrapped.length });
340+
341+
let prevScrollIdx; // Used for stopping multiple triggers of next message by the scroller.
342+
259343
E.showScroller({
344+
scroll : initScroll*g.getFontHeight(),
260345
h : g.getFontHeight(), // height of each menu item in pixels
261-
c : lines.length, // number of menu items
346+
c : allLines.length, // number of menu items
262347
// a function to draw a menu item
263-
draw : function(idx, r) {
264-
// FIXME: in 2v13 onwards, clearRect(r) will work fine. There's a bug in 2v12
265-
g.setBgColor(idx<titleCnt ? g.theme.bg2 : g.theme.bg).
266-
setColor(idx<titleCnt ? g.theme.fg2 : g.theme.fg).
267-
clearRect(r.x,r.y,r.x+r.w, r.y+r.h);
268-
g.setFont(bodyFont).setFontAlign(0,-1).drawString(lines[idx], r.x+r.w/2, r.y);
269-
}, select : function(idx) {
270-
if (idx>=lines.length-2)
271-
showMessage(msg.id, true);
348+
draw : function(scrollIdx, r) {
349+
"ram"
350+
g.setBgColor(titleLines.find((e)=>e==scrollIdx)!==undefined ? g.theme.bg2 : g.theme.bg).
351+
setColor(titleLines.find((e)=>e==scrollIdx)!==undefined ? g.theme.fg2 : g.theme.fg).
352+
clearRect(r);
353+
g.setFont(bodyFont).setFontAlign(0,-1).drawString(allLines[scrollIdx], r.x+r.w/2, r.y);
354+
// Load in next/previous message on demand by reinitializing showMessagesScroller while passing on the processed messages.
355+
if (scrollIdx>=allLines.length-1 && scrollIdx!=prevScrollIdx &&
356+
updatedProcessed.stopIdx<MESSAGES.length) {
357+
setTimeout(() => {
358+
E.showScroller();
359+
showMessagesScroller(MESSAGES[updatedProcessed.stopIdx], true, updatedProcessed);
360+
}, 40);
361+
}
362+
if (scrollIdx==0 && scrollIdx!=prevScrollIdx && updatedProcessed.startIdx>0) {
363+
setTimeout(() => {
364+
E.showScroller();
365+
showMessagesScroller(MESSAGES[updatedProcessed.startIdx-1], true, updatedProcessed);
366+
}, 40);
367+
}
368+
prevScrollIdx = scrollIdx;
369+
}, select : function(scrollIdx, touch) {
370+
let msgSelect;
371+
for (let i = titleLines.length-1; i>=0 ; i--) {
372+
if (scrollIdx>=titleLines[i]) {
373+
msgSelect = MESSAGES[i + updatedProcessed.startIdx];
374+
break;
375+
}
376+
}
377+
if (touch.type == 0) {
378+
WU.show();
379+
showMessage(msgSelect.id, true)
380+
}
381+
if (touch.type == 2) {
382+
WU.show();
383+
showMessageSettings(msgSelect)
384+
}
272385
},
273-
back : () => showMessage(msg.id, true)
386+
//back : () => showMessage(messages[idx].id, true)
274387
});
275388
}
276389

277390
function showMessageSettings(msg) {
278391
active = "settings";
279392
var menu = {"":{
280-
"title":/*LANG*/"Message",
281-
back:() => showMessage(msg.id, true)
282-
},
393+
"title":/*LANG*/"Message",
394+
back:() => showMessage(msg.id, true)
395+
},
283396
};
284397

285398
if (msg.id!="music")
286-
menu[/*LANG*/"View Message"] = () => showMessageScroller(msg);
399+
menu[/*LANG*/"View Message"] = () => showMessagesScroller(msg);
287400

288401
if (msg.reply && reply) {
289402
menu[/*LANG*/"Reply"] = () => {
@@ -392,7 +505,7 @@ function showMessage(msgid, persist) {
392505
var maxLines = Math.floor(h / g.getFontHeight());
393506
if (lines.length>maxLines) // if too long, wrap with a bit less spae so we have room for '...'
394507
body = g.setFont(bodyFont).wrapString(body, w-10).slice(0,maxLines).join("\n")+"...";
395-
else
508+
else
396509
body = lines.join("\n");
397510
}
398511
function goBack() {
@@ -456,7 +569,7 @@ function showMessage(msgid, persist) {
456569
]},
457570
{type:"txt", font:bodyFont, label:body, fillx:1, filly:1, pad:2, cb:()=>{
458571
// allow tapping to show a larger version
459-
showMessageScroller(msg);
572+
showMessagesScroller(msg);
460573
} },
461574
{type:"h",fillx:1, c: footer}
462575
]},{back:goBack});
@@ -502,7 +615,8 @@ function checkMessages(options) {
502615
// If we have a new message, show it
503616
if (!options.ignoreUnread && newMessages.length) {
504617
delete newMessages[0].show; // stop us getting stuck here if we're called a second time
505-
showMessage(newMessages[0].id, false);
618+
//showMessage(newMessages[0].id, false);
619+
showMessagesScroller(newMessages[0], false);
506620
// buzz after showMessage, so being busy during layout doesn't affect the buzz pattern
507621
if (global.BUZZ_ON_NEW_MESSAGE) {
508622
// this is set if we entered the messages app by loading `messagegui.new.js`
@@ -527,7 +641,7 @@ function checkMessages(options) {
527641
draw : function(idx, r) {"ram"
528642
var msg = MESSAGES[idx];
529643
if (msg && msg.new) g.setBgColor(g.theme.bgH).setColor(g.theme.fgH);
530-
else g.setBgColor(g.theme.bg).setColor(g.theme.fg);
644+
else g.setBgColor(g.theme.bg).setColor(g.theme.fg);
531645
g.clearRect(r.x,r.y,r.x+r.w, r.y+r.h);
532646
if (!msg) return;
533647
var x = r.x+2, title = msg.title, body = msg.body;
@@ -538,9 +652,9 @@ function checkMessages(options) {
538652
}
539653
if (img) {
540654
var fg = g.getColor(),
541-
col = require("messageicons").getColor(msg, {settings, default:fg});
655+
col = require("messageicons").getColor(msg, {settings, default:fg});
542656
g.setColor(col).drawImage(img, x+24, r.y+24, {rotate:0}) // force centering
543-
.setColor(fg); // only color the icon
657+
.setColor(fg); // only color the icon
544658
x += 50;
545659
}
546660
if (title) g.setFontAlign(-1,-1).setFont(fontBig).drawString(title, x,r.y+2);

apps/messagegui/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"id": "messagegui",
33
"name": "Message UI",
44
"shortName": "Messages",
5-
"version": "0.84",
5+
"version": "0.85",
66
"description": "Default app to display notifications from iOS and Gadgetbridge/Android",
77
"icon": "app.png",
88
"type": "app",

core

0 commit comments

Comments
 (0)