messagegui: fix lint warnings and error

Author: thyttan

apps/messagegui/app.js

@@ -291,9 +291,7 @@ function showMessageScroller2(msg, persist, alreadyProcessed) {
   active = "scroller";
   var bodyFont = fontBig;
   g.setFont(bodyFont);
-  var allLines = [];
   var titleLines = [];
-  var j = MESSAGES.length-1;
   var messagesWrapped = [];
   for (let j=startIdx; j<stopIdx; j++) {
     let msgLocal = MESSAGES[j];
@@ -316,17 +314,17 @@ function showMessageScroller2(msg, persist, alreadyProcessed) {
     if (titleCnt) {lines.push("");} // add blank line after title
     lines = lines.concat(g.wrapString(msgLocal.body, g.getWidth()-10), ["-".repeat(j+1)]);
     messagesWrapped.push(lines);
-  };
-  let allLines2 = [];
+  }
+  let allLines = [];
   for (let i=0;i<messagesWrapped.length;i++) {
-    allLines2 = allLines2.concat(messagesWrapped[i]);
+    allLines = allLines.concat(messagesWrapped[i]);
   }
 
   var initScroll = messagesWrapped[0].length;
   if (initiatedFrom === "other function"){
     if (msgIdx==0) initScroll = 0;
   } else if (initiatedFrom === "scrolling up") {
-    titleLines = titleLines.concat(alreadyProcessed.titleLines.map((x) => x + allLines2.length));
+    titleLines = titleLines.concat(alreadyProcessed.titleLines.map((x) => x + allLines.length));
   } else if (initiatedFrom === "scrolling down"){
     initScroll = alreadyProcessed.lines.length-9;
     titleLines = alreadyProcessed.titleLines.concat(titleLines.map((x) => x + alreadyProcessed.lines.length));
@@ -335,20 +333,20 @@ function showMessageScroller2(msg, persist, alreadyProcessed) {
   if (initiatedFrom === "other function"){
     // no-op
   } else if (initiatedFrom === "scrolling up") {
-    allLines2 = allLines2.concat(alreadyProcessed.lines);
+    allLines = allLines.concat(alreadyProcessed.lines);
   } else if (initiatedFrom === "scrolling down"){
-    allLines2 = alreadyProcessed.lines.concat(allLines2);
+    allLines = alreadyProcessed.lines.concat(allLines);
   }
 
-  if (allLines2.length == 0 && alreadyProcessed.lines.length == 0) {
+  if (allLines.length == 0 && alreadyProcessed.lines.length == 0) {
     cancelReloadTimeout();
     returnToClockIfEmpty();
   }
 
   Object.assign(
     updatedProcessed,
     {
-      lines : allLines2,
+      lines : allLines,
       titleLines : titleLines,
       messagesWrappedLength : messagesWrapped.length
     }
@@ -359,15 +357,15 @@ function showMessageScroller2(msg, persist, alreadyProcessed) {
   E.showScroller({
     scroll : initScroll*g.getFontHeight(),
     h : g.getFontHeight(), // height of each menu item in pixels
-    c : allLines2.length, // number of menu items
+    c : allLines.length, // number of menu items
     // a function to draw a menu item
     draw : function(scrollIdx, r) {
       "ram"
       g.setBgColor(titleLines.find((e)=>e==scrollIdx)!==undefined ? g.theme.bg2 : g.theme.bg).
         setColor(titleLines.find((e)=>e==scrollIdx)!==undefined ? g.theme.fg2 : g.theme.fg).
         clearRect(r);
-      g.setFont(bodyFont).setFontAlign(0,-1).drawString(allLines2[scrollIdx], r.x+r.w/2, r.y);
-      if (scrollIdx>=allLines2.length-1 && scrollIdx!=prevScrollIdx && updatedProcessed.stopIdx < MESSAGES.length) {
+      g.setFont(bodyFont).setFontAlign(0,-1).drawString(allLines[scrollIdx], r.x+r.w/2, r.y);
+      if (scrollIdx>=allLines.length-1 && scrollIdx!=prevScrollIdx && updatedProcessed.stopIdx < MESSAGES.length) {
         setTimeout(() => {
           E.showScroller();
           showMessageScroller2(MESSAGES[updatedProcessed.stopIdx], true, updatedProcessed);