Skip to content

Commit de755df

Browse files
author
thyttan
committed
messagegui: move some plumbing from showMessageOverview
... to `showMessageRouter`.
1 parent a853b9f commit de755df

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

apps/messagegui/app.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ var onMessagesModified = function(type,msg) {
9292
}
9393
if (msg && msg.id=="nav" && msg.t=="modify" && active!="map")
9494
return; // don't show an updated nav message if we're just in the menu
95-
showMessageOverview(msg&&msg.id, false);
95+
showMessageRouter(msg, persist, "dependsOnActive");
9696
};
9797
Bangle.on("message", onMessagesModified);
9898

@@ -469,24 +469,15 @@ function showMessageSettings(msg) {
469469
E.showMenu(menu);
470470
}
471471

472-
function showMessageOverview(msgid, persist) {
472+
function showMessageOverview(msgid) {
473473
if (replying) { return; }
474-
if(!persist) resetReloadTimeout();
475474
let idx = MESSAGES.findIndex(m=>m.id==msgid);
476475
var msg = MESSAGES[idx];
477476
if (updateLabelsInterval) {
478477
clearInterval(updateLabelsInterval);
479478
updateLabelsInterval=undefined;
480479
}
481480
if (!msg) return returnToClockIfEmpty(); // go home if no message found
482-
if (msg.id=="music") {
483-
cancelReloadTimeout(); // don't auto-reload to clock now
484-
return showMusicMessage(msg);
485-
}
486-
if (msg.id=="nav") {
487-
cancelReloadTimeout(); // don't auto-reload to clock now
488-
return showMapMessage(msg);
489-
}
490481
active = "overview";
491482
// Normal text message display
492483
var title=msg.title, titleFont = fontLarge, lines;
@@ -593,8 +584,8 @@ function showMessageOverview(msgid, persist) {
593584
Bangle.swipeHandler = (lr,ud) => {
594585
if (lr>0 && posHandler) posHandler();
595586
if (lr<0 && negHandler) negHandler();
596-
if (ud>0 && idx<MESSAGES.length-1) showMessageOverview(MESSAGES[idx+1].id, true);
597-
if (ud<0 && idx>0) showMessageOverview(MESSAGES[idx-1].id, true);
587+
if (ud>0 && idx<MESSAGES.length-1) showMessageOverview(MESSAGES[idx+1].id);
588+
if (ud<0 && idx>0) showMessageOverview(MESSAGES[idx-1].id);
598589
};
599590
Bangle.on("swipe", Bangle.swipeHandler);
600591
g.reset().clearRect(Bangle.appRect);
@@ -644,7 +635,7 @@ function checkMessages(options) {
644635
}
645636
// no new messages: show playing music? Only if we have playing music, or state=="show" (set by messagesmusic)
646637
if (options.openMusic && MESSAGES.some(m=>m.id=="music" && ((m.track && m.state=="play") || m.state=="show")))
647-
return showMessageOverview('music', true);
638+
return showMessageOverview('music');
648639
// no new messages - go to clock?
649640
if (options.clockIfAllRead && newMessages.length==0)
650641
return load();

0 commit comments

Comments
 (0)