Add some syntactic sugar

Author: tiagopog

lib/jsonapi/utils/exceptions.rb

@@ -26,21 +26,25 @@ class BadRequest < ::JSONAPI::Exceptions::Error
         def code; '400' end
 
         def errors
-          [JSONAPI::Error.new(code: code,
-                              status: :bad_request,
-                              title: 'Bad Request',
-                              detail: 'This request is not supported.')]
+          [JSONAPI::Error.new(
+              code: code,
+              status: :bad_request,
+              title: 'Bad Request',
+              detail: 'This request is not supported.'
+            )]
         end
       end
 
       class InternalServerError < ::JSONAPI::Exceptions::Error
         def code; '500' end
 
         def errors
-          [JSONAPI::Error.new(code: code,
-                              status: :internal_server_error,
-                              title: 'Internal Server Error',
-                              detail: 'An internal error ocurred while processing the request.')]
+          [JSONAPI::Error.new(
+            code: code,
+            status: :internal_server_error,
+            title: 'Internal Server Error',
+            detail: 'An internal error ocurred while processing the request.'
+          )]
         end
       end
     end

lib/jsonapi/utils/response/formatters.rb

@@ -21,12 +21,6 @@ def jsonapi_format_errors(data)
 
         protected
 
-        def correct_media_type
-          if response.body.size > 0
-            response.headers['Content-Type'] = JSONAPI::MEDIA_TYPE
-          end
-        end
-
         def build_response_document(records, options)
           results = JSONAPI::OperationResults.new
 

lib/jsonapi/utils/response/support.rb

@@ -11,6 +11,14 @@ module Support
         include ::JSONAPI::Utils::Support::Filter
         include ::JSONAPI::Utils::Support::Pagination
         include ::JSONAPI::Utils::Support::Sort
+
+        protected
+
+        def correct_media_type
+          if response.body.size > 0
+            response.headers['Content-Type'] = JSONAPI::MEDIA_TYPE
+          end
+        end
       end
     end
   end

spec/controllers/posts_controller_spec.rb

@@ -8,13 +8,14 @@
   let(:fields)        { (PostResource.fetchable_fields - %i(id author)).map(&:to_s) }
   let(:relationships) { %w(author) }
   let(:first_post)    { Post.first }
+  let(:user_id)       { first_post.user_id }
 
   let(:attributes) do
     { title: 'Lorem ipsum', body: 'Lorem ipsum dolor sit amet.' }
   end
 
   let(:author_params) do
-    { data: { type: 'users', id: first_post.user_id } }
+    { data: { type: 'users', id: user_id } }
   end
 
   let(:post_params) do
@@ -27,7 +28,7 @@
   describe '#index' do
     context 'with ActiveRecord::Relation' do
       it 'renders a collection of users' do
-        get :index, user_id: first_post.user_id
+        get :index, user_id: user_id
         expect(response).to have_http_status :ok
         expect(response).to have_primary_data('posts')
         expect(response).to have_data_attributes(fields)
@@ -50,7 +51,7 @@
   describe '#show' do
     context 'with ActiveRecord' do
       it 'renders a single post' do
-        get :show, user_id: first_post.user_id, id: first_post.id
+        get :show, user_id: user_id, id: first_post.id
         expect(response).to have_http_status :ok
         expect(response).to have_primary_data('posts')
         expect(response).to have_data_attributes(fields)
@@ -73,7 +74,7 @@
     context 'when resource was not found' do
       context 'with conventional id' do
         it 'renders a 404 response' do
-          get :show, user_id: first_post.user_id, id: 999
+          get :show, user_id: user_id, id: 999
           expect(response).to have_http_status :not_found
           expect(error['title']).to eq('Record not found')
           expect(error['detail']).to include('999')
@@ -85,7 +86,7 @@
         let(:uuid) { SecureRandom.uuid }
 
         it 'renders a 404 response' do
-          get :show, user_id: first_post.user_id, id: uuid
+          get :show, user_id: user_id, id: uuid
           expect(response).to have_http_status :not_found
           expect(error['title']).to eq('Record not found')
           expect(error['detail']).to include(uuid)
@@ -97,7 +98,7 @@
         let(:slug) { 'some-awesome-slug' }
 
         it 'renders a 404 response' do
-          get :show, user_id: first_post.user_id, id: slug
+          get :show, user_id: user_id, id: slug
           expect(response).to have_http_status :not_found
           expect(error['title']).to eq('Record not found')
           expect(error['detail']).to include(slug)