Skip to content

Commit 9ba3df9

Browse files
tangg555fridayLglin93
authored
Scheduler: new feat to addressed repeated task issues (MemTensor#594)
* debug an error function name * feat: Add DynamicCache compatibility for different transformers versions - Fix build_kv_cache method in hf.py to handle both old and new DynamicCache structures - Support new 'layers' attribute with key_cache/value_cache or keys/values - Maintain backward compatibility with direct key_cache/value_cache attributes - Add comprehensive error handling and logging for unsupported structures - Update move_dynamic_cache_htod function in kv.py for cross-version compatibility - Handle layers-based structure in newer transformers versions - Support alternative attribute names (keys/values vs key_cache/value_cache) - Preserve original functionality for older transformers versions - Add comprehensive tests for DynamicCache compatibility - Test activation memory update with mock DynamicCache layers - Verify layers attribute access across different transformers versions - Fix scheduler logger mock to include memory_manager attribute This resolves AttributeError issues when using different versions of the transformers library and ensures robust handling of DynamicCache objects. debug * feat: implement APIAnalyzerForScheduler for memory operations - Add APIAnalyzerForScheduler class with search/add operations - Support requests and http.client with connection reuse - Include comprehensive error handling and dynamic configuration - Add English test suite with real-world conversation scenarios * feat: Add search_ws API endpoint and enhance API analyzer functionality - Add search_ws endpoint in server_router.py for scheduler-enabled search - Fix missing imports: time module, SearchRequest class, and get_mos_product_instance function - Implement search_ws method in api_analyzer.py with HTTP client support - Add _search_ws_with_requests and _search_ws_with_http_client private methods - Include search_ws usage example in demonstration code - Enhance scheduler and dispatcher capabilities for improved memory management - Expand test coverage to ensure functionality stability This update primarily strengthens the memory scheduling system's search capabilities, providing users with more flexible API interface options. * fix: resolve test failures and warnings in test suite - Fix Pydantic serialization warning in test_memos_chen_tang_hello_world * Add warnings filter to suppress UserWarning from Pydantic serialization - Fix KeyError: 'past_key_values' in test_build_kv_cache_and_generation * Update mock configuration to properly return forward_output with past_key_values * Add DynamicCache version compatibility handling in test mocks * Support both old and new transformers versions with layers/key_cache attributes * Improve assertion logic to check all model calls for required parameters - Update base_scheduler.py to use centralized DEFAULT_MAX_INTERNAL_MESSAGE_QUEUE_SIZE constant * Add import for DEFAULT_MAX_INTERNAL_MESSAGE_QUEUE_SIZE from general_schemas * Replace hardcoded value 100 with configurable constant (1000) All tests now pass successfully with proper version compatibility handling. * feat: add a test_robustness execution to test thread pool execution * feat: optimize scheduler configuration and API search functionality - Add DEFAULT_TOP_K and DEFAULT_CONTEXT_WINDOW_SIZE global constants in general_schemas.py - Update base_scheduler.py to use global default values instead of hardcoded numbers - Fix SchedulerConfigFactory initialization issue by using keyword argument expansion - Resolve UnboundLocalError variable conflict in search_memories_ws function - Fix indentation and parameter issues in OptimizedScheduler search_for_api method - Improve code standardization and maintainability * feat: Add Redis auto-initialization with fallback strategies - Add auto_initialize_redis() with config/env/local fallback - Move Redis logic from dispatcher_monitor to redis_service - Update base_scheduler to use auto initialization - Add proper resource cleanup and error handling * feat: add database connection management to ORM module - Add MySQL engine loading from environment variables in BaseDBManager - Add Redis connection loading from environment variables in BaseDBManager - Enhance database configuration validation and error handling - Complete database adapter infrastructure for ORM module - Provide unified database connection management interface This update provides comprehensive database connection management capabilities for the mem_scheduler module, supporting dynamic MySQL and Redis configuration loading from environment variables, establishing reliable data persistence foundation for scheduling services and API services. * remove part of test * feat: add Redis-based ORM with multiprocess synchronization - Add RedisDBManager and RedisLockableORM classes - Implement atomic locking mechanism for concurrent access - Add merge functionality for different object types - Include comprehensive test suite and examples - Fix Redis key type conflicts in lock operations * fix: resolve scheduler module import and Redis integration issues * revise naive memcube creation in server router * remove long-time tests in test_scheduler * remove redis test which needs .env * refactor all codes about mixture search with scheduler * fix: resolve Redis API synchronization issues and implement search API with reranker - Fix running_entries to running_task_ids migration across codebase - Update sync_search_data method to properly handle TaskRunningStatus - Correct variable naming and logic in API synchronization flow - Implement search API endpoint with reranker functionality - Update test files to reflect new running_task_ids convention - Ensure proper Redis state management for concurrent tasks * remove a test for api module * revise to pass the test suite * address some bugs to make mix_search normally running * modify codes according to evaluation logs * feat: Optimize mixture search and enhance API client * feat: Add conversation_turn tracking for session-based memory search - Add conversation_turn field to APIMemoryHistoryEntryItem schema with default value 0 - Implement session counter in OptimizedScheduler to track turn count per session_id - Update sync_search_data method to accept and store conversation_turn parameter - Maintain session history with LRU eviction (max 5 sessions) - Rename conversation_id to session_id for consistency with request object - Enable direct access to session_id from search requests This feature allows tracking conversation turns within the same session, providing better context for memory retrieval and search history management. * adress time bug in monitor * revise simple tree * add mode to evaluation client; rewrite print to logger.info in db files * feat: 1. add redis queue for scheduler 2. finish the code related to mix search and fine search * debug the working memory code * addressed a range of bugs to make scheduler running correctly * remove test_dispatch_parallel test * print change to logger.info * adjucted the core code related to fine and mixture apis * feat: create task queue to wrap local queue and redis queue. queue now split FIFO to multi queue from different users. addressed a range of bugs * fix bugs: debug bugs about internet trigger * debug get searcher mode * feat: add manual internet * Fix: fix code format * feat: add strategy for fine search * debug redis queue * debug redis queue * fix bugs: completely addressed bugs about redis queue * refactor: add searcher to handler_init; remove info log from task_queue * refactor: modify analyzer * refactor: revise locomo_eval to make it support llm other than gpt-4o-mini * feat: develop advanced searcher with deep search * feat: finish a complete version of deep search * refactor: refactor deep search feature, now only allowing one-round deep search * feat: implement the feature of get_tasks_status, but completed tasks are not recorded yet; waiting to be developed * debuging merged code; searching memories have bugs * change logging level * debug api evaluation * fix bugs: change top to top_k * change log * refactor: rewrite deep search to make it work better * change num_users * feat: developed and test task broker and orchestrator * Fix: Include task_id in ScheduleMessageItem serialization * Fix(Scheduler): Correct event log creation and task_id serialization * Feat(Scheduler): Add conditional detailed logging for KB updates Fix(Scheduler): Correct create_event_log indentation * Fix(Scheduler): Correct create_event_log call sites Reverts previous incorrect fix to scheduler_logger.py and correctly fixes the TypeError at the call sites in general_scheduler.py by removing the invalid 'log_content' kwarg and adding the missing memory_type kwargs. * Fix(Scheduler): Deserialize task_id in ScheduleMessageItem.from_dict This completes the fix for the task_id loss. The 'to_dict' method was previously fixed to serialize the task_id, but the corresponding 'from_dict' method was not updated to deserialize it, causing the value to be lost when messages were read from the queue. * Refactor(Config): Centralize RabbitMQ config override logic Moves all environment variable override logic into initialize_rabbitmq for a single source of truth. This ensures Nacos-provided environment variables for all RabbitMQ settings are respected over file configurations. Also removes now-redundant logging from the publish method. * Revert "Refactor(Config): Centralize RabbitMQ config override logic" This reverts commit b8cc42a. * Fix(Redis): Convert None task_id to empty string during serialization Resolves DataError in Redis Streams when task_id is None by ensuring it's serialized as an empty string instead of None, which Redis does not support. Applies to ScheduleMessageItem.to_dict method. * Feat(Log): Add diagnostic log to /product/add endpoint Adds an INFO level diagnostic log message at the beginning of the create_memory function to help verify code deployment. * Feat(Log): Add comprehensive diagnostic logs for /product/add flow Introduces detailed INFO level diagnostic logs across the entire call chain for the /product/add API endpoint. These logs include relevant context, such as full request bodies, message items before scheduler submission, and messages before RabbitMQ publication, to aid in debugging deployment discrepancies and tracing data flow, especially concerning task_id propagation. Logs added/enhanced in: - src/memos/api/routers/product_router.py - src/memos/api/handlers/add_handler.py - src/memos/multi_mem_cube/single_cube.py - src/memos/mem_os/core.py - src/memos/mem_scheduler/general_scheduler.py - src/memos/mem_scheduler/base_scheduler.py - src/memos/mem_scheduler/webservice_modules/rabbitmq_service.py * Feat(Log): Add comprehensive diagnostic logs for /product/add flow and apply ruff formatting Introduces detailed INFO level diagnostic logs across the entire call chain for the /product/add API endpoint. These logs include relevant context, such as full request bodies, message items before scheduler submission, and messages before RabbitMQ publication, to aid in debugging deployment discrepancies and tracing data flow, especially concerning task_id propagation. Also applies automatic code formatting using ruff format to all modified files. Logs added/enhanced in: - src/memos/api/routers/product_router.py - src/memos/api/handlers/add_handler.py - src/memos/multi_mem_cube/single_cube.py - src/memos/mem_os/core.py - src/memos/mem_scheduler/general_scheduler.py - src/memos/mem_scheduler/base_scheduler.py - src/memos/mem_scheduler/webservice_modules/rabbitmq_service.py * Fix(rabbitmq): Use env vars for KB updates and improve logging * Fix(rabbitmq): Explicitly use MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME and empty routing key for KB updates * Fix(add_handler): Update diagnostic log timestamp * Fix(add_handler): Update diagnostic log timestamp again (auto-updated) * Update default scheduler redis stream prefix * Update diagnostic timestamp in add handler * Allow optional log_content in scheduler event log * feat: new examples to test scheduelr * feat: fair scheduler and refactor of search function * fix bugs: address bugs caused by outdated test code * feat: add task_schedule_monitor * fix: handle nil mem_cube in scheduler message consumers * fix bugs: response messaged changed in memos code * refactor: revise task queue to allow it dealing with pending tasks when no task remaining * refactor: revise mixture search and scheduler logger * Fix scheduler task tracking * fix bugs: address ai review issues * fix bugs: address rabbitmq initialization failed when doing pytest * fix(scheduler): Correct dispatcher task and future tracking * Remove dump.rdb * fix bugs: revised message ack logics; refactor add log function * fix bugs: change Chinese notation to English * fix indent error in logger * fix bugs: addressed the issues caused by multiprocessing codes obtain same pending tasks * addMemory/updateMemory log * fix bugs: modify redis queue logics to make it run as expected * feat: add a default mem cube initialization for scheduler * address scheduler init bug * feat(scheduler): Propagate trace_id across process boundaries for mem… (MemTensor#592) feat(scheduler): Propagate trace_id across process boundaries for mem_scheduler logs This commit addresses the issue where 'trace_id' was missing from logs generated by the 'mem_scheduler' module, especially when tasks were executed in separate processes. The changes implement a manual propagation of 'trace_id' from the message producer to the consumer: 1. **Schema Update**: Added an optional 'trace_id' field to 'ScheduleMessageItem' in 'src/memos/mem_scheduler/schemas/message_schemas.py' to allow 'trace_id' to be carried within messages. 2. **Producer-side Capture**: Modified 'src/memos/mem_scheduler/task_schedule_modules/task_queue.py' to capture the current 'trace_id' and embed it into the 'ScheduleMessageItem' before messages are enqueued. 3. **Consumer-side Context Re-establishment**: Updated 'src/memos/mem_scheduler/task_schedule_modules/dispatcher.py' to extract the 'trace_id' from incoming messages and re-establish the logging context using 'RequestContext' for each task's execution. This ensures all logs within a task's scope correctly include its associated 'trace_id', even when crossing process boundaries. This approach ensures robust and accurate tracing of tasks within the scheduler, enhancing observability and debugging capabilities. Co-authored-by: glin1993@outlook.com <> * fix bugs: redis queue allows to reget pending tasks which exceeding idle time * fix(scheduler): Correct lazy-loading logic for mem_cube property * Add MONITOR_EVENT logs for scheduler lifecycle * fix: Resolve Ruff linting and formatting issues --------- Co-authored-by: fridayL <lcy081099@gmail.com> Co-authored-by: glin1993@outlook.com <> Co-authored-by: Zehao Lin <glin1993@outlook.com>
1 parent cc87e2e commit 9ba3df9

File tree

7 files changed

+249
-103
lines changed

7 files changed

+249
-103
lines changed

src/memos/mem_scheduler/base_scheduler.py

Lines changed: 41 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import time
55

66
from collections.abc import Callable
7-
from datetime import datetime
7+
from datetime import datetime, timezone
88
from pathlib import Path
99
from typing import TYPE_CHECKING, Union
1010

@@ -49,6 +49,7 @@
4949
from memos.mem_scheduler.utils.filter_utils import (
5050
transform_name_to_key,
5151
)
52+
from memos.mem_scheduler.utils.monitor_event_utils import emit_monitor_event, to_iso
5253
from memos.mem_scheduler.utils.status_tracker import TaskStatusTracker
5354
from memos.mem_scheduler.webservice_modules.rabbitmq_service import RabbitMQSchedulerModule
5455
from memos.mem_scheduler.webservice_modules.redis_service import RedisSchedulerModule
@@ -175,6 +176,8 @@ def init_mem_cube(
175176
searcher: Searcher | None = None,
176177
feedback_server: Searcher | None = None,
177178
):
179+
if mem_cube is None:
180+
logger.error("mem_cube is None, cannot initialize", stack_info=True)
178181
self.mem_cube = mem_cube
179182
self.text_mem: TreeTextMemory = self.mem_cube.text_mem
180183
self.reranker: HTTPBGEReranker = self.text_mem.reranker
@@ -258,6 +261,15 @@ def _cleanup_on_init_failure(self):
258261
@property
259262
def mem_cube(self) -> BaseMemCube:
260263
"""The memory cube associated with this MemChat."""
264+
if self.current_mem_cube is None:
265+
logger.error("mem_cube is None when accessed", stack_info=True)
266+
try:
267+
self.components = init_components()
268+
self.current_mem_cube: BaseMemCube = self.components["naive_mem_cube"]
269+
except Exception:
270+
logger.info(
271+
"No environment available to initialize mem cube. Using fallback naive_mem_cube."
272+
)
261273
return self.current_mem_cube
262274

263275
@mem_cube.setter
@@ -757,7 +769,35 @@ def _message_consumer(self) -> None:
757769
messages = self.memos_message_queue.get_messages(batch_size=self.consume_batch)
758770

759771
if messages:
772+
now = time.time()
760773
for msg in messages:
774+
enqueue_ts_obj = getattr(msg, "timestamp", None)
775+
enqueue_epoch = None
776+
if isinstance(enqueue_ts_obj, int | float):
777+
enqueue_epoch = float(enqueue_ts_obj)
778+
elif hasattr(enqueue_ts_obj, "timestamp"):
779+
dt = enqueue_ts_obj
780+
if dt.tzinfo is None:
781+
dt = dt.replace(tzinfo=timezone.utc)
782+
enqueue_epoch = dt.timestamp()
783+
784+
queue_wait_ms = None
785+
if enqueue_epoch is not None:
786+
queue_wait_ms = max(0.0, now - enqueue_epoch) * 1000
787+
788+
msg.dequeue_ts = now
789+
emit_monitor_event(
790+
"dequeue",
791+
msg,
792+
{
793+
"enqueue_ts": to_iso(enqueue_ts_obj),
794+
"dequeue_ts": datetime.fromtimestamp(
795+
now, tz=timezone.utc
796+
).isoformat(),
797+
"queue_wait_ms": queue_wait_ms,
798+
},
799+
)
800+
761801
self.metrics.task_dequeued(user_id=msg.user_id, task_type=msg.label)
762802
try:
763803
import contextlib

src/memos/mem_scheduler/schemas/general_schemas.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,12 @@
6666
DEFAULT_MAX_WEB_LOG_QUEUE_SIZE = 50
6767

6868
# task queue
69-
DEFAULT_STREAM_KEY_PREFIX = "scheduler:messages:stream:v1.4"
69+
DEFAULT_STREAM_KEY_PREFIX = "scheduler:messages:stream:v1.5"
7070
exchange_name = os.getenv("MEMSCHEDULER_RABBITMQ_EXCHANGE_NAME", None)
7171
if exchange_name is not None:
7272
DEFAULT_STREAM_KEY_PREFIX += f":{exchange_name}"
73+
74+
# pending claim configuration
75+
# Only claim pending messages whose idle time exceeds this threshold.
76+
# Unit: milliseconds. Default: 10 minute.
77+
DEFAULT_PENDING_CLAIM_MIN_IDLE_MS = 600_000

src/memos/mem_scheduler/schemas/message_schemas.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from pydantic import BaseModel, ConfigDict, Field
66
from typing_extensions import TypedDict
77

8+
from memos.context.context import generate_trace_id
89
from memos.log import get_logger
910
from memos.mem_scheduler.general_modules.misc import DictConversionMixin
1011
from memos.mem_scheduler.utils.db_utils import get_utc_now
@@ -36,6 +37,7 @@ class ScheduleMessageItem(BaseModel, DictConversionMixin):
3637
redis_message_id: str = Field(default="", description="the message get from redis stream")
3738
stream_key: str = Field("", description="stream_key for identifying the queue in line")
3839
user_id: str = Field(..., description="user id")
40+
trace_id: str = Field(default_factory=generate_trace_id, description="trace id for logging")
3941
mem_cube_id: str = Field(..., description="memcube id")
4042
session_id: str = Field(default="", description="Session ID for soft-filtering memories")
4143
label: str = Field(..., description="Label of the schedule message")
@@ -80,6 +82,7 @@ def to_dict(self) -> dict:
8082
"item_id": self.item_id,
8183
"user_id": self.user_id,
8284
"cube_id": self.mem_cube_id,
85+
"trace_id": self.trace_id,
8386
"label": self.label,
8487
"cube": "Not Applicable", # Custom cube serialization
8588
"content": self.content,
@@ -95,6 +98,7 @@ def from_dict(cls, data: dict) -> "ScheduleMessageItem":
9598
item_id=data.get("item_id", str(uuid4())),
9699
user_id=data["user_id"],
97100
mem_cube_id=data["cube_id"],
101+
trace_id=data.get("trace_id", generate_trace_id()),
98102
label=data["label"],
99103
content=data["content"],
100104
timestamp=datetime.fromisoformat(data["timestamp"]),

src/memos/mem_scheduler/task_schedule_modules/dispatcher.py

Lines changed: 71 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,15 @@
44

55
from collections import defaultdict
66
from collections.abc import Callable
7-
from datetime import timezone
7+
from datetime import datetime, timezone
88
from typing import Any
99

10-
from memos.context.context import ContextThreadPoolExecutor
10+
from memos.context.context import (
11+
ContextThreadPoolExecutor,
12+
RequestContext,
13+
generate_trace_id,
14+
set_request_context,
15+
)
1116
from memos.log import get_logger
1217
from memos.mem_scheduler.general_modules.base import BaseSchedulerModule
1318
from memos.mem_scheduler.general_modules.task_threads import ThreadManager
@@ -19,6 +24,7 @@
1924
from memos.mem_scheduler.task_schedule_modules.redis_queue import SchedulerRedisQueue
2025
from memos.mem_scheduler.task_schedule_modules.task_queue import ScheduleTaskQueue
2126
from memos.mem_scheduler.utils.misc_utils import group_messages_by_user_and_mem_cube
27+
from memos.mem_scheduler.utils.monitor_event_utils import emit_monitor_event, to_iso
2228
from memos.mem_scheduler.utils.status_tracker import TaskStatusTracker
2329

2430

@@ -121,15 +127,26 @@ def _create_task_wrapper(self, handler: Callable, task_item: RunningTaskItem):
121127

122128
def wrapped_handler(messages: list[ScheduleMessageItem]):
123129
start_time = time.time()
130+
start_iso = datetime.fromtimestamp(start_time, tz=timezone.utc).isoformat()
124131
if self.status_tracker:
125132
self.status_tracker.task_started(
126133
task_id=task_item.item_id, user_id=task_item.user_id
127134
)
128135
try:
136+
first_msg = messages[0]
137+
trace_id = getattr(first_msg, "trace_id", None) or generate_trace_id()
138+
# Propagate trace_id and user info to logging context for this handler execution
139+
ctx = RequestContext(
140+
trace_id=trace_id,
141+
user_name=getattr(first_msg, "user_name", None),
142+
user_type=None,
143+
)
144+
set_request_context(ctx)
145+
129146
# --- mark start: record queuing time(now - enqueue_ts)---
130147
now = time.time()
131-
m = messages[0] # All messages in this batch have same user and type
132-
enq_ts = getattr(m, "timestamp", None)
148+
m = first_msg # All messages in this batch have same user and type
149+
enq_ts = getattr(first_msg, "timestamp", None)
133150

134151
# Path 1: epoch seconds (preferred)
135152
if isinstance(enq_ts, int | float):
@@ -149,17 +166,51 @@ def wrapped_handler(messages: list[ScheduleMessageItem]):
149166
wait_sec = max(0.0, now - enq_epoch)
150167
self.metrics.observe_task_wait_duration(wait_sec, m.user_id, m.label)
151168

169+
dequeue_ts = getattr(first_msg, "dequeue_ts", None)
170+
start_delay_ms = None
171+
if isinstance(dequeue_ts, int | float):
172+
start_delay_ms = max(0.0, start_time - dequeue_ts) * 1000
173+
174+
emit_monitor_event(
175+
"start",
176+
first_msg,
177+
{
178+
"start_ts": start_iso,
179+
"start_delay_ms": start_delay_ms,
180+
"enqueue_ts": to_iso(enq_ts),
181+
"dequeue_ts": to_iso(
182+
datetime.fromtimestamp(dequeue_ts, tz=timezone.utc)
183+
if isinstance(dequeue_ts, int | float)
184+
else None
185+
),
186+
},
187+
)
188+
152189
# Execute the original handler
153190
result = handler(messages)
154191

155192
# --- mark done ---
156-
duration = time.time() - start_time
193+
finish_time = time.time()
194+
duration = finish_time - start_time
157195
self.metrics.observe_task_duration(duration, m.user_id, m.label)
158196
if self.status_tracker:
159197
self.status_tracker.task_completed(
160198
task_id=task_item.item_id, user_id=task_item.user_id
161199
)
162200
self.metrics.task_completed(user_id=m.user_id, task_type=m.label)
201+
202+
emit_monitor_event(
203+
"finish",
204+
first_msg,
205+
{
206+
"status": "ok",
207+
"start_ts": start_iso,
208+
"finish_ts": datetime.fromtimestamp(
209+
finish_time, tz=timezone.utc
210+
).isoformat(),
211+
"exec_duration_ms": duration * 1000,
212+
},
213+
)
163214
# Redis ack is handled in finally to cover failure cases
164215

165216
# Mark task as completed and remove from tracking
@@ -172,11 +223,26 @@ def wrapped_handler(messages: list[ScheduleMessageItem]):
172223

173224
except Exception as e:
174225
m = messages[0]
226+
finish_time = time.time()
175227
self.metrics.task_failed(m.user_id, m.label, type(e).__name__)
176228
if self.status_tracker:
177229
self.status_tracker.task_failed(
178230
task_id=task_item.item_id, user_id=task_item.user_id, error_message=str(e)
179231
)
232+
emit_monitor_event(
233+
"finish",
234+
m,
235+
{
236+
"status": "fail",
237+
"start_ts": start_iso,
238+
"finish_ts": datetime.fromtimestamp(
239+
finish_time, tz=timezone.utc
240+
).isoformat(),
241+
"exec_duration_ms": (finish_time - start_time) * 1000,
242+
"error_type": type(e).__name__,
243+
"error_msg": str(e),
244+
},
245+
)
180246
# Mark task as failed and remove from tracking
181247
with self._task_lock:
182248
if task_item.item_id in self._running_tasks:

0 commit comments

Comments
 (0)