[LOOP-5558] rounding basal rates consistently (#885)

* rounding basal rates consistently

* removing rounding basal rate loop quantity

Author: nhamming

Loop/Managers/DeviceDataManager.swift

@@ -1343,10 +1343,6 @@ extension DeviceDataManager: DeliveryDelegate {
 
         return pumpManager.roundToSupportedBasalRate(unitsPerHour: unitsPerHour)
     }
-    
-    func roundBasalRate(rate: LoopQuantity) -> LoopQuantity {
-        LoopQuantity(unit: .internationalUnitsPerHour, doubleValue: roundBasalRate(unitsPerHour: rate.doubleValue(for: .internationalUnitsPerHour)))
-    }
 
     func roundBolusVolume(units: Double) -> Double {
         guard let pumpManager = pumpManager else {

Loop/Managers/LoopDataManager.swift

@@ -47,7 +47,6 @@ protocol DeliveryDelegate: AnyObject {
     func enact(bolus: Double?, tempBasal: TempBasalRecommendation?, decisionId: UUID?) async throws
     func enactBolus(units: Double, decisionId: UUID?, activationType: BolusActivationType) async throws
     func roundBasalRate(unitsPerHour: Double) -> Double
-    func roundBasalRate(rate: LoopQuantity) -> LoopQuantity
     func roundBolusVolume(units: Double) -> Double
 }
 

Loop/Views/Presets/Components/PresetDetentView.swift

@@ -26,7 +26,7 @@ struct PresetDetentView: View {
     @Environment(\.appName) private var appName
 
     let preset: SelectablePreset
-    let roundBasalRate: ((LoopQuantity) -> LoopQuantity)?
+    let roundBasalRate: ((Double) -> Double)?
     let didTapEdit: () -> Void
 
     var operation: Operation? {
@@ -127,7 +127,7 @@ struct PresetDetentView: View {
             return settingsImpact
         }
 
-        settingsImpact.basalRate = roundBasalRate(basalRate)
+        settingsImpact.basalRate = LoopQuantity(unit: .internationalUnitsPerHour, doubleValue:  roundBasalRate(basalRate.doubleValue(for: .internationalUnitsPerHour)))
         return settingsImpact
     }
 

Loop/Views/Presets/PresetsView.swift

@@ -92,7 +92,7 @@ struct PresetsView: View {
         settingsManager.therapySettings.glucoseTargetRangeSchedule?.quantityRange(at: Date())
     }
 
-    let roundBasalRate: ((LoopQuantity) -> LoopQuantity)?
+    let roundBasalRate: ((Double) -> Double)?
 
     var body: some View {
         NavigationStack(path: $navigationPath) {