Skip to content

Commit 452934e

Browse files
committed
add logging when an alerts event can't be consumed
Kafka/Sarama won't log it (at least not by default), and this isn't something we expect to see, so log it. BACK-2559
1 parent ea8740a commit 452934e

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

data/events/events.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,15 @@ func CappedExponentialBinaryDelay(cap time.Duration) func(int) time.Duration {
171171

172172
type AlertsEventsConsumer struct {
173173
Consumer asyncevents.SaramaMessageConsumer
174+
Logger log.Logger
174175
}
175176

176177
func (c *AlertsEventsConsumer) Consume(ctx context.Context,
177178
session sarama.ConsumerGroupSession, message *sarama.ConsumerMessage) error {
178179
err := c.Consumer.Consume(ctx, session, message)
179180
if err != nil {
180181
session.MarkMessage(message, fmt.Sprintf("I have given up after error: %s", err))
182+
c.Logger.WithError(err).Info("Unable to consume alerts event")
181183
return err
182184
}
183185
return nil

data/service/service/standard.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -508,6 +508,7 @@ func (s *Standard) initializeAlertsEventsHandler() error {
508508
Sarama: commonConfig.SaramaConfig,
509509
MessageConsumer: &dataEvents.AlertsEventsConsumer{
510510
Consumer: ec,
511+
Logger: s.Logger(),
511512
},
512513
}
513514

0 commit comments

Comments
 (0)