Validate basal rate scheduled maximum number of segments

Author: toddkazakov

go.mod

@@ -21,7 +21,7 @@ require (
 	github.com/prometheus/client_golang v1.19.1
 	github.com/rinchsan/device-check-go v1.3.0
 	github.com/tidepool-org/clinic/client v0.0.0-20240629034458-1365c8963143
-	github.com/tidepool-org/devices/api v0.0.0-20240412011010-75b16d8daec0
+	github.com/tidepool-org/devices/api v0.0.0-20240711091104-8b8e20a3e2c7
 	github.com/tidepool-org/go-common v0.12.2-0.20240612192926-de6d5c5a742c
 	github.com/tidepool-org/hydrophone/client v0.0.0-20240613043503-6c32828b1ace
 	github.com/urfave/cli v1.22.15
@@ -34,7 +34,7 @@ require (
 	golang.org/x/sync v0.7.0
 	golang.org/x/tools v0.22.0
 	gonum.org/v1/gonum v0.15.0
-	google.golang.org/grpc v1.64.0
+	google.golang.org/grpc v1.65.0
 	gopkg.in/yaml.v2 v2.4.0
 	syreclabs.com/go/faker v1.2.3
 )

go.sum

@@ -176,8 +176,8 @@ github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsT
 github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
 github.com/tidepool-org/clinic/client v0.0.0-20240629034458-1365c8963143 h1:A6qFjC5yMhC0xMfcci4lo3/tVq1k2q5Jt/BjsP3NtdQ=
 github.com/tidepool-org/clinic/client v0.0.0-20240629034458-1365c8963143/go.mod h1:7BpAdFdGJNB3aw/xvCz5XnWjSWRoUtWIX4xcMc4Bsko=
-github.com/tidepool-org/devices/api v0.0.0-20240412011010-75b16d8daec0 h1:SnIsHwaJE2kltz9xMfjC+L9SWhQS3w6t+mSIIoFiwag=
-github.com/tidepool-org/devices/api v0.0.0-20240412011010-75b16d8daec0/go.mod h1:pu8FmuhxtBbOyswB94Mr15l2heCxY357lVHOVVAEZq8=
+github.com/tidepool-org/devices/api v0.0.0-20240711091104-8b8e20a3e2c7 h1:sfE4V+umi8HM8T2RJLuCd/Dfx/Ba0XREXbfTamke+Aw=
+github.com/tidepool-org/devices/api v0.0.0-20240711091104-8b8e20a3e2c7/go.mod h1:xuQ8k0mLR1ZyEmwe/m0v2BuXctqQuCZeR43urSQpTUM=
 github.com/tidepool-org/go-common v0.12.2-0.20240612192926-de6d5c5a742c h1:hJZyiHNGeqyLA/5p60/0H9CZtJi4fAuzOuyQF0TpF7E=
 github.com/tidepool-org/go-common v0.12.2-0.20240612192926-de6d5c5a742c/go.mod h1:mIzYteUyPf//fhee4e2KEZhmcm2iE4IQ/2dyQr5pRKA=
 github.com/tidepool-org/hydrophone/client v0.0.0-20240613043503-6c32828b1ace h1:L0UiCj2eL/NOpLa19Tf5IgoK6feILmdA+zK3nCTIhqU=
@@ -290,8 +290,8 @@ google.golang.org/genproto/googleapis/api v0.0.0-20240624140628-dc46fd24d27d h1:
 google.golang.org/genproto/googleapis/api v0.0.0-20240624140628-dc46fd24d27d/go.mod h1:Od4k8V1LQSizPRUK4OzZ7TBE/20k+jPczUDAEyvn69Y=
 google.golang.org/genproto/googleapis/rpc v0.0.0-20240624140628-dc46fd24d27d h1:k3zyW3BYYR30e8v3x0bTDdE9vpYFjZHK+HcyqkrppWk=
 google.golang.org/genproto/googleapis/rpc v0.0.0-20240624140628-dc46fd24d27d/go.mod h1:Ue6ibwXGpU+dqIcODieyLOcgj7z8+IcskoNIgZxtrFY=
-google.golang.org/grpc v1.64.0 h1:KH3VH9y/MgNQg1dE7b3XfVK0GsPSIzJwdF617gUSbvY=
-google.golang.org/grpc v1.64.0/go.mod h1:oxjF8E3FBnjp+/gVFYdWacaLDx9na1aqy9oovLpxQYg=
+google.golang.org/grpc v1.65.0 h1:bs/cUb4lp1G5iImFFd3u5ixQzweKizoZJAwBNLR42lc=
+google.golang.org/grpc v1.65.0/go.mod h1:WgYC2ypjlB0EiQi6wdKixMqukr6lBc0Vo+oOgjrM5ZQ=
 google.golang.org/protobuf v1.34.2 h1:6xV6lTsCfpGD21XK49h7MhtcApnLqkfYgPcdHftf6hg=
 google.golang.org/protobuf v1.34.2/go.mod h1:qYOHts0dSfpeUzUFpOMr/WGzszTmLH+DiWniOlNbLDw=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

guardrails/basal_rate_schedule.go

@@ -3,13 +3,18 @@ package guardrails
 import (
 	devices "github.com/tidepool-org/devices/api"
 
+	structureValidator "github.com/tidepool-org/platform/structure/validator"
+
 	"strconv"
 
 	"github.com/tidepool-org/platform/data/types/settings/pump"
 	"github.com/tidepool-org/platform/structure"
 )
 
 func ValidateBasalRateSchedule(basalRateSchedule pump.BasalRateStartArray, guardRail *devices.BasalRatesGuardRail, validator structure.Validator) {
+	if guardRail.MaxSegments != nil && len(basalRateSchedule) > int(*guardRail.MaxSegments) {
+		validator.ReportError(structureValidator.ErrorLengthNotLessThanOrEqualTo(len(basalRateSchedule), int(*guardRail.MaxSegments)))
+	}
 	validValues := generateAllValidValues(guardRail.AbsoluteBounds)
 	for i, basalRate := range basalRateSchedule {
 		ValidateValueIfNotNil(basalRate.Rate, validValues, validator.WithReference(strconv.Itoa(i)).WithReference("rate"))

guardrails/basal_rate_schedule_test.go

@@ -62,7 +62,7 @@ var _ = Describe("ValidateBasalRateSchedule", func() {
 		errorsTest.ExpectEqual(validator.Error(), expected)
 	})
 
-	It("returns an error with a value low than the pump min supported value", func() {
+	It("returns an error with a value lower than the pump min supported value", func() {
 		var schedule pump.BasalRateStartArray = []*pump.BasalRateStart{
 			{Rate: pointer.FromFloat64(0.55)},
 			{Rate: pointer.FromFloat64(0.0)},
@@ -72,4 +72,18 @@ var _ = Describe("ValidateBasalRateSchedule", func() {
 		guardrails.ValidateBasalRateSchedule(schedule, guardRail, validator)
 		errorsTest.ExpectEqual(validator.Error(), expected)
 	})
+
+	It("returns an error when the number of segments is higher than the guardrail", func() {
+		maxSegments := int32(2)
+		guardRail.MaxSegments = &maxSegments
+		var schedule pump.BasalRateStartArray = []*pump.BasalRateStart{
+			{Rate: pointer.FromFloat64(0.55)},
+			{Rate: pointer.FromFloat64(15.55)},
+			{Rate: pointer.FromFloat64(16.55)},
+		}
+
+		expected := errorsTest.WithPointerSource(structureValidator.ErrorLengthNotLessThanOrEqualTo(3, 2), "")
+		guardrails.ValidateBasalRateSchedule(schedule, guardRail, validator)
+		errorsTest.ExpectEqual(validator.Error(), expected)
+	})
 })