nitpicks and docs updates

Author: jh-bate

src/components/settings/NonTandem.js

@@ -207,7 +207,7 @@ const NonTandem = (props) => {
         </div>
       </div>
       <pre className={styles.copyText} id="copySettingsText">
-        {nonTandemText(pumpSettings, lookupKey, bgUnits)}
+        {nonTandemText(pumpSettings, bgUnits, lookupKey)}
       </pre>
     </div>
   );

src/components/settings/README.md

@@ -11,7 +11,7 @@ To keep our componets as similar when viewed in the web app as when printed. Whe
 Based on the mode the component is being viewed in we have a prop that can be used and then the component be shown in a different state. In the settings instance it means showing all the settings sections expanded.
 
 ```
-printView: React.PropTypes.bool.isRequired
+view: PropTypes.oneOf([DISPLAY_VIEW, PRINT_VIEW]).isRequired,
 ```
 
 *In the css:*
@@ -22,3 +22,13 @@ If there are any specific print styles these are contained in the section below.
     ....
 }
 ```
+
+
+### copy text
+
+*Aim:*
+To enable the easy copy and pasting of the settings while also allowing the user to modify the table that has been copied. To do this we need to remove all styles and have a very simple text representation of the table while still keeping its basic format.
+
+*In the component:*
+We are using `ClipboardButton` and then have built a text representation of the settings that essentially uses a commandline tool `text-table`. This is then embedded in a `<pre>..</pre>` tag as we want to ensure no styles are copied. All of the work is done in `utils\settings\textData.js` to built the table.
+

src/components/settings/Tandem.js

@@ -101,7 +101,7 @@ const Tandem = (props) => {
         {tables}
       </div>
       <pre className={styles.copyText} id="copySettingsText">
-        {tandemText(pumpSettings, bgUnits, styles)}
+        {tandemText(pumpSettings, bgUnits)}
       </pre>
     </div>
   );

src/components/settings/constants.js

@@ -15,6 +15,5 @@
  * == BSD2 LICENSE ==
  */
 
-export const COPY_VIEW = 'copy';
 export const DISPLAY_VIEW = 'display';
 export const PRINT_VIEW = 'print';

src/containers/settings/PumpSettingsContainer.css

@@ -25,7 +25,7 @@ import { MGDL_UNITS, MMOLL_UNITS } from '../../utils/constants';
 
 import NonTandem from '../../components/settings/NonTandem';
 import Tandem from '../../components/settings/Tandem';
-import { COPY_VIEW, DISPLAY_VIEW, PRINT_VIEW } from '../../components/settings/constants';
+import { DISPLAY_VIEW, PRINT_VIEW } from '../../components/settings/constants';
 
 export class PumpSettingsContainer extends PureComponent {
   static propTypes = {
@@ -44,7 +44,7 @@ export class PumpSettingsContainer extends PureComponent {
     }).isRequired,
     settingsState: PropTypes.object.isRequired,
     toggleSettingsSection: PropTypes.func.isRequired,
-    view: PropTypes.oneOf([COPY_VIEW, DISPLAY_VIEW, PRINT_VIEW]).isRequired,
+    view: PropTypes.oneOf([DISPLAY_VIEW, PRINT_VIEW]).isRequired,
   }
 
   componentWillMount() {

src/containers/settings/PumpSettingsContainer.js

@@ -95,12 +95,12 @@ function buildTextTable(name, rows, columns) {
 /**
  * nonTandemText
  * @param  {Object} settings      all settings data
- * @param  {String} manufacturer  one of: animas, carelink, insulet, medtronic
  * @param  {String} units         MGDL_UNITS or MMOLL_UNITS
+ * @param  {String} manufacturer  one of: animas, carelink, insulet, medtronic
  *
  * @return {String}               non tandem settings as a string table
  */
-export function nonTandemText(settings, manufacturer, units) {
+export function nonTandemText(settings, units, manufacturer) {
   let tablesString = '';
   _.map(nonTandemData.basalSchedules(settings), (schedule) => {
     const basal = nonTandemData.basal(schedule, settings, manufacturer);
@@ -139,11 +139,15 @@ export function nonTandemText(settings, manufacturer, units) {
  * tandemText
  * @param  {Object} settings    all settings data
  * @param  {String} units       MGDL_UNITS or MMOLL_UNITS
- * @param  {Object} styles      styles applied
  *
  * @return {String}             tandem settings as a string table
  */
-export function tandemText(settings, units, styles) {
+export function tandemText(settings, units) {
+  const styles = {
+    bolusSettingsHeader: '',
+    basalScheduleHeader: '',
+  };
+
   let tablesString = '';
   _.map(tandemData.basalSchedules(settings), (schedule) => {
     const basal = tandemData.basal(schedule, settings, units, styles);