Current commander version causes build failure

[hansemannn]

When using ti serve -p ios with the latest CLI (and older as well), the build fails:

TypeError: Cannot read properties of undefined (reading 'commands')
    at Module.config (/Users/user/.nvm/versions/node/v18.19.0/lib/node_modules/liveview/dist/node/commands/serve.js:28:46)
    at CLI.loadCommand (file:///Users/user/.nvm/versions/node/v20.18.1/lib/node_modules/titanium/src/cli.js:946:32)
    at async file:///Users/user/.nvm/versions/node/v20.18.1/lib/node_modules/titanium/src/cli.js:829:4
    at async Command.parseAsync (/Users/user/.nvm/versions/node/v20.18.1/lib/node_modules/titanium/node_modules/commander/lib/command.js:1092:5)
    at async CLI.go (file:///Users/user/.nvm/versions/node/v20.18.1/lib/node_modules/titanium/src/cli.js:532:3)
    at async file:///Users/user/.nvm/versions/node/v20.18.1/lib/node_modules/titanium/src/main.js:8:2

Updating the commander usage fixes the issue, but I'm not sure where exactly it's used here, maybe @cb1kenobi knows more?

[cb1kenobi]

I thought we fixed this? Are you using the latest Titanium CLI? When you say "updating the commander usage", what does that mean?

[hansemannn]

I thought so as well - actually in liveview (next branch). But it's still causing issue with latest titanium-cli and liveview@next. cc @janvennemann Maybe it should be handled in liveview?

[janvennemann]

If i remember correctly this is due to the fact that the new Titanium CLI does not support adding new commands. And liveview@next tries to add a new serve command. The serve command basically skips the whole build process und just starts the app if it was build previously and only JS files were changed between runs. To get the same behavior for the new Titanium CLI we either need to create an own CLI for Liveview (which internally calls ti build), or add the serve command directly to the Titanium CLI.

[cb1kenobi]

Ah, I bet this is the problem... there is no cli.globalContext: https://github.com/tidev/liveview/blob/next/src/node/commands/serve.ts#L33. I honestly don't remember if there ever was. I wonder if you could just remove the "globalContext"?

[hansemannn]

Oh yes, the fix was to use the "old" Titanium SDK. But does the command invocation work without it?

[janvennemann]

Ah, I bet this is the problem... there is no cli.globalContext: https://github.com/tidev/liveview/blob/next/src/node/commands/serve.ts#L33. I honestly don't remember if there ever was. I wonder if you could just remove the "globalContext"?

Accessing cli.globalContext here is just the entry point to load the build command module. The whole construct is one huge hack to get deep access into the build command and change callbacks, launch options and other things. But it looks like the new CLI supports custom command now? Maybe i have to take a look at it and see if i can get it to work again.