Android: Target SDK 36

[m1ga]

I have searched and made sure there are no existing issues for the issue I am filing

• I have searched the existing issues

Description

Just a ticket so we can prepare the Android part for the next target API level update to 36.

In 36 our edge-to-edge workaround is getting remove:
https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edge
so we have to make sure all UI elements work in edge-to-edge mode.

Solution

Make all UI elements edge-to-edge ready

Alternatives

No response

Platforms

Android

[m1ga]

@prashantsaini1 think I'll need a lot of help here. So if you have some ideas where to start feel free. My guess is that we have until next November to solve this 😄

[prashantsaini1]

@m1ga Sure, I would start with researching about iOS behaviour in order to keep SDK parity in both platforms and still giving native user experiences.

On a side note, I was recently looking into proper Material 3 support with backward compatibility and many apps I tried crashes right after launch. So let's just hope we don't bump into Material 3 while supporting edge to edge 😀.

[m1ga]

I'm pretty sure I know why: tidev/ti.map#703
Maps will crash with the Material3 BottomNavigation and BottomNavigationView

[m1ga]

Playing around with some settings again. When I add:

		ViewCompat.setOnApplyWindowInsetsListener(nativeView, (v, insets) -> {
			Insets bars = insets.getInsets(
				WindowInsetsCompat.Type.systemBars()
					| WindowInsetsCompat.Type.displayCutout()
			);
			v.setPadding(bars.left, bars.top, bars.right, bars.bottom);
			return WindowInsetsCompat.CONSUMED;
		});

here: https://github.com/tidev/titanium-sdk/blob/main/android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java#L346

it will fix the start layout in kitchensink:

The child windows still start at the wrong position:

(row 1 - 2 are not visible)

And rotating the device will break the layout completely 😄

[prashantsaini1]

@m1ga In your last test code, I noticed that you are returning WindowInsetsCompat.CONSUMED, I think that's where the problem could be. Could you please do one quick test?

1. Change return WindowInsetsCompat.CONSUMED; to return insets;.
2. Also the displayCutout is not necessary required as it's included in systemBars.
3. Move this code inside the TiBaseActivity and call it right after the setContentView inside the onCreate. Pass the view as the one we set in setContentView() since it's the base view.

Here's the updated code:

ViewCompat.setOnApplyWindowInsetsListener(view, (v, insets) -> {
    Insets bars = insets.getInsets(WindowInsetsCompat.Type.systemBars());
    v.setPadding(bars.left, bars.top, bars.right, bars.bottom);
    return insets; // not the "WindowInsetsCompat.CONSUMED" as it'll stop the inset propagation to child-views.
});

[m1ga]

Main screens (tabgroup) is missing the first row with that code:

and so are the subviews (as it was with my code too):

when I rotate it it looks like this:

[prashantsaini1]

I think I know why it behaves like this. In general the code is doing as expected, but we need to handle it further for Tab navigations, Toolbar, Snacks, BottomSheet, etc. It should already work for a flat window without any Toolbar or Tabgroup.