Android: Can't pass flags to Ti.Database.open

[grebulon]

I have searched and made sure there are no existing issues for the issue I am filing

• I have searched the existing issues

Description

For Android, I need to pass SQLiteDatabase.ENABLE_WRITE_AHEAD_LOGGING flag when opening the database. This is not possible since there are no options to the method. The database is always opened as

QLiteDatabase db = SQLiteDatabase.openDatabase(absolutePath, null,
        SQLiteDatabase.CREATE_IF_NECESSARY | SQLiteDatabase.NO_LOCALIZED_COLLATORS);

Expected Behavior

Need to add an optional parameter for additional flags.

Actual behavior

Can only pass the db name

Reproducible sample

n/a

Steps to reproduce

n/a

Platform

No response

SDK version you are using

GA.13

Alloy version you are using

No response

[m1ga]

As a workaround: can't you use PRAGMA journal_mode=WAL for that?

Sadly we have one fixed file parameter for both platforms so it's not that trivial to add another flags parameter. But I'll check what the best option would be (e.g. check if it is a object like {file: "...", flags: ...} or maybe add an optional 2nd parameter for the flags)

[m1ga]

And just in case that is not enough I've started #14358

[grebulon]

I need to do use enableWriteAheadLogging() (which is also missing from the Titanium API). This doesn't work with PRAGMA journal_mode. This is also stated in the documentation.
Strangely, PRAGMA journal_mode=WAL does work in iOS.

[m1ga]

Then please test the SDK at the bottom of: https://github.com/tidev/titanium-sdk/actions/runs/20044902625?pr=14358

As your first link is says:

The most efficient way to enable write-ahead logging is to pass the ENABLE_WRITE_AHEAD_LOGGING flag to openDatabase(File, OpenParams). This is more efficient than calling enableWriteAheadLogging(). 

so ENABLE_WRITE_AHEAD_LOGGING should be better then calling enableWriteAheadLogging.
With the PR you can now use a 2nd parameter in open() and use these constants:
https://github.com/tidev/titanium-sdk/pull/14358/files#diff-af30cc84b55e624e340dc60eef1ed649a1ac33f0f7ec8421cc7669efe21e1d2aR49-R58
Keep in mind: as soon as you set custom flags the default flags will be gone. So you have to set those too in case you'll need them.

[m1ga]

@grebulon did you have time to test the custom SDK?

[grebulon]

Not yet