Merge branch 'main' into more-objectives-lightgbm

Author: EmilHvitfeldt

NEWS.md

@@ -4,6 +4,8 @@
 
 * Increased the minimum R version to R 4.1.
 
+* Fixed bug where `num_threads` argument were ignored for lightgbm engine (#105).
+
 # bonsai 0.3.2
 
 * Resolves a test failure ahead of an upcoming parsnip release (#95).

R/lightgbm.R

@@ -101,7 +101,6 @@ train_lightgbm <- function(
     )
 
   args <- process_bagging(args)
-  args <- process_parallelism(args)
   args <- process_objective_function(args, y)
 
   args <- sort_args(args)
@@ -213,17 +212,6 @@ process_objective_function <- function(args, y) {
   args
 }
 
-# supply the number of threads as num_threads in params, clear out
-# any other thread args that might be passed as main arguments
-process_parallelism <- function(args) {
-  if (!is.null(args["num_threads"])) {
-    args$num_threads <- args[names(args) == "num_threads"]
-    args[names(args) == "num_threads"] <- NULL
-  }
-
-  args
-}
-
 process_bagging <- function(args) {
   if (
     args$bagging_fraction != 1 &&