Merge pull request #107 from tidymodels/only-cli

Author: EmilHvitfeldt

DESCRIPTION

@@ -30,7 +30,6 @@ Imports:
     cli,
     dials,
     dplyr,
-    glue,
     purrr,
     rlang (>= 1.1.0),
     stats,

R/lightgbm.R

@@ -309,11 +309,9 @@ sort_args <- function(args) {
   if (any(names(args) %in% protected)) {
     protected_args <- names(args[names(args) %in% protected])
 
-    rlang::warn(
-      glue::glue(
-        "The following argument(s) are guarded by bonsai and will not ",
-        "be passed to LightGBM: {glue::glue_collapse(protected_args, sep = ', ')}"
-      )
+    cli::cli_warn(
+      "The following argument{?s} {?is/are} guarded by bonsai and will not be 
+      passed to LightGBM: {protected_args}."
     )
 
     args[protected_args] <- NULL

tests/testthat/_snaps/lightgbm.md

@@ -51,7 +51,7 @@
         1:ncol(penguins))), "regression"), bill_length_mm ~ ., data = penguins)
     Condition
       Warning:
-      The following argument(s) are guarded by bonsai and will not be passed to LightGBM: colnames
+      The following argument is guarded by bonsai and will not be passed to LightGBM: colnames.
 
 ---
 
@@ -61,7 +61,7 @@
       bill_length_mm ~ ., data = penguins)
     Condition
       Warning:
-      The following argument(s) are guarded by bonsai and will not be passed to LightGBM: colnames, callbacks
+      The following arguments are guarded by bonsai and will not be passed to LightGBM: colnames and callbacks.
 
 ---
 
@@ -70,7 +70,7 @@
         1:ncol(penguins))), "regression"), bill_length_mm ~ ., data = penguins)
     Condition
       Warning:
-      The following argument(s) are guarded by bonsai and will not be passed to LightGBM: colnames
+      The following argument is guarded by bonsai and will not be passed to LightGBM: colnames.
 
 ---